| Message ID | 1303914147-23012-1-git-send-email-broonie@opensource.wolfsonmicro.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, 27 Apr 2011 15:22:27 +0100 Mark Brown <broonie@opensource.wolfsonmicro.com> wrote: > There's no point in supporting NFS export of filesystems if we don't have > nfsd in the first place. > > Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com> > --- > fs/cifs/Kconfig | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/fs/cifs/Kconfig b/fs/cifs/Kconfig > index 75c47cd..61e5f95 100644 > --- a/fs/cifs/Kconfig > +++ b/fs/cifs/Kconfig > @@ -175,6 +175,6 @@ config CIFS_SMB2 > > config CIFS_NFSD_EXPORT > bool "Allow nfsd to export CIFS file system (EXPERIMENTAL)" > - depends on CIFS && EXPERIMENTAL > + depends on CIFS && NFSD && EXPERIMENTAL > help > Allows NFS server to export a CIFS mounted share (nfsd over cifs) This looks ok, though I'd still prefer to see all of the nfs exporting code removed. The cifs protocol has no consistent way to look up inodes by filehandle and so it simply can never work. Acked-by: Jeff Layton <jlayton@redhat.com> -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Apr 27, 2011 at 9:29 AM, Jeff Layton <jlayton@redhat.com> wrote: > On Wed, 27 Apr 2011 15:22:27 +0100 > Mark Brown <broonie@opensource.wolfsonmicro.com> wrote: > >> There's no point in supporting NFS export of filesystems if we don't have >> nfsd in the first place. >> >> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com> >> --- >> fs/cifs/Kconfig | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/fs/cifs/Kconfig b/fs/cifs/Kconfig >> index 75c47cd..61e5f95 100644 >> --- a/fs/cifs/Kconfig >> +++ b/fs/cifs/Kconfig >> @@ -175,6 +175,6 @@ config CIFS_SMB2 >> >> config CIFS_NFSD_EXPORT >> bool "Allow nfsd to export CIFS file system (EXPERIMENTAL)" >> - depends on CIFS && EXPERIMENTAL >> + depends on CIFS && NFSD && EXPERIMENTAL >> help >> Allows NFS server to export a CIFS mounted share (nfsd over cifs) > > This looks ok, though I'd still prefer to see all of the nfs exporting > code removed. The cifs protocol has no consistent way to look up inodes > by filehandle and so it simply can never work. > > Acked-by: Jeff Layton <jlayton@redhat.com> Patch seems reasonable
diff --git a/fs/cifs/Kconfig b/fs/cifs/Kconfig index 75c47cd..61e5f95 100644 --- a/fs/cifs/Kconfig +++ b/fs/cifs/Kconfig @@ -175,6 +175,6 @@ config CIFS_SMB2 config CIFS_NFSD_EXPORT bool "Allow nfsd to export CIFS file system (EXPERIMENTAL)" - depends on CIFS && EXPERIMENTAL + depends on CIFS && NFSD && EXPERIMENTAL help Allows NFS server to export a CIFS mounted share (nfsd over cifs)
There's no point in supporting NFS export of filesystems if we don't have nfsd in the first place. Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com> --- fs/cifs/Kconfig | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)