| Message ID | 1448363546-31193-1-git-send-email-sudipm.mukherjee@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Nov 24, 2015 at 04:42:26PM +0530, Sudip Mukherjee wrote: > hdac->num_nodes is unsigned int and can never be less than 0. > Or, maybe, another way can be to declare num_nodes as int. Then this > test makes sense and also snd_hdac_get_sub_nodes() is returning an int. Yes, that's a better fix: > hdac->num_nodes = snd_hdac_get_sub_nodes(hdac, hdac->afg, &nid); > - if (!nid || hdac->num_nodes < 0) { > + if (!nid) { it's clear that we're looking for an error code on failure here.
diff --git a/sound/soc/codecs/hdac_hdmi.c b/sound/soc/codecs/hdac_hdmi.c index 205f2c2..02109aa 100644 --- a/sound/soc/codecs/hdac_hdmi.c +++ b/sound/soc/codecs/hdac_hdmi.c @@ -415,7 +415,7 @@ static int hdac_hdmi_parse_and_map_nid(struct hdac_ext_device *edev) int cvt_nid = 0, pin_nid = 0; hdac->num_nodes = snd_hdac_get_sub_nodes(hdac, hdac->afg, &nid); - if (!nid || hdac->num_nodes < 0) { + if (!nid) { dev_warn(&hdac->dev, "HDMI: failed to get afg sub nodes\n"); return -EINVAL; }
hdac->num_nodes is unsigned int and can never be less than 0. Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> --- Or, maybe, another way can be to declare num_nodes as int. Then this test makes sense and also snd_hdac_get_sub_nodes() is returning an int. sound/soc/codecs/hdac_hdmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)