| Message ID | 1447419641-6330-2-git-send-email-marcandre.lureau@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 13 November 2015 at 23:00, Marc-André Lureau <marcandre.lureau@gmail.com> wrote: > It seems appropriate for paravirtual hardware to reset cursor when the > resolution changes, that way the cursor is removed if the machine is > forcefully rebooted for ex. That's what the QXL/Spice server does. In > order for virtio-gpu to work will with the Spice server, set the cursor > again after changing the scanout. I'm really not sure about this, I think we should probably have qemu do this if necessary. Normal GPU hw the cursor is independant from the modesetting, and we turn it on/off. I don't think the virt GPU should operate differently here. Dave.
diff --git a/drivers/gpu/drm/virtio/virtgpu_plane.c b/drivers/gpu/drm/virtio/virtgpu_plane.c index 4a74129..7cb0e22 100644 --- a/drivers/gpu/drm/virtio/virtgpu_plane.c +++ b/drivers/gpu/drm/virtio/virtgpu_plane.c @@ -84,6 +84,7 @@ static void virtio_gpu_plane_atomic_update(struct drm_plane *plane, plane->state->crtc_h, plane->state->crtc_x, plane->state->crtc_y); + virtio_gpu_cursor_ping(vgdev, output); }
It seems appropriate for paravirtual hardware to reset cursor when the resolution changes, that way the cursor is removed if the machine is forcefully rebooted for ex. That's what the QXL/Spice server does. In order for virtio-gpu to work will with the Spice server, set the cursor again after changing the scanout. Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com> --- drivers/gpu/drm/virtio/virtgpu_plane.c | 1 + 1 file changed, 1 insertion(+)