| Message ID | 1448987062-31225-6-git-send-email-carlo@caione.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Dec 01, 2015 at 05:24:21PM +0100, Carlo Caione wrote: > From: Carlo Caione <carlo@endlessm.com> > > Extend the pinctrl binding documentation with the support for external > GPIO interrupts. > > Signed-off-by: Carlo Caione <carlo@endlessm.com> > Signed-off-by: Beniamino Galvani <b.galvani@gmail.com> > --- > Documentation/devicetree/bindings/pinctrl/meson,pinctrl.txt | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pinctrl/meson,pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/meson,pinctrl.txt > index 3f6a524..de669ce 100644 > --- a/Documentation/devicetree/bindings/pinctrl/meson,pinctrl.txt > +++ b/Documentation/devicetree/bindings/pinctrl/meson,pinctrl.txt > @@ -3,6 +3,12 @@ > Required properties for the root node: > - compatible: "amlogic,meson8-pinctrl" or "amlogic,meson8b-pinctrl" > - reg: address and size of registers controlling irq functionality > + - reg-names: should be "irq" > + - interrupt-controller: marks the device node as an interrupt controller > + - #interrupt-cells: should be 2. The first cell is the GPIO number. The > + second cell is used to specify trigger type. > + - amlogic,irqs-gpio: specifies the GPIO IRQ numbers on the GIC (GPIO_IRQ#) > + - interrupt-parent: specifies the parent interrupt controller. > > === GPIO sub-nodes === > > @@ -46,7 +52,12 @@ pinctrl-bindings.txt > > pinctrl: pinctrl@c1109880 { > compatible = "amlogic,meson8-pinctrl"; > + reg-names = "irq"; > reg = <0xc1109880 0x10>; > + interrupt-parent = <&gic>; > + amlogic,irqs-gpio = <64 65 66 67 68 69 70 71>; Can't you just use "interrupts" here? Rob > + interrupt-controller; > + #interrupt-cells = <2>; > #address-cells = <1>; > #size-cells = <1>; > ranges; > -- > 2.5.0 >
On Wed, Dec 2, 2015 at 4:30 PM, Rob Herring <robh@kernel.org> wrote: > On Tue, Dec 01, 2015 at 05:24:21PM +0100, Carlo Caione wrote: >> From: Carlo Caione <carlo@endlessm.com> >> >> Extend the pinctrl binding documentation with the support for external >> GPIO interrupts. >> >> Signed-off-by: Carlo Caione <carlo@endlessm.com> >> Signed-off-by: Beniamino Galvani <b.galvani@gmail.com> >> --- >> Documentation/devicetree/bindings/pinctrl/meson,pinctrl.txt | 11 +++++++++++ >> 1 file changed, 11 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/pinctrl/meson,pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/meson,pinctrl.txt >> index 3f6a524..de669ce 100644 >> --- a/Documentation/devicetree/bindings/pinctrl/meson,pinctrl.txt >> +++ b/Documentation/devicetree/bindings/pinctrl/meson,pinctrl.txt >> @@ -3,6 +3,12 @@ >> Required properties for the root node: >> - compatible: "amlogic,meson8-pinctrl" or "amlogic,meson8b-pinctrl" >> - reg: address and size of registers controlling irq functionality >> + - reg-names: should be "irq" >> + - interrupt-controller: marks the device node as an interrupt controller >> + - #interrupt-cells: should be 2. The first cell is the GPIO number. The >> + second cell is used to specify trigger type. >> + - amlogic,irqs-gpio: specifies the GPIO IRQ numbers on the GIC (GPIO_IRQ#) >> + - interrupt-parent: specifies the parent interrupt controller. >> >> === GPIO sub-nodes === >> >> @@ -46,7 +52,12 @@ pinctrl-bindings.txt >> >> pinctrl: pinctrl@c1109880 { >> compatible = "amlogic,meson8-pinctrl"; >> + reg-names = "irq"; >> reg = <0xc1109880 0x10>; >> + interrupt-parent = <&gic>; >> + amlogic,irqs-gpio = <64 65 66 67 68 69 70 71>; > > Can't you just use "interrupts" here? Following this discussion for v2 with Marc http://www.spinics.net/lists/devicetree/msg104385.html I decided to move away from using the "interrupts" property since these interrupts are not actually the pinctrl's interrupts (they are owned by the devices using them). I guess that using "interrupts" would be a bit misleading.
diff --git a/Documentation/devicetree/bindings/pinctrl/meson,pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/meson,pinctrl.txt index 3f6a524..de669ce 100644 --- a/Documentation/devicetree/bindings/pinctrl/meson,pinctrl.txt +++ b/Documentation/devicetree/bindings/pinctrl/meson,pinctrl.txt @@ -3,6 +3,12 @@ Required properties for the root node: - compatible: "amlogic,meson8-pinctrl" or "amlogic,meson8b-pinctrl" - reg: address and size of registers controlling irq functionality + - reg-names: should be "irq" + - interrupt-controller: marks the device node as an interrupt controller + - #interrupt-cells: should be 2. The first cell is the GPIO number. The + second cell is used to specify trigger type. + - amlogic,irqs-gpio: specifies the GPIO IRQ numbers on the GIC (GPIO_IRQ#) + - interrupt-parent: specifies the parent interrupt controller. === GPIO sub-nodes === @@ -46,7 +52,12 @@ pinctrl-bindings.txt pinctrl: pinctrl@c1109880 { compatible = "amlogic,meson8-pinctrl"; + reg-names = "irq"; reg = <0xc1109880 0x10>; + interrupt-parent = <&gic>; + amlogic,irqs-gpio = <64 65 66 67 68 69 70 71>; + interrupt-controller; + #interrupt-cells = <2>; #address-cells = <1>; #size-cells = <1>; ranges;