| Message ID | b5fefb09811c22cd101a44ac753293af942087fc.1303398927.git.dsterba@suse.cz (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Apr 25, 2011 at 08:12:59AM -0400, Chris Mason wrote: > > This code tests whether the mutex_lock can be acquired, and when the > > mutex_lock can be taken, it try again. > > So I think that it is not a meaningless code. > > Correct, this code is waiting for the current lock holder to finish. > It's not exactly pretty but it needs to stay. Ok, I think it deserves a comment, will add it and resend. david -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c index 31f33ba..c97ceab 100644 --- a/fs/btrfs/extent-tree.c +++ b/fs/btrfs/extent-tree.c @@ -756,8 +756,6 @@ again: btrfs_release_path(root->fs_info->extent_root, path); - mutex_lock(&head->mutex); - mutex_unlock(&head->mutex); btrfs_put_delayed_ref(&head->node); goto again; } @@ -2297,8 +2295,6 @@ again: atomic_inc(&ref->refs); spin_unlock(&delayed_refs->lock); - mutex_lock(&head->mutex); - mutex_unlock(&head->mutex); btrfs_put_delayed_ref(ref); cond_resched(); @@ -2363,8 +2359,6 @@ static noinline int check_delayed_ref(struct btrfs_trans_handle *trans, btrfs_release_path(root->fs_info->extent_root, path); - mutex_lock(&head->mutex); - mutex_unlock(&head->mutex); btrfs_put_delayed_ref(&head->node); return -EAGAIN; }
Signed-off-by: David Sterba <dsterba@suse.cz> --- fs/btrfs/extent-tree.c | 6 ------ 1 files changed, 0 insertions(+), 6 deletions(-)