| Message ID | 4DBC4D48.5070805@landley.net (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Eric Van Hensbergen |
| Headers | show |
not intentional, just comment drift with renames. Thanks for the patch.
-eric
On Sat, Apr 30, 2011 at 12:56 PM, Rob Landley <rob@landley.net> wrote:
> As on Jeopardy, my question is in the form of a patch: Does this have
> some special meaning, or is it an accident? (I looked at other
> filesystems but they didn't bother having doc entries for their
> init/exit function that I could find.)
>
> From: Rob Landley <rob@landley.net>
>
> Change linuxdoc names to match functions.
>
> Signed-off-by: Rob Landley <rob@landley.net>
> ---
>
> net/9p/mod.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net/9p/mod.c b/net/9p/mod.c
> index cf8a412..72c3982 100644
> --- a/net/9p/mod.c
> +++ b/net/9p/mod.c
> @@ -139,7 +139,7 @@ void v9fs_put_trans(struct p9_trans_module *m)
> }
>
> /**
> - * v9fs_init - Initialize module
> + * init_p9 - Initialize module
> *
> */
> static int __init init_p9(void)
> @@ -154,7 +154,7 @@ static int __init init_p9(void)
> }
>
> /**
> - * v9fs_init - shutdown module
> + * exit_p9 - shutdown module
> *
> */
>
>
> ------------------------------------------------------------------------------
> WhatsUp Gold - Download Free Network Management Software
> The most intuitive, comprehensive, and cost-effective network
> management toolset available today. Delivers lowest initial
> acquisition cost and overall TCO of any competing solution.
> http://p.sf.net/sfu/whatsupgold-sd
> _______________________________________________
> V9fs-developer mailing list
> V9fs-developer@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/v9fs-developer
>
------------------------------------------------------------------------------
WhatsUp Gold - Download Free Network Management Software
The most intuitive, comprehensive, and cost-effective network
management toolset available today. Delivers lowest initial
acquisition cost and overall TCO of any competing solution.
http://p.sf.net/sfu/whatsupgold-sd
The transports are modules, but trans_fd.c isn't selectable (no Kconfig symbol, and net/9p/Makefile always links it in when NET_9P is selected). This is actually three transports: TCP/IPv4, AF_UNIX sockets, and filehandles. Is this intentional, or is it a historical artifact? (p9 with virtio is requiring you to enable the TCP/IP networking layer. p9 with filehandle could presumably be getting data from a serial port...) Also, I can go into menuconfig and disable unix domain sockets and TCP/IP networking. Strangely, 9p trans_fd still builds fine. Curious, Rob ------------------------------------------------------------------------------ WhatsUp Gold - Download Free Network Management Software The most intuitive, comprehensive, and cost-effective network management toolset available today. Delivers lowest initial acquisition cost and overall TCO of any competing solution. http://p.sf.net/sfu/whatsupgold-sd
On Sat, Apr 30, 2011 at 7:38 PM, Rob Landley <rob@landley.net> wrote: > The transports are modules, but trans_fd.c isn't selectable (no Kconfig > symbol, and net/9p/Makefile always links it in when NET_9P is selected). > > This is actually three transports: TCP/IPv4, AF_UNIX sockets, and > filehandles. > > Is this intentional, or is it a historical artifact? It predates virtio, everyone kept wonder why they couldn't mount anything and it usually was because they hadn't included the tcp module. > (p9 with virtio is > requiring you to enable the TCP/IP networking layer. p9 with filehandle > could presumably be getting data from a serial port...) > > Also, I can go into menuconfig and disable unix domain sockets and > TCP/IP networking. Strangely, 9p trans_fd still builds fine. > That probably should be fixed. -eric ------------------------------------------------------------------------------ WhatsUp Gold - Download Free Network Management Software The most intuitive, comprehensive, and cost-effective network management toolset available today. Delivers lowest initial acquisition cost and overall TCO of any competing solution. http://p.sf.net/sfu/whatsupgold-sd
diff --git a/net/9p/mod.c b/net/9p/mod.c index cf8a412..72c3982 100644 --- a/net/9p/mod.c +++ b/net/9p/mod.c @@ -139,7 +139,7 @@ void v9fs_put_trans(struct p9_trans_module *m) } /** - * v9fs_init - Initialize module + * init_p9 - Initialize module * */ static int __init init_p9(void) @@ -154,7 +154,7 @@ static int __init init_p9(void) } /** - * v9fs_init - shutdown module + * exit_p9 - shutdown module * */