diff mbox

[2/2] phy: berlin-usb: don't set device's driver_data

Message ID 1449237421-5552-3-git-send-email-jszhang@marvell.com (mailing list archive)
State New, archived
Headers show

Commit Message

Jisheng Zhang Dec. 4, 2015, 1:57 p.m. UTC
After commit 739ae3452d0e ("phy: berlin-usb: Set drvdata for phy and
use it"), we get the address of priv by phy_get_drvdata(), so there's
no need to set device's driver_data any more. This patch removes the
call of platform_set_drvdata().

Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
---
 drivers/phy/phy-berlin-usb.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Antoine Tenart Dec. 4, 2015, 9:09 p.m. UTC | #1
On Fri, Dec 04, 2015 at 09:57:01PM +0800, Jisheng Zhang wrote:
> After commit 739ae3452d0e ("phy: berlin-usb: Set drvdata for phy and
> use it"), we get the address of priv by phy_get_drvdata(), so there's
> no need to set device's driver_data any more. This patch removes the
> call of platform_set_drvdata().
> 
> Signed-off-by: Jisheng Zhang <jszhang@marvell.com>

Acked-by: Antoine Tenart <antoine.tenart@free-electrons.com>

> ---
>  drivers/phy/phy-berlin-usb.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/phy/phy-berlin-usb.c b/drivers/phy/phy-berlin-usb.c
> index 7bbb473..2017751 100644
> --- a/drivers/phy/phy-berlin-usb.c
> +++ b/drivers/phy/phy-berlin-usb.c
> @@ -193,7 +193,6 @@ static int phy_berlin_usb_probe(struct platform_device *pdev)
>  		return PTR_ERR(phy);
>  	}
>  
> -	platform_set_drvdata(pdev, priv);
>  	phy_set_drvdata(phy, priv);
>  
>  	phy_provider =
> -- 
> 2.6.2
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
diff mbox

Patch

diff --git a/drivers/phy/phy-berlin-usb.c b/drivers/phy/phy-berlin-usb.c
index 7bbb473..2017751 100644
--- a/drivers/phy/phy-berlin-usb.c
+++ b/drivers/phy/phy-berlin-usb.c
@@ -193,7 +193,6 @@  static int phy_berlin_usb_probe(struct platform_device *pdev)
 		return PTR_ERR(phy);
 	}
 
-	platform_set_drvdata(pdev, priv);
 	phy_set_drvdata(phy, priv);
 
 	phy_provider =