diff mbox

[3/3] arm64: dts: r8a7795: Add pmu device nodes

Message ID 1449236333-4410-3-git-send-email-dirk.behme@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Dirk Behme Dec. 4, 2015, 1:38 p.m. UTC
From: Yoshifumi Hosoya <yoshifumi.hosoya.wj@renesas.com>

Enabling the performance monitor unit on r8a7795.

Signed-off-by: Masaru Nagai <masaru.nagai.vx@renesas.com>
Signed-off-by: Yoshifumi Hosoya <yoshifumi.hosoya.wj@renesas.com>
Sigend-off-by: Dirk Behme <dirk.behme@gmail.com>
---
Note: This patch picked from

https://git.kernel.org/cgit/linux/kernel/git/horms/renesas-bsp.git/log/?h=v4.2/rcar-3.0.x

and rebased against

https://git.kernel.org/cgit/linux/kernel/git/geert/renesas-drivers.git/log/?h=topic/gen3-latest renesas-drivers-2015-12-01-v4.4-rc3

 arch/arm64/boot/dts/renesas/r8a7795.dtsi | 12 ++++++++++++
 1 file changed, 12 insertions(+)

Comments

Simon Horman Dec. 11, 2015, 11:07 p.m. UTC | #1
On Fri, Dec 04, 2015 at 02:38:53PM +0100, Dirk Behme wrote:
> From: Yoshifumi Hosoya <yoshifumi.hosoya.wj@renesas.com>
> 
> Enabling the performance monitor unit on r8a7795.
> 
> Signed-off-by: Masaru Nagai <masaru.nagai.vx@renesas.com>
> Signed-off-by: Yoshifumi Hosoya <yoshifumi.hosoya.wj@renesas.com>
> Sigend-off-by: Dirk Behme <dirk.behme@gmail.com>

I took the liberty of correcting the spelling of "Signed" when
queuing up this patch for v4.5.
Sudeep Holla Dec. 14, 2015, 2:36 p.m. UTC | #2
On 04/12/15 13:38, Dirk Behme wrote:
> From: Yoshifumi Hosoya <yoshifumi.hosoya.wj@renesas.com>
>
> Enabling the performance monitor unit on r8a7795.
>
> Signed-off-by: Masaru Nagai <masaru.nagai.vx@renesas.com>
> Signed-off-by: Yoshifumi Hosoya <yoshifumi.hosoya.wj@renesas.com>
> Sigend-off-by: Dirk Behme <dirk.behme@gmail.com>
> ---
> Note: This patch picked from
>
> https://git.kernel.org/cgit/linux/kernel/git/horms/renesas-bsp.git/log/?h=v4.2/rcar-3.0.x
>
> and rebased against
>
> https://git.kernel.org/cgit/linux/kernel/git/geert/renesas-drivers.git/log/?h=topic/gen3-latest renesas-drivers-2015-12-01-v4.4-rc3
>
>   arch/arm64/boot/dts/renesas/r8a7795.dtsi | 12 ++++++++++++
>   1 file changed, 12 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> index 946a5bb..8113b71 100644
> --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> @@ -247,6 +247,18 @@
>   			power-domains = <&cpg>;
>   		};
>
> +		pmu {
> +			compatible = "arm,armv8-pmuv3";

You can add more specific compatible "arm,cortex-a57-pmu" if it's Cortex
A57.
Geert Uytterhoeven Dec. 15, 2015, 8:33 a.m. UTC | #3
On Mon, Dec 14, 2015 at 3:36 PM, Sudeep Holla <sudeep.holla@arm.com> wrote:
> On 04/12/15 13:38, Dirk Behme wrote:
>>
>> From: Yoshifumi Hosoya <yoshifumi.hosoya.wj@renesas.com>
>>
>> Enabling the performance monitor unit on r8a7795.
>>
>> Signed-off-by: Masaru Nagai <masaru.nagai.vx@renesas.com>
>> Signed-off-by: Yoshifumi Hosoya <yoshifumi.hosoya.wj@renesas.com>
>> Sigend-off-by: Dirk Behme <dirk.behme@gmail.com>
>> ---
>> Note: This patch picked from
>>
>>
>> https://git.kernel.org/cgit/linux/kernel/git/horms/renesas-bsp.git/log/?h=v4.2/rcar-3.0.x
>>
>> and rebased against
>>
>>
>> https://git.kernel.org/cgit/linux/kernel/git/geert/renesas-drivers.git/log/?h=topic/gen3-latest
>> renesas-drivers-2015-12-01-v4.4-rc3
>>
>>   arch/arm64/boot/dts/renesas/r8a7795.dtsi | 12 ++++++++++++
>>   1 file changed, 12 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>> b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>> index 946a5bb..8113b71 100644
>> --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>> +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>> @@ -247,6 +247,18 @@
>>                         power-domains = <&cpg>;
>>                 };
>>
>> +               pmu {
>> +                       compatible = "arm,armv8-pmuv3";
>
>
> You can add more specific compatible "arm,cortex-a57-pmu" if it's Cortex
> A57.

Except that one is not documented.

Oh, it is. Someone mistyped the commas. Patch sent.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Sudeep Holla Dec. 15, 2015, 9:50 a.m. UTC | #4
On 15/12/15 08:33, Geert Uytterhoeven wrote:
> On Mon, Dec 14, 2015 at 3:36 PM, Sudeep Holla <sudeep.holla@arm.com> wrote:
>> On 04/12/15 13:38, Dirk Behme wrote:
>>>
>>> From: Yoshifumi Hosoya <yoshifumi.hosoya.wj@renesas.com>
>>>
>>> Enabling the performance monitor unit on r8a7795.
>>>
>>> Signed-off-by: Masaru Nagai <masaru.nagai.vx@renesas.com>
>>> Signed-off-by: Yoshifumi Hosoya <yoshifumi.hosoya.wj@renesas.com>
>>> Sigend-off-by: Dirk Behme <dirk.behme@gmail.com>
>>> ---
>>> Note: This patch picked from
>>>
>>>
>>> https://git.kernel.org/cgit/linux/kernel/git/horms/renesas-bsp.git/log/?h=v4.2/rcar-3.0.x
>>>
>>> and rebased against
>>>
>>>
>>> https://git.kernel.org/cgit/linux/kernel/git/geert/renesas-drivers.git/log/?h=topic/gen3-latest
>>> renesas-drivers-2015-12-01-v4.4-rc3
>>>
>>>    arch/arm64/boot/dts/renesas/r8a7795.dtsi | 12 ++++++++++++
>>>    1 file changed, 12 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>>> b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>>> index 946a5bb..8113b71 100644
>>> --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>>> +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>>> @@ -247,6 +247,18 @@
>>>                          power-domains = <&cpg>;
>>>                  };
>>>
>>> +               pmu {
>>> +                       compatible = "arm,armv8-pmuv3";
>>
>>
>> You can add more specific compatible "arm,cortex-a57-pmu" if it's Cortex
>> A57.
>
> Except that one is not documented.
>
> Oh, it is. Someone mistyped the commas. Patch sent.
>

Ah right, nice catch. Thanks for the patch.
diff mbox

Patch

diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
index 946a5bb..8113b71 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
@@ -247,6 +247,18 @@ 
 			power-domains = <&cpg>;
 		};
 
+		pmu {
+			compatible = "arm,armv8-pmuv3";
+			interrupts = <GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 74 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 75 IRQ_TYPE_LEVEL_HIGH>;
+			interrupt-affinity = <&a57_0>,
+					     <&a57_1>,
+					     <&a57_2>,
+					     <&a57_3>;
+		};
+
 		timer {
 			compatible = "arm,armv8-timer";
 			interrupts = <GIC_PPI 13