| Message ID | 1304443957-15667-2-git-send-email-alexdeucher@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
BenH doesn't want this for macs and that was mainly the use for this patch, so it (2/2) can be ignored. Alex On Tue, May 3, 2011 at 1:32 PM, Alex Deucher <alexdeucher@gmail.com> wrote: > I'm not sure this is necessary. In most cases the driver > will add the hwmon device itself based on information from the > vbios tables. However, there are some boards without a proper > vbios entry for the the hwmon chips and non-x86 (Mac/Sun) cards do > not have a standard vbios. This allows the hwmon drivers to > detect devices on the radeon i2c buses. > > Signed-off-by: Alex Deucher <alexdeucher@gmail.com> > Cc: Jean Delvare <khali@linux-fr.org> > --- > drivers/gpu/drm/radeon/radeon_i2c.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/gpu/drm/radeon/radeon_i2c.c b/drivers/gpu/drm/radeon/radeon_i2c.c > index 781196d..65d8744 100644 > --- a/drivers/gpu/drm/radeon/radeon_i2c.c > +++ b/drivers/gpu/drm/radeon/radeon_i2c.c > @@ -888,7 +888,7 @@ struct radeon_i2c_chan *radeon_i2c_create(struct drm_device *dev, > > i2c->rec = *rec; > i2c->adapter.owner = THIS_MODULE; > - i2c->adapter.class = I2C_CLASS_DDC; > + i2c->adapter.class = I2C_CLASS_DDC | I2C_CLASS_HWMON; > i2c->dev = dev; > i2c_set_adapdata(&i2c->adapter, i2c); > if (rec->mm_i2c || > -- > 1.7.1.1 > >
diff --git a/drivers/gpu/drm/radeon/radeon_i2c.c b/drivers/gpu/drm/radeon/radeon_i2c.c index 781196d..65d8744 100644 --- a/drivers/gpu/drm/radeon/radeon_i2c.c +++ b/drivers/gpu/drm/radeon/radeon_i2c.c @@ -888,7 +888,7 @@ struct radeon_i2c_chan *radeon_i2c_create(struct drm_device *dev, i2c->rec = *rec; i2c->adapter.owner = THIS_MODULE; - i2c->adapter.class = I2C_CLASS_DDC; + i2c->adapter.class = I2C_CLASS_DDC | I2C_CLASS_HWMON; i2c->dev = dev; i2c_set_adapdata(&i2c->adapter, i2c); if (rec->mm_i2c ||
I'm not sure this is necessary. In most cases the driver will add the hwmon device itself based on information from the vbios tables. However, there are some boards without a proper vbios entry for the the hwmon chips and non-x86 (Mac/Sun) cards do not have a standard vbios. This allows the hwmon drivers to detect devices on the radeon i2c buses. Signed-off-by: Alex Deucher <alexdeucher@gmail.com> Cc: Jean Delvare <khali@linux-fr.org> --- drivers/gpu/drm/radeon/radeon_i2c.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)