| Message ID | 1450190172-1161-1-git-send-email-jszhang@marvell.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tuesday 15 December 2015 22:36:12 Jisheng Zhang wrote: > - compatible = "arm,armv8-pmuv3"; > + compatible = "arm,cortex-a53-pmu"; > Should this list both? Arnd
Dear Arnd, On Tue, 15 Dec 2015 15:43:53 +0100 Arnd Bergmann wrote: > On Tuesday 15 December 2015 22:36:12 Jisheng Zhang wrote: > > - compatible = "arm,armv8-pmuv3"; > > + compatible = "arm,cortex-a53-pmu"; > > > > Should this list both? IMHO, we don't need to list both. The pmu binding document also says: "compatible : should be one of ...." Dear Mark, Could you please give suggestions? Thanks, Jisheng
On Tue, Dec 15, 2015 at 10:47:09PM +0800, Jisheng Zhang wrote: > Dear Arnd, > > On Tue, 15 Dec 2015 15:43:53 +0100 Arnd Bergmann wrote: > > > On Tuesday 15 December 2015 22:36:12 Jisheng Zhang wrote: > > > - compatible = "arm,armv8-pmuv3"; > > > + compatible = "arm,cortex-a53-pmu"; > > > > > > > Should this list both? > > IMHO, we don't need to list both. The pmu binding document also says: > "compatible : should be one of ...." > > Dear Mark, > > Could you please give suggestions? That should probably reads as "should contain at least one of". It's probably best to keep "arm,armv8-pmuv3" as a fallback in the compatible list. Thanks, Mark.
diff --git a/arch/arm64/boot/dts/marvell/berlin4ct.dtsi b/arch/arm64/boot/dts/marvell/berlin4ct.dtsi index 099ad93..e48d424 100644 --- a/arch/arm64/boot/dts/marvell/berlin4ct.dtsi +++ b/arch/arm64/boot/dts/marvell/berlin4ct.dtsi @@ -115,7 +115,7 @@ }; pmu { - compatible = "arm,armv8-pmuv3"; + compatible = "arm,cortex-a53-pmu"; interrupts = <GIC_SPI 23 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 24 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>,
Commit ac82d1277215 ("arm64: perf: add Cortex-A53 support") adds the cortex A53 PMU support, thus instead of using the generic armv8-pmuv3 compatibility use the more specific Cortex A53 compatibility. Signed-off-by: Jisheng Zhang <jszhang@marvell.com> --- arch/arm64/boot/dts/marvell/berlin4ct.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)