| Message ID | 1450238356-36319-3-git-send-email-dawei.chien@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Dec 16, 2015 at 11:59 AM, Dawei Chien <dawei.chien@mediatek.com> wrote: > > This adds thermal zone node to Mediatek MT8173 dtsi file. > > Signed-off-by: Dawei Chien <dawei.chien@mediatek.com> > --- > This patch is base on patchset: > https://lkml.org/lkml/2015/11/30/239 > --- > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 43 ++++++++++++++++++++++++++++++ > 1 file changed, 43 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > index fda805d..4114cee 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > @@ -188,6 +188,49 @@ > clock-output-names = "cpum_ck"; > }; > > + thermal-zones { > + cpu_thermal: cpu_thermal { > + polling-delay-passive = <1000>; /* milliseconds */ > + polling-delay = <1000>; /* milliseconds */ > + > + thermal-sensors = <&thermal 0>; This should be <&thermal> with the MTK temp sensor node in https://lkml.org/lkml/2015/11/30/239 patch series. -Dan
On Wed, 2015-12-16 at 16:34 +0800, Daniel Kurtz wrote: > On Wed, Dec 16, 2015 at 11:59 AM, Dawei Chien <dawei.chien@mediatek.com> wrote: > > > > This adds thermal zone node to Mediatek MT8173 dtsi file. > > > > Signed-off-by: Dawei Chien <dawei.chien@mediatek.com> > > --- > > This patch is base on patchset: > > https://lkml.org/lkml/2015/11/30/239 > > --- > > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 43 ++++++++++++++++++++++++++++++ > > 1 file changed, 43 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > > index fda805d..4114cee 100644 > > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi > > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > > @@ -188,6 +188,49 @@ > > clock-output-names = "cpum_ck"; > > }; > > > > + thermal-zones { > > + cpu_thermal: cpu_thermal { > > + polling-delay-passive = <1000>; /* milliseconds */ > > + polling-delay = <1000>; /* milliseconds */ > > + > > + thermal-sensors = <&thermal 0>; > > This should be <&thermal> with the MTK temp sensor node in > https://lkml.org/lkml/2015/11/30/239 patch series. > > -Dan Hi Dan, Sascha's thermal driver V12 only register sensor id as 0, so we need to register sensor id as 0 to device tree as well. Either <&thermal 0> or <&thermal>, sensor id should be 0 for two cases. I try this two case, function all work fine for two cases. May I have any misunderstand? Please kindly give your comment. I will re-send this patch again once you tell me the reason, thank you. BR, Dawei
On Wed, Dec 16, 2015 at 6:09 PM, dawei chien <dawei.chien@mediatek.com> wrote: > On Wed, 2015-12-16 at 16:34 +0800, Daniel Kurtz wrote: >> On Wed, Dec 16, 2015 at 11:59 AM, Dawei Chien <dawei.chien@mediatek.com> wrote: >> > >> > This adds thermal zone node to Mediatek MT8173 dtsi file. >> > >> > Signed-off-by: Dawei Chien <dawei.chien@mediatek.com> >> > --- >> > This patch is base on patchset: >> > https://lkml.org/lkml/2015/11/30/239 >> > --- >> > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 43 ++++++++++++++++++++++++++++++ >> > 1 file changed, 43 insertions(+) >> > >> > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi >> > index fda805d..4114cee 100644 >> > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi >> > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi >> > @@ -188,6 +188,49 @@ >> > clock-output-names = "cpum_ck"; >> > }; >> > >> > + thermal-zones { >> > + cpu_thermal: cpu_thermal { >> > + polling-delay-passive = <1000>; /* milliseconds */ >> > + polling-delay = <1000>; /* milliseconds */ >> > + >> > + thermal-sensors = <&thermal 0>; >> >> This should be <&thermal> with the MTK temp sensor node in >> https://lkml.org/lkml/2015/11/30/239 patch series. >> >> -Dan > > Hi Dan, > Sascha's thermal driver V12 only register sensor id as 0, so we need to > register sensor id as 0 to device tree as well. > > Either <&thermal 0> or <&thermal>, sensor id should be 0 for two cases. > I try this two case, function all work fine for two cases. May I have > any misunderstand? Please kindly give your comment. > I will re-send this patch again once you tell me the reason, thank you. In the new patchset, Sascha changed it to: #thermal-sensor-cells = <0>; Which means the <&thermal> phandle no longer has any arguments. Thanks! -Dan
On Wed, 2015-12-16 at 19:22 +0800, Daniel Kurtz wrote: > On Wed, Dec 16, 2015 at 6:09 PM, dawei chien <dawei.chien@mediatek.com> wrote: > > On Wed, 2015-12-16 at 16:34 +0800, Daniel Kurtz wrote: > >> On Wed, Dec 16, 2015 at 11:59 AM, Dawei Chien <dawei.chien@mediatek.com> wrote: > >> > > >> > This adds thermal zone node to Mediatek MT8173 dtsi file. > >> > > >> > Signed-off-by: Dawei Chien <dawei.chien@mediatek.com> > >> > --- > >> > This patch is base on patchset: > >> > https://lkml.org/lkml/2015/11/30/239 > >> > --- > >> > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 43 ++++++++++++++++++++++++++++++ > >> > 1 file changed, 43 insertions(+) > >> > > >> > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > >> > index fda805d..4114cee 100644 > >> > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi > >> > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > >> > @@ -188,6 +188,49 @@ > >> > clock-output-names = "cpum_ck"; > >> > }; > >> > > >> > + thermal-zones { > >> > + cpu_thermal: cpu_thermal { > >> > + polling-delay-passive = <1000>; /* milliseconds */ > >> > + polling-delay = <1000>; /* milliseconds */ > >> > + > >> > + thermal-sensors = <&thermal 0>; > >> > >> This should be <&thermal> with the MTK temp sensor node in > >> https://lkml.org/lkml/2015/11/30/239 patch series. > >> > >> -Dan > > > > Hi Dan, > > Sascha's thermal driver V12 only register sensor id as 0, so we need to > > register sensor id as 0 to device tree as well. > > > > Either <&thermal 0> or <&thermal>, sensor id should be 0 for two cases. > > I try this two case, function all work fine for two cases. May I have > > any misunderstand? Please kindly give your comment. > > I will re-send this patch again once you tell me the reason, thank you. > > In the new patchset, Sascha changed it to: > #thermal-sensor-cells = <0>; > > Which means the <&thermal> phandle no longer has any arguments. > > Thanks! > -Dan Hi Dan, Thank you for your comment. Yes, I don't need to add sensor id since new driver add thermal-sensor-cell as 0. (Even I checked function OK to this patch with new patchset) I will re-send this patch soon, thank you. BR, Dawei
diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi index fda805d..4114cee 100644 --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi @@ -188,6 +188,49 @@ clock-output-names = "cpum_ck"; }; + thermal-zones { + cpu_thermal: cpu_thermal { + polling-delay-passive = <1000>; /* milliseconds */ + polling-delay = <1000>; /* milliseconds */ + + thermal-sensors = <&thermal 0>; + sustainable-power = <1500>; /* milliwatts */ + + trips { + threshold: trip-point@0 { + temperature = <68000>; + hysteresis = <2000>; + type = "passive"; + }; + + target: trip-point@1 { + temperature = <85000>; + hysteresis = <2000>; + type = "passive"; + }; + + cpu_crit: cpu_crit@0 { + temperature = <115000>; + hysteresis = <2000>; + type = "critical"; + }; + }; + + cooling-maps { + map@0 { + trip = <&target>; + cooling-device = <&cpu0 0 0>; + contribution = <1024>; + }; + map@1 { + trip = <&target>; + cooling-device = <&cpu2 0 0>; + contribution = <2048>; + }; + }; + }; + }; + timer { compatible = "arm,armv8-timer"; interrupt-parent = <&gic>;
This adds thermal zone node to Mediatek MT8173 dtsi file. Signed-off-by: Dawei Chien <dawei.chien@mediatek.com> --- This patch is base on patchset: https://lkml.org/lkml/2015/11/30/239 --- arch/arm64/boot/dts/mediatek/mt8173.dtsi | 43 ++++++++++++++++++++++++++++++ 1 file changed, 43 insertions(+)