| Message ID | 1450280177-4460-9-git-send-email-anton.wuerfel@fau.de (mailing list archive) |
|---|---|
| State | Awaiting Upstream |
| Headers | show |
On Wed, 2015-12-16 at 16:36 +0100, Anton Wuerfel wrote: > This patch fixes a checkpatch warning caused by missing parentheses > in the definition of a macro. > > Signed-off-by: Anton Würfel <anton.wuerfel@fau.de> > Signed-off-by: Phillip Raffeck <phillip.raffeck@fau.de> > CC: linux-kernel@i4.cs.fau.de > --- > drivers/tty/serial/8250/8250_core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/8250/8250_core.c > b/drivers/tty/serial/8250/8250_core.c > index 67147b2..3c29530 100644 > --- a/drivers/tty/serial/8250/8250_core.c > +++ b/drivers/tty/serial/8250/8250_core.c > @@ -686,7 +686,7 @@ static int __init univ8250_console_init(void) > } > console_initcall(univ8250_console_init); > > -#define SERIAL8250_CONSOLE &univ8250_console > +#define SERIAL8250_CONSOLE (&univ8250_console) What about the rest of the drivers under drivers/tty/serial? What do you propose to do with, for example, the following drivers/tty/serial/cpm_uart/cpm_uart_core.c:1392:#define CPM_UART_CONSOLE &cpm_scc_uart_console drivers/tty/serial/cpm_uart/cpm_uart_core.c:1394:#define CPM_UART_CONSOLE NULL > #else > #define SERIAL8250_CONSOLE NULL > #endif
Hello Andy, > What about the rest of the drivers under drivers/tty/serial? > > What do you propose to do with, for example, the following > > drivers/tty/serial/cpm_uart/cpm_uart_core.c:1392:#define > CPM_UART_CONSOLE &cpm_scc_uart_console > drivers/tty/serial/cpm_uart/cpm_uart_core.c:1394:#define > CPM_UART_CONSOLE NULL > >> #else >> #define SERIAL8250_CONSOLE NULL >> #endif > thanks for your reply. Phillip and me are newcomers to kernel development, so we tried to touch as few files as possible and gain some experience in creating patches and communication on LKML. We will consider sending further patches in the future. Regards, Phillip Raffeck Anton Wuerfel > -- > Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Intel Finland Oy > > -- To unsubscribe from this list: send the line "unsubscribe linux-parisc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, 2015-12-18 at 12:36 +0100, anton.wuerfel@fau.de wrote: > Hello Andy, > > > What about the rest of the drivers under drivers/tty/serial? > > > > What do you propose to do with, for example, the following > > > > drivers/tty/serial/cpm_uart/cpm_uart_core.c:1392:#define > > CPM_UART_CONSOLE &cpm_scc_uart_console > > drivers/tty/serial/cpm_uart/cpm_uart_core.c:1394:#define > > CPM_UART_CONSOLE NULL > > > > > #else > > > #define SERIAL8250_CONSOLE NULL > > > #endif > > > > thanks for your reply. Phillip and me are newcomers to kernel > development, Welcome! > so we tried to touch as few files as possible and gain some > experience in > creating patches and communication on LKML. We will consider sending > further patches in the future. I see. I don't know which way is preferable for such patches, I think Greg usually likes when one patch touches one driver. So, this one is okay, and other drivers can be fixed later. > Regards, > Phillip Raffeck > Anton Wuerfel > > > -- > > Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > Intel Finland Oy > > > > > >
diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c index 67147b2..3c29530 100644 --- a/drivers/tty/serial/8250/8250_core.c +++ b/drivers/tty/serial/8250/8250_core.c @@ -686,7 +686,7 @@ static int __init univ8250_console_init(void) } console_initcall(univ8250_console_init); -#define SERIAL8250_CONSOLE &univ8250_console +#define SERIAL8250_CONSOLE (&univ8250_console) #else #define SERIAL8250_CONSOLE NULL #endif