diff mbox

[16/17] lpfc: Use kzalloc instead of kmalloc

Message ID 5671efc7.97bycJ6w84wBFCRH%james.smart@avagotech.com (mailing list archive)
State Accepted, archived
Headers show

Commit Message

James Smart Dec. 16, 2015, 11:12 p.m. UTC 
From:	Punit Vara <punitvara@gmail.com>

This patch is to the lpfc_els.c which resolves following warning
reported by coccicheck:

WARNING: kzalloc should be used for rdp_context, instead of
kmalloc/memset

Signed-off-by: Punit Vara <punitvara@gmail.com>
Signed-off-by: James Smart <james.smart@avagotech.com>
---
 drivers/scsi/lpfc/lpfc_els.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Matthew R. Ochs Dec. 17, 2015, 12:04 a.m. UTC | #1 
Reviewed-by: Matthew R. Ochs <mrochs@linux.vnet.ibm.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Hannes Reinecke Dec. 17, 2015, 8:39 a.m. UTC | #2 
On 12/17/2015 12:12 AM, James Smart wrote:
>
> From:	Punit Vara <punitvara@gmail.com>
>
> This patch is to the lpfc_els.c which resolves following warning
> reported by coccicheck:
>
> WARNING: kzalloc should be used for rdp_context, instead of
> kmalloc/memset
>
> Signed-off-by: Punit Vara <punitvara@gmail.com>
> Signed-off-by: James Smart <james.smart@avagotech.com>
> ---
>   drivers/scsi/lpfc/lpfc_els.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c
> index 273a1db..7f5abb8 100644
> --- a/drivers/scsi/lpfc/lpfc_els.c
> +++ b/drivers/scsi/lpfc/lpfc_els.c
> @@ -5016,13 +5016,12 @@ lpfc_els_rcv_rdp(struct lpfc_vport *vport, struct lpfc_iocbq *cmdiocb,
>   	if (RDP_NPORT_ID_SIZE !=
>   			be32_to_cpu(rdp_req->nport_id_desc.length))
>   		goto rjt_logerr;
> -	rdp_context = kmalloc(sizeof(struct lpfc_rdp_context), GFP_KERNEL);
> +	rdp_context = kzalloc(sizeof(struct lpfc_rdp_context), GFP_KERNEL);
>   	if (!rdp_context) {
>   		rjt_err = LSRJT_UNABLE_TPC;
>   		goto error;
>   	}
>
> -	memset(rdp_context, 0, sizeof(struct lpfc_rdp_context));
>   	cmd = &cmdiocb->iocb;
>   	rdp_context->ndlp = lpfc_nlp_get(ndlp);
>   	rdp_context->ox_id = cmd->unsli3.rcvsli3.ox_id;
>
Reviewed-by: Hannes Reinecke <hare@suse.com>

Cheers,

Hannes
Sebastian Herbszt Dec. 17, 2015, 10:58 p.m. UTC | #3 
James Smart wrote:
> From:	Punit Vara <punitvara@gmail.com>
> 
> This patch is to the lpfc_els.c which resolves following warning
> reported by coccicheck:
> 
> WARNING: kzalloc should be used for rdp_context, instead of
> kmalloc/memset
> 
> Signed-off-by: Punit Vara <punitvara@gmail.com>
> Signed-off-by: James Smart <james.smart@avagotech.com>

You missed the two already available positive reviews [1][2].

Anyway,

Reviewed-by: Sebastian Herbszt <herbszt@gmx.de>

[1] http://marc.info/?l=linux-scsi&m=144574360607327&w=2
[2] http://marc.info/?l=linux-scsi&m=144823385015994&w=2
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c
index 273a1db..7f5abb8 100644
--- a/drivers/scsi/lpfc/lpfc_els.c
+++ b/drivers/scsi/lpfc/lpfc_els.c
@@ -5016,13 +5016,12 @@  lpfc_els_rcv_rdp(struct lpfc_vport *vport, struct lpfc_iocbq *cmdiocb,
 	if (RDP_NPORT_ID_SIZE !=
 			be32_to_cpu(rdp_req->nport_id_desc.length))
 		goto rjt_logerr;
-	rdp_context = kmalloc(sizeof(struct lpfc_rdp_context), GFP_KERNEL);
+	rdp_context = kzalloc(sizeof(struct lpfc_rdp_context), GFP_KERNEL);
 	if (!rdp_context) {
 		rjt_err = LSRJT_UNABLE_TPC;
 		goto error;
 	}
 
-	memset(rdp_context, 0, sizeof(struct lpfc_rdp_context));
 	cmd = &cmdiocb->iocb;
 	rdp_context->ndlp = lpfc_nlp_get(ndlp);
 	rdp_context->ox_id = cmd->unsli3.rcvsli3.ox_id;