[RFC,2/2] x86: add Atheros ar1520 platform support for mrst

Commit Message

Luis Rodriguez May 6, 2011, 10:09 p.m. UTC

From: Allen Kao <[e-mail]>

This adds platform driver support for Atheros ar1520 GPS device
on the Intel Moorestown Low Power Intel Architecture (LPIA) based
Moblin Internet Device (MID) platform.

Cc: Roman Gezikov <[e-mail]>
Cc: Joonas Viskari <[e-mail]>
Cc: Andrew Morton <[e-mail]>
Cc: Thomas Gleixner <[e-mail]>
Cc: "H. Peter Anvin" <[e-mail]>
Cc: Ingo Molnar <[e-mail]>
Cc: [e-mail]
Signed-off-by: Allen Kao <[e-mail]>
Signed-off-by: Luis R. Rodriguez <[e-mail]>
---
 arch/x86/platform/mrst/mrst.c |   18 ++++++++++++++++++
 1 files changed, 18 insertions(+), 0 deletions(-)

Comments

Alan Cox May 6, 2011, 10:28 p.m. UTC | #1

On Fri, 6 May 2011 15:09:40 -0700
"Luis R. Rodriguez" <[e-mail]> wrote:

> From: Allen Kao <[e-mail]>
> 
> This adds platform driver support for Atheros ar1520 GPS device
> on the Intel Moorestown Low Power Intel Architecture (LPIA) based
> Moblin Internet Device (MID) platform.

NAK - for the same reasons as before, and the same NAK you already got on
the other list.

No open user space or sufficient API docs to make use of the kernel
driver and write your own = not a candidate for submission. Same for the
3D graphics on that platform.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to [e-mail]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Luis Rodriguez May 6, 2011, 11:27 p.m. UTC | #2

On Fri, May 6, 2011 at 3:28 PM, Alan Cox <[e-mail]> wrote:
> On Fri, 6 May 2011 15:09:40 -0700
> "Luis R. Rodriguez" <[e-mail]> wrote:
>
>> From: Allen Kao <[e-mail]>
>>
>> This adds platform driver support for Atheros ar1520 GPS device
>> on the Intel Moorestown Low Power Intel Architecture (LPIA) based
>> Moblin Internet Device (MID) platform.
>
> NAK - for the same reasons as before, and the same NAK you already got on
> the other list.
>
> No open user space or sufficient API docs to make use of the kernel
> driver and write your own = not a candidate for submission. Same for the
> 3D graphics on that platform.

I was under the impression an open userspace app was going to be
provided.... I'll check with the team.

 Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to [e-mail]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/arch/x86/platform/mrst/mrst.c b/arch/x86/platform/mrst/mrst.c
index 7000e74..e02d92f 100644
--- a/arch/x86/platform/mrst/mrst.c
+++ b/arch/x86/platform/mrst/mrst.c
@@ -19,6 +19,7 @@ 
 #include <linux/spi/spi.h>
 #include <linux/i2c.h>
 #include <linux/i2c/pca953x.h>
+#include <linux/ar1520.h>
 #include <linux/gpio_keys.h>
 #include <linux/input.h>
 #include <linux/platform_device.h>
@@ -475,6 +476,22 @@  static void __init *lis331dl_platform_data(void *info)
 	return &intr2nd_pdata;
 }
 
+static void __init *ar1520_gps_platform_data(void *info)
+{
+	static struct ar1520_platform_data ar1520_i2c_pdata;
+	int rts = get_gpio_by_name("gps_rts");
+	int wakeup = get_gpio_by_name("gps_wakeup");
+	int reset = get_gpio_by_name("gps_reset");
+
+	if (rts == -1 || wakeup == -1 || reset == -1)
+		return NULL;
+	ar1520_i2c_pdata.gps_gpio_rts = rts;
+	ar1520_i2c_pdata.gps_gpio_wakeup = wakeup;
+	ar1520_i2c_pdata.gps_gpio_reset = reset;
+
+	return &ar1520_i2c_pdata;
+}
+
 static void __init *no_platform_data(void *info)
 {
 	return NULL;
@@ -489,6 +506,7 @@  static const struct devs_id __initconst device_ids[] = {
 	{"i2c_accel", SFI_DEV_TYPE_I2C, 0, &lis331dl_platform_data},
 	{"pmic_audio", SFI_DEV_TYPE_IPC, 1, &no_platform_data},
 	{"msic_audio", SFI_DEV_TYPE_IPC, 1, &no_platform_data},
+	{"ath1520a", SFI_DEV_TYPE_I2C, 1, &ar1520_gps_platform_data},
 	{},
 };