| Message ID | 1450848156-26022-1-git-send-email-nabendu.bikash.maiti@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Dec 23, 2015 at 10:52:36AM +0530, Nabendu Maiti wrote: > Recalculate watermark when there is a change in pixel format. > > Signed-off-by: Nabendu Maiti <nabendu.bikash.maiti@intel.com> This seems like something that's been broken recently in the watermark shuffling. Please dig out the patch which broke this (using git blame works best usually) and add a Fixes: line per Documentation/SubmittingPatches. Please then also add the patch author, reviwers and anyone else Cc'ed on that patch to your patch here using Cc: lines in the s-o-b section, and then please resend. Also, do we have an igt testcase for this issue? If not, we should definitely have one. -Daniel > --- > drivers/gpu/drm/i915/intel_display.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c > index 2d0b006..4bd5080 100644 > --- a/drivers/gpu/drm/i915/intel_display.c > +++ b/drivers/gpu/drm/i915/intel_display.c > @@ -11819,6 +11819,7 @@ static bool intel_wm_need_update(struct drm_plane *plane, > return false; > > if (cur->base.fb->modifier[0] != new->base.fb->modifier[0] || > + cur->base.fb->pixel_format != new->base.fb->pixel_format || > cur->base.rotation != new->base.rotation || > drm_rect_width(&new->src) != drm_rect_width(&cur->src) || > drm_rect_height(&new->src) != drm_rect_height(&cur->src) || > -- > 1.9.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 2d0b006..4bd5080 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c @@ -11819,6 +11819,7 @@ static bool intel_wm_need_update(struct drm_plane *plane, return false; if (cur->base.fb->modifier[0] != new->base.fb->modifier[0] || + cur->base.fb->pixel_format != new->base.fb->pixel_format || cur->base.rotation != new->base.rotation || drm_rect_width(&new->src) != drm_rect_width(&cur->src) || drm_rect_height(&new->src) != drm_rect_height(&cur->src) ||
Recalculate watermark when there is a change in pixel format. Signed-off-by: Nabendu Maiti <nabendu.bikash.maiti@intel.com> --- drivers/gpu/drm/i915/intel_display.c | 1 + 1 file changed, 1 insertion(+)