| Message ID | 1452079551-30914-2-git-send-email-boris.brezillon@free-electrons.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Jan 06, 2016 at 12:25:51PM +0100, Boris Brezillon wrote: > Add Sil9022 DT bindings description. > > Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com> > --- > .../devicetree/bindings/display/bridge/sil902x.txt | 31 ++++++++++++++++++++++ > 1 file changed, 31 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/bridge/sil902x.txt > > diff --git a/Documentation/devicetree/bindings/display/bridge/sil902x.txt b/Documentation/devicetree/bindings/display/bridge/sil902x.txt > new file mode 100644 > index 0000000..7f1339f > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/bridge/sil902x.txt > @@ -0,0 +1,31 @@ > +sil902x HDMI bridge bindings > + > +Required properties: > + - compatible: "sil,sil9022" > + - reg: i2c address of the bridge > + - reset-gpios: OF device-tree gpio specification for RST_N pin. > + > +Optional properties: > + - interrupts-extended or interrupt-parent + interrupts: describe > + the interrupt line used to inform the host about hotplug events. > + > +Optional subnodes: > + - video input: Device node can contain video input port node to > + connect the bridge to a display controller output (See this > + documentation [1]). > + > +[1]: Documentation/devicetree/bindings/media/video-interfaces.txt > + > +Example: > + hdmi-bridge@39 { > + compatible = "sil,sil9022"; > + reg = <0x39>; > + reset-gpios = <&gpx1 5 1 0 0>; 4 GPIO cells? Valid, but unusual. > + ports { > + port@0 { Either need a reg property here or drop the unit address. You could remove ports as well. > + bridge_in: endpoint { > + remote-endpoint = <&dc_out>; > + }; > + }; > + }; > + }; > -- > 2.1.4 >
Hi Rob, On Wed, 6 Jan 2016 07:19:59 -0600 Rob Herring <robh@kernel.org> wrote: > On Wed, Jan 06, 2016 at 12:25:51PM +0100, Boris Brezillon wrote: > > Add Sil9022 DT bindings description. > > > > Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com> > > --- > > .../devicetree/bindings/display/bridge/sil902x.txt | 31 ++++++++++++++++++++++ > > 1 file changed, 31 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/display/bridge/sil902x.txt > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/sil902x.txt b/Documentation/devicetree/bindings/display/bridge/sil902x.txt > > new file mode 100644 > > index 0000000..7f1339f > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/display/bridge/sil902x.txt > > @@ -0,0 +1,31 @@ > > +sil902x HDMI bridge bindings > > + > > +Required properties: > > + - compatible: "sil,sil9022" > > + - reg: i2c address of the bridge > > + - reset-gpios: OF device-tree gpio specification for RST_N pin. > > + > > +Optional properties: > > + - interrupts-extended or interrupt-parent + interrupts: describe > > + the interrupt line used to inform the host about hotplug events. > > + > > +Optional subnodes: > > + - video input: Device node can contain video input port node to > > + connect the bridge to a display controller output (See this > > + documentation [1]). > > + > > +[1]: Documentation/devicetree/bindings/media/video-interfaces.txt > > + > > +Example: > > + hdmi-bridge@39 { > > + compatible = "sil,sil9022"; > > + reg = <0x39>; > > + reset-gpios = <&gpx1 5 1 0 0>; > > 4 GPIO cells? Valid, but unusual. Hehe, I blindly copied nxp,ptn3460 doc, which is defining such GPIO descriptors :-). I can change that if you want. > > > + ports { > > + port@0 { > > Either need a reg property here or drop the unit address. You could > remove ports as well. Actually we'll likely define a 2nd port for the audio input, so I'd prefer keeping the ports and @0 suffix and adding a reg property rather than just defining port { ... }; Best Regards, Boris
diff --git a/Documentation/devicetree/bindings/display/bridge/sil902x.txt b/Documentation/devicetree/bindings/display/bridge/sil902x.txt new file mode 100644 index 0000000..7f1339f --- /dev/null +++ b/Documentation/devicetree/bindings/display/bridge/sil902x.txt @@ -0,0 +1,31 @@ +sil902x HDMI bridge bindings + +Required properties: + - compatible: "sil,sil9022" + - reg: i2c address of the bridge + - reset-gpios: OF device-tree gpio specification for RST_N pin. + +Optional properties: + - interrupts-extended or interrupt-parent + interrupts: describe + the interrupt line used to inform the host about hotplug events. + +Optional subnodes: + - video input: Device node can contain video input port node to + connect the bridge to a display controller output (See this + documentation [1]). + +[1]: Documentation/devicetree/bindings/media/video-interfaces.txt + +Example: + hdmi-bridge@39 { + compatible = "sil,sil9022"; + reg = <0x39>; + reset-gpios = <&gpx1 5 1 0 0>; + ports { + port@0 { + bridge_in: endpoint { + remote-endpoint = <&dc_out>; + }; + }; + }; + };
Add Sil9022 DT bindings description. Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com> --- .../devicetree/bindings/display/bridge/sil902x.txt | 31 ++++++++++++++++++++++ 1 file changed, 31 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/bridge/sil902x.txt