diff mbox

drm/panel: simple: Add support for Sharp LQ101K1LY04

Message ID 1452614746-7841-1-git-send-email-stillcompiling@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Joshua Clayton Jan. 12, 2016, 4:05 p.m. UTC 
Sharp LQ101K1LY04 is a 10 inch WXGA (1280x800) lvds panel

---
 drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

Comments

Joshua Clayton Jan. 12, 2016, 5:41 p.m. UTC | #1 
On Tue, 12 Jan 2016 08:05:46 -0800
Joshua Clayton <stillcompiling@gmail.com> wrote:

Bah. I mistakenly thought that send-email would add my SoB
if I passed "-s" to git-send-email.

> Sharp LQ101K1LY04 is a 10 inch WXGA (1280x800) lvds panel
> 

Please add:
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
> ---
>  drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
> 
> diff --git a/drivers/gpu/drm/panel/panel-simple.c
> b/drivers/gpu/drm/panel/panel-simple.c index f97b73e..9207b5d 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -708,6 +708,29 @@ static const struct panel_desc
> giantplus_gpg482739qs5 = { .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
>  };
>  
> +static const struct display_timing sharp_lq101k1ly04_timing = {
> +	.pixelclock = { 60000000, 65000000, 80000000 },
> +	.hactive = { 1280, 1280, 1280 },
> +	.hfront_porch = { 20, 20, 20 },
> +	.hback_porch = { 20, 20, 20 },
> +	.hsync_len = { 10, 10, 10 },
> +	.vactive = { 800, 800, 800 },
> +	.vfront_porch = { 4, 4, 4 },
> +	.vback_porch = { 4, 4, 4 },
> +	.vsync_len = { 4, 4, 4 },
> +	.flags = DISPLAY_FLAGS_PIXDATA_POSEDGE,
> +};
> +static const struct panel_desc sharp_lq101k1ly04 = {
> +	.timings = &sharp_lq101k1ly04_timing,
> +	.num_timings = 1,
> +	.bpc = 8,
> +	.size = {
> +		.width = 217,
> +		.height = 136,
> +	},
> +	.bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_JEIDA,
> +};
> +
>  static const struct display_timing hannstar_hsd070pww1_timing = {
>  	.pixelclock = { 64300000, 71100000, 82000000 },
>  	.hactive = { 1280, 1280, 1280 },
> @@ -1146,6 +1169,9 @@ static const struct of_device_id
> platform_of_match[] = { .compatible = "hannstar,hsd070pww1",
>  		.data = &hannstar_hsd070pww1,
>  	}, {
> +		.compatible = "sharp,lq101k1ly04",
> +		.data = &sharp_lq101k1ly04,
> +	}, {
>  		.compatible = "hannstar,hsd100pxn1",
>  		.data = &hannstar_hsd100pxn1,
>  	}, {
Lucas Stach Jan. 12, 2016, 6:45 p.m. UTC | #2 
Hi Joshua,

Am Dienstag, den 12.01.2016, 08:05 -0800 schrieb Joshua Clayton:
> Sharp LQ101K1LY04 is a 10 inch WXGA (1280x800) lvds panel
> 

> ---
>  drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++++++

Missing documentation for the DT binding.

>  1 file changed, 26 insertions(+)
> 
> diff --git a/drivers/gpu/drm/panel/panel-simple.c
> b/drivers/gpu/drm/panel/panel-simple.c
> index f97b73e..9207b5d 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -708,6 +708,29 @@ static const struct panel_desc
> giantplus_gpg482739qs5 = {
>  	.bus_format = MEDIA_BUS_FMT_RGB888_1X24,
>  };
>  
> +static const struct display_timing sharp_lq101k1ly04_timing = {
> +	.pixelclock = { 60000000, 65000000, 80000000 },
> +	.hactive = { 1280, 1280, 1280 },
> +	.hfront_porch = { 20, 20, 20 },
> +	.hback_porch = { 20, 20, 20 },
> +	.hsync_len = { 10, 10, 10 },
> +	.vactive = { 800, 800, 800 },
> +	.vfront_porch = { 4, 4, 4 },
> +	.vback_porch = { 4, 4, 4 },
> +	.vsync_len = { 4, 4, 4 },
> +	.flags = DISPLAY_FLAGS_PIXDATA_POSEDGE,
> +};
> +static const struct panel_desc sharp_lq101k1ly04 = {
> +	.timings = &sharp_lq101k1ly04_timing,
> +	.num_timings = 1,
> +	.bpc = 8,
> +	.size = {
> +		.width = 217,
> +		.height = 136,
> +	},
> +	.bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_JEIDA,
> +};
> +
This hunk isn't added at the correct place. Please keep the
alphabetical sorting.

>  static const struct display_timing hannstar_hsd070pww1_timing = {
>  	.pixelclock = { 64300000, 71100000, 82000000 },
>  	.hactive = { 1280, 1280, 1280 },
> @@ -1146,6 +1169,9 @@ static const struct of_device_id
> platform_of_match[] = {
>  		.compatible = "hannstar,hsd070pww1",
>  		.data = &hannstar_hsd070pww1,
>  	}, {
> +		.compatible = "sharp,lq101k1ly04",
> +		.data = &sharp_lq101k1ly04,
> +	}, {

Wrong insertion place again.

>  		.compatible = "hannstar,hsd100pxn1",
>  		.data = &hannstar_hsd100pxn1,
>  	}, {
Joshua Clayton Jan. 12, 2016, 8:40 p.m. UTC | #3 
Hi Lucas,
Thanks for the review. 

On Tue, 12 Jan 2016 19:45:30 +0100
Lucas Stach <dev@lynxeye.de> wrote:

> >  drivers/gpu/drm/panel/panel-simple.c | 26
> > ++++++++++++++++++++++++++
> 
> Missing documentation for the DT binding.
>

Thanks, will add. 

...

> > +	.bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_JEIDA,
> > +};
> > +
> This hunk isn't added at the correct place. Please keep the
> alphabetical sorting.
OK. Makes sense. I'll reorder these.
> 
> >  static const struct display_timing hannstar_hsd070pww1_timing = {
> >  	.pixelclock = { 64300000, 71100000, 82000000 },
> >  	.hactive = { 1280, 1280, 1280 },
> > @@ -1146,6 +1169,9 @@ static const struct of_device_id
> > platform_of_match[] = {
> >  		.compatible = "hannstar,hsd070pww1",
> >  		.data = &hannstar_hsd070pww1,
> >  	}, {
> > +		.compatible = "sharp,lq101k1ly04",
> > +		.data = &sharp_lq101k1ly04,
> > +	}, {
> 
> Wrong insertion place again.
OK. Will reorder alphabetically also. 

Joshua
diff mbox

Patch

diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index f97b73e..9207b5d 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -708,6 +708,29 @@  static const struct panel_desc giantplus_gpg482739qs5 = {
 	.bus_format = MEDIA_BUS_FMT_RGB888_1X24,
 };
 
+static const struct display_timing sharp_lq101k1ly04_timing = {
+	.pixelclock = { 60000000, 65000000, 80000000 },
+	.hactive = { 1280, 1280, 1280 },
+	.hfront_porch = { 20, 20, 20 },
+	.hback_porch = { 20, 20, 20 },
+	.hsync_len = { 10, 10, 10 },
+	.vactive = { 800, 800, 800 },
+	.vfront_porch = { 4, 4, 4 },
+	.vback_porch = { 4, 4, 4 },
+	.vsync_len = { 4, 4, 4 },
+	.flags = DISPLAY_FLAGS_PIXDATA_POSEDGE,
+};
+static const struct panel_desc sharp_lq101k1ly04 = {
+	.timings = &sharp_lq101k1ly04_timing,
+	.num_timings = 1,
+	.bpc = 8,
+	.size = {
+		.width = 217,
+		.height = 136,
+	},
+	.bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_JEIDA,
+};
+
 static const struct display_timing hannstar_hsd070pww1_timing = {
 	.pixelclock = { 64300000, 71100000, 82000000 },
 	.hactive = { 1280, 1280, 1280 },
@@ -1146,6 +1169,9 @@  static const struct of_device_id platform_of_match[] = {
 		.compatible = "hannstar,hsd070pww1",
 		.data = &hannstar_hsd070pww1,
 	}, {
+		.compatible = "sharp,lq101k1ly04",
+		.data = &sharp_lq101k1ly04,
+	}, {
 		.compatible = "hannstar,hsd100pxn1",
 		.data = &hannstar_hsd100pxn1,
 	}, {