| Message ID | 1452598370-28509-1-git-send-email-ldewangan@nvidia.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
On Tue, Jan 12, 2016 at 05:02:49PM +0530, Laxman Dewangan wrote: > Add support to disable the button from DT via status property > if given button is not supporting on given platforms. > > This will help to re-use the existing dtsi file with status > enable/disable across platforms. > > Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com> > --- > drivers/input/keyboard/gpio_keys.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/input/keyboard/gpio_keys.c b/drivers/input/keyboard/gpio_keys.c > index bef317f..cf068cb 100644 > --- a/drivers/input/keyboard/gpio_keys.c > +++ b/drivers/input/keyboard/gpio_keys.c > @@ -632,6 +632,14 @@ gpio_keys_get_devtree_pdata(struct device *dev) > for_each_child_of_node(node, pp) { > enum of_gpio_flags flags; > > + /* Ignore the button if status of node is disabled */ > + error = of_device_is_available(pp); > + if (!error) { > + dev_info(dev, "Button %s is ignored\n", pp->name); I'd rather have it as dev_dbg() please. > + pdata->nbuttons--; > + continue; > + } > + > button = &pdata->buttons[i++]; > > button->gpio = of_get_gpio_flags(pp, 0, &flags); > -- > 2.1.4 >
diff --git a/drivers/input/keyboard/gpio_keys.c b/drivers/input/keyboard/gpio_keys.c index bef317f..cf068cb 100644 --- a/drivers/input/keyboard/gpio_keys.c +++ b/drivers/input/keyboard/gpio_keys.c @@ -632,6 +632,14 @@ gpio_keys_get_devtree_pdata(struct device *dev) for_each_child_of_node(node, pp) { enum of_gpio_flags flags; + /* Ignore the button if status of node is disabled */ + error = of_device_is_available(pp); + if (!error) { + dev_info(dev, "Button %s is ignored\n", pp->name); + pdata->nbuttons--; + continue; + } + button = &pdata->buttons[i++]; button->gpio = of_get_gpio_flags(pp, 0, &flags);
Add support to disable the button from DT via status property if given button is not supporting on given platforms. This will help to re-use the existing dtsi file with status enable/disable across platforms. Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com> --- drivers/input/keyboard/gpio_keys.c | 8 ++++++++ 1 file changed, 8 insertions(+)