| Message ID | 1452531649-14940-1-git-send-email-linux@roeck-us.net (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Jan 11, 2016 at 6:00 PM, Guenter Roeck <linux@roeck-us.net> wrote: > Since commit 0f4630f3720e ("gpio: generic: factor into gpio_chip struct"), > all users of struct bgpio_pdata depend on GPIO_GENERIC. > > This results in the following build error. > > arch/arm/mach-s3c64xx/mach-crag6410.c:270:3: warning: > excess elements in struct initializer > arch/arm/mach-s3c64xx/mach-crag6410.c:270:3: warning: > (near initialization for '(anonymous)') > arch/arm/mach-s3c64xx/mach-crag6410.c:271:2: error: > invalid use of undefined type 'struct bgpio_pdata' > > Fixes: 0f4630f3720e ("gpio: generic: factor into gpio_chip struct") > Cc: Linus Walleij <linus.walleij@linaro.org> > Signed-off-by: Guenter Roeck <linux@roeck-us.net> > --- > I don't know if this is the correct way to fix this problem. > If not, please consider this to be a bug report. I think this is fixed by Arnds patch: http://marc.info/?l=linux-gpio&m=145237423205247&w=2 Can you verify that? Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 01/14/2016 01:02 AM, Linus Walleij wrote: > On Mon, Jan 11, 2016 at 6:00 PM, Guenter Roeck <linux@roeck-us.net> wrote: > >> Since commit 0f4630f3720e ("gpio: generic: factor into gpio_chip struct"), >> all users of struct bgpio_pdata depend on GPIO_GENERIC. >> >> This results in the following build error. >> >> arch/arm/mach-s3c64xx/mach-crag6410.c:270:3: warning: >> excess elements in struct initializer >> arch/arm/mach-s3c64xx/mach-crag6410.c:270:3: warning: >> (near initialization for '(anonymous)') >> arch/arm/mach-s3c64xx/mach-crag6410.c:271:2: error: >> invalid use of undefined type 'struct bgpio_pdata' >> >> Fixes: 0f4630f3720e ("gpio: generic: factor into gpio_chip struct") >> Cc: Linus Walleij <linus.walleij@linaro.org> >> Signed-off-by: Guenter Roeck <linux@roeck-us.net> >> --- >> I don't know if this is the correct way to fix this problem. >> If not, please consider this to be a bug report. > > I think this is fixed by Arnds patch: > http://marc.info/?l=linux-gpio&m=145237423205247&w=2 > > Can you verify that? > Correct. Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/mach-s3c64xx/Kconfig b/arch/arm/mach-s3c64xx/Kconfig index 7c0c420c3016..98d2aa9393f1 100644 --- a/arch/arm/mach-s3c64xx/Kconfig +++ b/arch/arm/mach-s3c64xx/Kconfig @@ -310,6 +310,7 @@ config MACH_WLF_CRAGG_6410 depends on I2C=y select CPU_S3C6410 select LEDS_GPIO_REGISTER + select GPIO_GENERIC_PLATFORM select S3C64XX_DEV_SPI0 select S3C64XX_SETUP_FB_24BPP select S3C64XX_SETUP_I2C1
Since commit 0f4630f3720e ("gpio: generic: factor into gpio_chip struct"), all users of struct bgpio_pdata depend on GPIO_GENERIC. This results in the following build error. arch/arm/mach-s3c64xx/mach-crag6410.c:270:3: warning: excess elements in struct initializer arch/arm/mach-s3c64xx/mach-crag6410.c:270:3: warning: (near initialization for '(anonymous)') arch/arm/mach-s3c64xx/mach-crag6410.c:271:2: error: invalid use of undefined type 'struct bgpio_pdata' Fixes: 0f4630f3720e ("gpio: generic: factor into gpio_chip struct") Cc: Linus Walleij <linus.walleij@linaro.org> Signed-off-by: Guenter Roeck <linux@roeck-us.net> --- I don't know if this is the correct way to fix this problem. If not, please consider this to be a bug report. arch/arm/mach-s3c64xx/Kconfig | 1 + 1 file changed, 1 insertion(+)