| Message ID | 1452797047-18322-1-git-send-email-edgar.iglesias@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
>>> On 14.01.16 at 19:44, <edgar.iglesias@gmail.com> wrote: > --- a/xen/drivers/char/cadence-uart.c > +++ b/xen/drivers/char/cadence-uart.c Considering the wider than expected Cc list - is there an entry missing from the ARM section in ./MAINTAINERS here? Jan
On Fri, Jan 15, 2016 at 04:20:18AM -0700, Jan Beulich wrote: > >>> On 14.01.16 at 19:44, <edgar.iglesias@gmail.com> wrote: > > --- a/xen/drivers/char/cadence-uart.c > > +++ b/xen/drivers/char/cadence-uart.c > > Considering the wider than expected Cc list - is there an entry missing > from the ARM section in ./MAINTAINERS here? > Yes, that seems to be the case. I've just sent a patch to MAINTAINERS to fix that. Cheers, Edgar
On Thu, 2016-01-14 at 19:44 +0100, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com> Where are the bindings for cdns,uart-r1p12 defined? I don't see it mentioned in the Documentation/devicetree/bindings/serial/cdns,uart.txt in mainline Linux. Does the driver need to differ at all compared with what is needed for r1p8? Normally if there is no (practical/visible) difference then in DT- world there is no need for a new compatible string, since the device is still compatible. If there are differences in the h/w but they are not relevant to our particular driven then please say so in the commit log. Ian. > > Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com> > --- > xen/drivers/char/cadence-uart.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/xen/drivers/char/cadence-uart.c b/xen/drivers/char/cadence- > uart.c > index 933672f..7f90f8d 100644 > --- a/xen/drivers/char/cadence-uart.c > +++ b/xen/drivers/char/cadence-uart.c > @@ -206,6 +206,7 @@ static int __init cuart_init(struct dt_device_node > *dev, const void *data) > static const struct dt_device_match cuart_dt_match[] __initconst = > { > DT_MATCH_COMPATIBLE("cdns,uart-r1p8"), > + DT_MATCH_COMPATIBLE("cdns,uart-r1p12"), > { /* sentinel */ }, > }; >
On Fri, Jan 15, 2016 at 12:30:27PM +0000, Ian Campbell wrote: > On Thu, 2016-01-14 at 19:44 +0100, Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com> > > Where are the bindings for cdns,uart-r1p12 defined? I don't see it > mentioned in the Documentation/devicetree/bindings/serial/cdns,uart.txt in > mainline Linux. Hi Ian, The bindings are currently in our queue: https://github.com/Xilinx/linux-xlnx/blob/master/Documentation/devicetree/bindings/serial/cdns%2Cuart.txt > Does the driver need to differ at all compared with what is needed for > r1p8? Normally if there is no (practical/visible) difference then in DT- > world there is no need for a new compatible string, since the device is > still compatible. > > If there are differences in the h/w but they are not relevant to our > particular driven then please say so in the commit log. Right, there are SW visible differences (the Linux driver uses them) but none affecting XEN. I'll note that in the commit message. Thanks, Edgar > > Ian. > > > > > Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com> > > --- > > xen/drivers/char/cadence-uart.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/xen/drivers/char/cadence-uart.c b/xen/drivers/char/cadence- > > uart.c > > index 933672f..7f90f8d 100644 > > --- a/xen/drivers/char/cadence-uart.c > > +++ b/xen/drivers/char/cadence-uart.c > > @@ -206,6 +206,7 @@ static int __init cuart_init(struct dt_device_node > > *dev, const void *data) > > static const struct dt_device_match cuart_dt_match[] __initconst = > > { > > DT_MATCH_COMPATIBLE("cdns,uart-r1p8"), > > + DT_MATCH_COMPATIBLE("cdns,uart-r1p12"), > > { /* sentinel */ }, > > }; > >
On Fri, 2016-01-15 at 14:30 +0100, Edgar E. Iglesias wrote: > On Fri, Jan 15, 2016 at 12:30:27PM +0000, Ian Campbell wrote: > > On Thu, 2016-01-14 at 19:44 +0100, Edgar E. Iglesias wrote: > > > From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com> > > > > Where are the bindings for cdns,uart-r1p12 defined? I don't see it > > mentioned in the Documentation/devicetree/bindings/serial/cdns,uart.txt > > in > > mainline Linux. > > Hi Ian, > > The bindings are currently in our queue: > https://github.com/Xilinx/linux- > xlnx/blob/master/Documentation/devicetree/bindings/serial/cdns%2Cuart.txt Great, thanks. > > > Does the driver need to differ at all compared with what is needed for > > r1p8? Normally if there is no (practical/visible) difference then in > > DT- > > world there is no need for a new compatible string, since the device is > > still compatible. > > > > If there are differences in the h/w but they are not relevant to our > > particular driven then please say so in the commit log. > > Right, there are SW visible differences (the Linux driver uses them) but > none affecting XEN. I'll note that in the commit message. If you want to just supply some words here I'll fold them in upon commit. Or feel free to send a v2 if you prefer. Ian.
On Fri, Jan 15, 2016 at 01:46:05PM +0000, Ian Campbell wrote: > On Fri, 2016-01-15 at 14:30 +0100, Edgar E. Iglesias wrote: > > On Fri, Jan 15, 2016 at 12:30:27PM +0000, Ian Campbell wrote: > > > On Thu, 2016-01-14 at 19:44 +0100, Edgar E. Iglesias wrote: > > > > From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com> > > > > > > Where are the bindings for cdns,uart-r1p12 defined? I don't see it > > > mentioned in the Documentation/devicetree/bindings/serial/cdns,uart.txt > > > in > > > mainline Linux. > > > > Hi Ian, > > > > The bindings are currently in our queue: > > https://github.com/Xilinx/linux- > > xlnx/blob/master/Documentation/devicetree/bindings/serial/cdns%2Cuart.txt > > Great, thanks. > > > > > Does the driver need to differ at all compared with what is needed for > > > r1p8? Normally if there is no (practical/visible) difference then in > > > DT- > > > world there is no need for a new compatible string, since the device is > > > still compatible. > > > > > > If there are differences in the h/w but they are not relevant to our > > > particular driven then please say so in the commit log. > > > > Right, there are SW visible differences (the Linux driver uses them) but > > none affecting XEN. I'll note that in the commit message. > > If you want to just supply some words here I'll fold them in upon commit. > Or feel free to send a v2 if you prefer. Thanks Ian, I've inlined something here. BTW, what is the policy for getting patches into -stable? It would be great if this patch could be taken in to have XEN 4.6.x work out of the box on ZynqMPSoC with updated DTBs. Best regards, Edgar New commit message: xen/arm: Add r1p12 to the list of supported Cadence UARTs Add r1p12 to the list of supported Cadence UARTs. XEN only uses the subset of features available in r1p8, so we don't need to differentiate between r1p8 and r1p12 yet. Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
On Fri, 2016-01-15 at 15:36 +0100, Edgar E. Iglesias wrote: > On Fri, Jan 15, 2016 at 01:46:05PM +0000, Ian Campbell wrote: > > On Fri, 2016-01-15 at 14:30 +0100, Edgar E. Iglesias wrote: > > > On Fri, Jan 15, 2016 at 12:30:27PM +0000, Ian Campbell wrote: > > > > On Thu, 2016-01-14 at 19:44 +0100, Edgar E. Iglesias wrote: > > > > > From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com> > > > > > > > > Where are the bindings for cdns,uart-r1p12 defined? I don't see it > > > > mentioned in the > > > > Documentation/devicetree/bindings/serial/cdns,uart.txt > > > > in > > > > mainline Linux. > > > > > > Hi Ian, > > > > > > The bindings are currently in our queue: > > > https://github.com/Xilinx/linux- > > > xlnx/blob/master/Documentation/devicetree/bindings/serial/cdns%2Cuart > > > .txt > > > > Great, thanks. > > > > > > > Does the driver need to differ at all compared with what is needed > > > > for > > > > r1p8? Normally if there is no (practical/visible) difference then > > > > in > > > > DT- > > > > world there is no need for a new compatible string, since the > > > > device is > > > > still compatible. > > > > > > > > If there are differences in the h/w but they are not relevant to > > > > our > > > > particular driven then please say so in the commit log. > > > > > > Right, there are SW visible differences (the Linux driver uses them) > > > but > > > none affecting XEN. I'll note that in the commit message. > > > > If you want to just supply some words here I'll fold them in upon > > commit. > > Or feel free to send a v2 if you prefer. > > Thanks Ian, I've inlined something here. > BTW, what is the policy for getting patches into -stable? Please see http://wiki.xen.org/wiki/Xen_Maintenance_Releases and the MAINTAIENRS file in the stable branches. TL;DR: I think this is fine and I have added to my list of things to backport. > It would be great if this patch could be taken in to have > XEN 4.6.x work out of the box on ZynqMPSoC with updated > DTBs. > > Best regards, > Edgar > > New commit message: > xen/arm: Add r1p12 to the list of supported Cadence UARTs > > Add r1p12 to the list of supported Cadence UARTs. XEN only > uses the subset of features available in r1p8, so we don't > need to differentiate between r1p8 and r1p12 yet. > > Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com> Acked-by: Ian Campbell <ian.campbell@citrix.com> <pedant>It's spelled "Xen" or "xen", not "XEN"</pedant>
On Fri, 2016-01-15 at 14:42 +0000, Ian Campbell wrote: > > > xen/arm: Add r1p12 to the list of supported Cadence UARTs > > > > Add r1p12 to the list of supported Cadence UARTs. XEN only > > uses the subset of features available in r1p8, so we don't > > need to differentiate between r1p8 and r1p12 yet. > > > > Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com> > > Acked-by: Ian Campbell <ian.campbell@citrix.com> Applied, thanks.
diff --git a/xen/drivers/char/cadence-uart.c b/xen/drivers/char/cadence-uart.c index 933672f..7f90f8d 100644 --- a/xen/drivers/char/cadence-uart.c +++ b/xen/drivers/char/cadence-uart.c @@ -206,6 +206,7 @@ static int __init cuart_init(struct dt_device_node *dev, const void *data) static const struct dt_device_match cuart_dt_match[] __initconst = { DT_MATCH_COMPATIBLE("cdns,uart-r1p8"), + DT_MATCH_COMPATIBLE("cdns,uart-r1p12"), { /* sentinel */ }, };