diff mbox

[1/7] drm/i915: color range only works on pre-ILK

Message ID 1303240361-6057-2-git-send-email-jbarnes@virtuousgeek.org (mailing list archive)
State New, archived
Headers show

Commit Message

Jesse Barnes April 19, 2011, 7:12 p.m. UTC 
ILK+ provides this feature in the transcoder and pipe configuration instead.

Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
---
 drivers/gpu/drm/i915/intel_hdmi.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

Comments

Keith Packard May 10, 2011, 9:12 p.m. UTC | #1 
On Tue, 19 Apr 2011 12:12:35 -0700, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:

> ILK+ provides this feature in the transcoder and pipe configuration
> instead.

This doesn't seem to add in a new implementation of this feature for
ILK, just stops using the pre-ILK version on ILK. Please explain how
this is sufficient?
Jesse Barnes May 10, 2011, 9:16 p.m. UTC | #2 
On Tue, 10 May 2011 14:12:48 -0700
Keith Packard <keithp@keithp.com> wrote:

> On Tue, 19 Apr 2011 12:12:35 -0700, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> 
> > ILK+ provides this feature in the transcoder and pipe configuration
> > instead.
> 
> This doesn't seem to add in a new implementation of this feature for
> ILK, just stops using the pre-ILK version on ILK. Please explain how
> this is sufficient?

That's in patch 7/7, you want me to combine this fix with the feature
addition for ILK+?
Jesse Barnes May 10, 2011, 9:22 p.m. UTC | #3 
On Tue, 10 May 2011 14:16:57 -0700
Jesse Barnes <jbarnes@virtuousgeek.org> wrote:

> On Tue, 10 May 2011 14:12:48 -0700
> Keith Packard <keithp@keithp.com> wrote:
> 
> > On Tue, 19 Apr 2011 12:12:35 -0700, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> > 
> > > ILK+ provides this feature in the transcoder and pipe configuration
> > > instead.
> > 
> > This doesn't seem to add in a new implementation of this feature for
> > ILK, just stops using the pre-ILK version on ILK. Please explain how
> > this is sufficient?
> 
> That's in patch 7/7, you want me to combine this fix with the feature
> addition for ILK+?

Actually not; this is just a bug fix.  I haven't looked at adding
broadcast colorspace support to ILK+ yet.
Keith Packard May 10, 2011, 10:14 p.m. UTC | #4 
On Tue, 10 May 2011 14:16:57 -0700, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:

> That's in patch 7/7, you want me to combine this fix with the feature
> addition for ILK+?

No, I'm good with separate patches, just want to see the patch described
correctly.
diff mbox

Patch

diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c
index f289b86..a6871d8 100644
--- a/drivers/gpu/drm/i915/intel_hdmi.c
+++ b/drivers/gpu/drm/i915/intel_hdmi.c
@@ -125,7 +125,8 @@  static void intel_hdmi_mode_set(struct drm_encoder *encoder,
 	u32 sdvox;
 
 	sdvox = SDVO_ENCODING_HDMI | SDVO_BORDER_ENABLE;
-	sdvox |= intel_hdmi->color_range;
+	if (!HAS_PCH_SPLIT(dev))
+		sdvox |= intel_hdmi->color_range;
 	if (adjusted_mode->flags & DRM_MODE_FLAG_PVSYNC)
 		sdvox |= SDVO_VSYNC_ACTIVE_HIGH;
 	if (adjusted_mode->flags & DRM_MODE_FLAG_PHSYNC)