diff mbox

PROBLEM: Intel HDMI output busticated on 4.4 (regression)

Message ID 20160119222622.GA16397@draconx.ca (mailing list archive)
State New, archived
Headers show

Commit Message

Nick Bowler Jan. 19, 2016, 10:26 p.m. UTC 
Hi,

Upgrading from 4.3 to 4.4 breaks my HDMI output on my G45 machine.

As soon as the intel driver is loaded, the monitor shuts off
(standby mode).  Inspecting /sys/class/drm/card0-HDMI-A-1/status
reports "disconnected".  When it is working, this attribute says
"connected".

There is nothing unusual printed to dmesg.

Bisection pinpoints the following:

  237ed86c693d8a8e4db476976aeb30df4deac74b is the first bad commit
  commit 237ed86c693d8a8e4db476976aeb30df4deac74b
  Author: Sonika Jindal <sonika.jindal@intel.com>
  Date:   Tue Sep 15 09:44:20 2015 +0530
  
      drm/i915: Check live status before reading edid
      [...]
      Signed-off-by: Shashank Sharma <shashank.sharma@intel.com>
      Signed-off-by: Sonika Jindal <sonika.jindal@intel.com>
      Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
      Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

The commit does not revert cleanly, but this patch resolves the issue:


Let me know if you need any more info.

Thanks,
  Nick

Comments

sonika.jindal@intel.com Jan. 20, 2016, 4:30 a.m. UTC | #1 
Can you please check if you have following patch:
"commit 3d8acd1f667b45c531401c8f0c2033072e32a05d
Author: Gary Wang <gary.c.wang@intel.com>
Date:   Wed Dec 23 16:11:35 2015 +0800

drm/i915: increase the tries for HDMI hotplug live status checking"

For some monitors, 30ms delay is not good enough to report the live 
status correctly.

Does the same system works with any other monitor?

Daniel,

Can this be related to the live status bits on g45?
"commit 0ce99f749b3834edeb500e17d6ad17e86b60ff83
Author: Daniel Vetter <daniel.vetter@ffwll.ch>
Date:   Fri Jul 26 11:27:49 2013 +0200

     drm/i915: fix gen4 digital port hotplug definitions"

Regards,
Sonika


On 1/20/2016 3:56 AM, Nick Bowler wrote:
> Hi,
>
> Upgrading from 4.3 to 4.4 breaks my HDMI output on my G45 machine.
>
> As soon as the intel driver is loaded, the monitor shuts off
> (standby mode).  Inspecting /sys/class/drm/card0-HDMI-A-1/status
> reports "disconnected".  When it is working, this attribute says
> "connected".
>
> There is nothing unusual printed to dmesg.
>
> Bisection pinpoints the following:
>
>    237ed86c693d8a8e4db476976aeb30df4deac74b is the first bad commit
>    commit 237ed86c693d8a8e4db476976aeb30df4deac74b
>    Author: Sonika Jindal <sonika.jindal@intel.com>
>    Date:   Tue Sep 15 09:44:20 2015 +0530
>    
>        drm/i915: Check live status before reading edid
>        [...]
>        Signed-off-by: Shashank Sharma <shashank.sharma@intel.com>
>        Signed-off-by: Sonika Jindal <sonika.jindal@intel.com>
>        Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
>        Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>
> The commit does not revert cleanly, but this patch resolves the issue:
>
> diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c
> index e6c035b0fc1c..8cefb9105f26 100644
> --- a/drivers/gpu/drm/i915/intel_hdmi.c
> +++ b/drivers/gpu/drm/i915/intel_hdmi.c
> @@ -1393,7 +1393,7 @@ intel_hdmi_detect(struct drm_connector *connector, bool force)
>   
>          intel_hdmi_unset_edid(connector);
>   
> -       if (intel_hdmi_set_edid(connector, live_status)) {
> +       if (intel_hdmi_set_edid(connector, true)) {
>                  struct intel_hdmi *intel_hdmi = intel_attached_hdmi(connector);
>   
>                  hdmi_to_dig_port(intel_hdmi)->base.type = INTEL_OUTPUT_HDMI;
>
> Let me know if you need any more info.
>
> Thanks,
>    Nick
Nick Bowler Jan. 20, 2016, 3:33 p.m. UTC | #2 
Hi,

On 2016-01-20, Jindal, Sonika <sonika.jindal@intel.com> wrote:
> Can you please check if you have following patch:
> "commit 3d8acd1f667b45c531401c8f0c2033072e32a05d
> Author: Gary Wang <gary.c.wang@intel.com>
> Date:   Wed Dec 23 16:11:35 2015 +0800
>
> drm/i915: increase the tries for HDMI hotplug live status checking"

Yes, that patch seems to be present in 4.4.

> Does the same system works with any other monitor?

I'll see if I can find another to try.

Thanks,
  Nick
Nick Bowler Jan. 21, 2016, 3:29 a.m. UTC | #3 
On 1/20/16, Nick Bowler <nbowler@draconx.ca> wrote:
> Hi,
>
> On 2016-01-20, Jindal, Sonika <sonika.jindal@intel.com> wrote:
>> Can you please check if you have following patch:
>> "commit 3d8acd1f667b45c531401c8f0c2033072e32a05d
>> Author: Gary Wang <gary.c.wang@intel.com>
>> Date:   Wed Dec 23 16:11:35 2015 +0800
>>
>> drm/i915: increase the tries for HDMI hotplug live status checking"
>
> Yes, that patch seems to be present in 4.4.
>
>> Does the same system works with any other monitor?
>
> I'll see if I can find another to try.

I tried another monitor, and the same problem occurs.
sonika.jindal@intel.com Jan. 21, 2016, 11:07 a.m. UTC | #4 
On 1/21/2016 8:59 AM, Nick Bowler wrote:
> On 1/20/16, Nick Bowler <nbowler@draconx.ca> wrote:
>> Hi,
>>
>> On 2016-01-20, Jindal, Sonika <sonika.jindal@intel.com> wrote:
>>> Can you please check if you have following patch:
>>> "commit 3d8acd1f667b45c531401c8f0c2033072e32a05d
>>> Author: Gary Wang <gary.c.wang@intel.com>
>>> Date:   Wed Dec 23 16:11:35 2015 +0800
>>>
>>> drm/i915: increase the tries for HDMI hotplug live status checking"
>> Yes, that patch seems to be present in 4.4.
>>
>>> Does the same system works with any other monitor?
>> I'll see if I can find another to try.
> I tried another monitor, and the same problem occurs.
Which make are these monitors?
Do you have any other system other than G45?

Shashank,
Do you suggest anything else which Nick can try?
Nick Bowler Jan. 21, 2016, 1:57 p.m. UTC | #5 
On 2016-01-21, Jindal, Sonika <sonika.jindal@intel.com> wrote:
> On 1/21/2016 8:59 AM, Nick Bowler wrote:
>> On 1/20/16, Nick Bowler <nbowler@draconx.ca> wrote:
>>> On 2016-01-20, Jindal, Sonika <sonika.jindal@intel.com> wrote:
[...]
>>>> Does the same system works with any other monitor?
>>> I'll see if I can find another to try.
>> I tried another monitor, and the same problem occurs.
> Which make are these monitors?

 - LG Flatron W2253V
 - Dell E228WFPc

> Do you have any other system other than G45?

Nothing else with Linux 4.4, unfortunately.

Thanks,
  Nick
Nick Bowler Jan. 28, 2016, 6 a.m. UTC | #6 
On 2016-01-21, Nick Bowler <nbowler@draconx.ca> wrote:
> On 2016-01-21, Jindal, Sonika <sonika.jindal@intel.com> wrote:
>> On 1/21/2016 8:59 AM, Nick Bowler wrote:
>>> On 1/20/16, Nick Bowler <nbowler@draconx.ca> wrote:
>>>> On 2016-01-20, Jindal, Sonika <sonika.jindal@intel.com> wrote:
> [...]
>>>>> Does the same system works with any other monitor?
>>>> I'll see if I can find another to try.
>>> I tried another monitor, and the same problem occurs.
>> Which make are these monitors?
>
>  - LG Flatron W2253V
>  - Dell E228WFPc
>
>> Do you have any other system other than G45?
>
> Nothing else with Linux 4.4, unfortunately.

Anything else you want me to try?

This issue is still present in 4.5-rc1.

Cheers,
  Nick
Nick Bowler Feb. 9, 2016, 4:33 p.m. UTC | #7 
On 1/28/16, Nick Bowler <nbowler@draconx.ca> wrote:
> On 2016-01-21, Nick Bowler <nbowler@draconx.ca> wrote:
>> On 2016-01-21, Jindal, Sonika <sonika.jindal@intel.com> wrote:
>>> On 1/21/2016 8:59 AM, Nick Bowler wrote:
>>>> On 1/20/16, Nick Bowler <nbowler@draconx.ca> wrote:
>>>>> On 2016-01-20, Jindal, Sonika <sonika.jindal@intel.com> wrote:
>> [...]
>>>>>> Does the same system works with any other monitor?
>>>>> I'll see if I can find another to try.
>>>> I tried another monitor, and the same problem occurs.
>>> Which make are these monitors?
>>
>>  - LG Flatron W2253V
>>  - Dell E228WFPc
>>
>>> Do you have any other system other than G45?
>>
>> Nothing else with Linux 4.4, unfortunately.
>
> Anything else you want me to try?
>
> This issue is still present in 4.5-rc1.

Ping?

HDMI is still broken on my system in 4.5-rc3.

Cheers,
  Nick
Sharma, Shashank Feb. 9, 2016, 4:39 p.m. UTC | #8 
Hi Nick, 

Sonika is OOO for this week. 
AFAIK about this issue, looks like the live status is not getting set for your system, on HPD. 

As per the Bspec, we must check live status before trying to read EDID. 
Is it possible for you to check with an HDMI analyzer and probe live status register ?

Regards
Shashank
-----Original Message-----
From: Nick Bowler [mailto:nbowler@draconx.ca] 

Sent: Tuesday, February 09, 2016 10:03 PM
To: Jindal, Sonika
Cc: linux-kernel@vger.kernel.org; dri-devel@lists.freedesktop.org; Daniel Vetter; Sharma, Shashank
Subject: Re: PROBLEM: Intel HDMI output busticated on 4.4 (regression)

On 1/28/16, Nick Bowler <nbowler@draconx.ca> wrote:
> On 2016-01-21, Nick Bowler <nbowler@draconx.ca> wrote:

>> On 2016-01-21, Jindal, Sonika <sonika.jindal@intel.com> wrote:

>>> On 1/21/2016 8:59 AM, Nick Bowler wrote:

>>>> On 1/20/16, Nick Bowler <nbowler@draconx.ca> wrote:

>>>>> On 2016-01-20, Jindal, Sonika <sonika.jindal@intel.com> wrote:

>> [...]

>>>>>> Does the same system works with any other monitor?

>>>>> I'll see if I can find another to try.

>>>> I tried another monitor, and the same problem occurs.

>>> Which make are these monitors?

>>

>>  - LG Flatron W2253V

>>  - Dell E228WFPc

>>

>>> Do you have any other system other than G45?

>>

>> Nothing else with Linux 4.4, unfortunately.

>

> Anything else you want me to try?

>

> This issue is still present in 4.5-rc1.


Ping?

HDMI is still broken on my system in 4.5-rc3.

Cheers,
  Nick
diff mbox

Patch

diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c
index e6c035b0fc1c..8cefb9105f26 100644
--- a/drivers/gpu/drm/i915/intel_hdmi.c
+++ b/drivers/gpu/drm/i915/intel_hdmi.c
@@ -1393,7 +1393,7 @@  intel_hdmi_detect(struct drm_connector *connector, bool force)
 
        intel_hdmi_unset_edid(connector);
 
-       if (intel_hdmi_set_edid(connector, live_status)) {
+       if (intel_hdmi_set_edid(connector, true)) {
                struct intel_hdmi *intel_hdmi = intel_attached_hdmi(connector);
 
                hdmi_to_dig_port(intel_hdmi)->base.type = INTEL_OUTPUT_HDMI;