diff mbox

[6/7] ath10k: Enable periodic peer stats update

Message ID 1452699994-5078-7-git-send-email-mohammed@qca.qualcomm.com (mailing list archive)
State Accepted
Headers show

Commit Message

Mohammed Shafi Shajakhan Jan. 13, 2016, 3:46 p.m. UTC
From: Mohammed Shafi Shajakhan <mohammed@qti.qualcomm.com>

Register for 500ms as periodic peer stats update period,
and parameters like rx_duration that needs to be tracked
in host can be achieved by this provision, also periodic
stats update is the future of fw_stats and shall be extended
for pdev / vdev stats irrespecitive PEER_STATS service is enabled
or not

Signed-off-by: Mohammed Shafi Shajakhan <mohammed@qti.qualcomm.com>
---
 drivers/net/wireless/ath/ath10k/mac.c |   12 ++++++++++++
 1 file changed, 12 insertions(+)

Comments

Kalle Valo Jan. 21, 2016, 12:48 p.m. UTC | #1
Mohammed Shafi Shajakhan <mohammed@qti.qualcomm.com> writes:

> From: Mohammed Shafi Shajakhan <mohammed@qti.qualcomm.com>
>
> Register for 500ms as periodic peer stats update period,
> and parameters like rx_duration that needs to be tracked
> in host can be achieved by this provision, also periodic
> stats update is the future of fw_stats and shall be extended
> for pdev / vdev stats irrespecitive PEER_STATS service is enabled
> or not
>
> Signed-off-by: Mohammed Shafi Shajakhan <mohammed@qti.qualcomm.com>
> ---
>  drivers/net/wireless/ath/ath10k/mac.c |   12 ++++++++++++
>  1 file changed, 12 insertions(+)
>
> diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
> index 2dba57c..fd4b4df 100644
> --- a/drivers/net/wireless/ath/ath10k/mac.c
> +++ b/drivers/net/wireless/ath/ath10k/mac.c
> @@ -4103,6 +4103,18 @@ static int ath10k_start(struct ieee80211_hw *hw)
>  
>  	ar->ani_enabled = true;
>  
> +	if (test_bit(WMI_SERVICE_PEER_STATS, ar->wmi.svc_map)) {
> +		param = ar->wmi.pdev_param->peer_stats_update_period;
> +		ret = ath10k_wmi_pdev_set_param(ar, param,
> +					PEER_DEFAULT_STATS_UPDATE_PERIOD);

This gives a new checkpatch warning:

drivers/net/wireless/ath/ath10k/mac.c:4110: Alignment should match open parenthesis

I fixed that in the pending branch.
Mohammed Shafi Shajakhan Jan. 21, 2016, 2:01 p.m. UTC | #2
On Thu, Jan 21, 2016 at 02:48:13PM +0200, Kalle Valo wrote:
> Mohammed Shafi Shajakhan <mohammed@qti.qualcomm.com> writes:
> 
> > From: Mohammed Shafi Shajakhan <mohammed@qti.qualcomm.com>
> >
> > Register for 500ms as periodic peer stats update period,
> > and parameters like rx_duration that needs to be tracked
> > in host can be achieved by this provision, also periodic
> > stats update is the future of fw_stats and shall be extended
> > for pdev / vdev stats irrespecitive PEER_STATS service is enabled
> > or not
> >
> > Signed-off-by: Mohammed Shafi Shajakhan <mohammed@qti.qualcomm.com>
> > ---
> >  drivers/net/wireless/ath/ath10k/mac.c |   12 ++++++++++++
> >  1 file changed, 12 insertions(+)
> >
> > diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
> > index 2dba57c..fd4b4df 100644
> > --- a/drivers/net/wireless/ath/ath10k/mac.c
> > +++ b/drivers/net/wireless/ath/ath10k/mac.c
> > @@ -4103,6 +4103,18 @@ static int ath10k_start(struct ieee80211_hw *hw)
> >  
> >  	ar->ani_enabled = true;
> >  
> > +	if (test_bit(WMI_SERVICE_PEER_STATS, ar->wmi.svc_map)) {
> > +		param = ar->wmi.pdev_param->peer_stats_update_period;
> > +		ret = ath10k_wmi_pdev_set_param(ar, param,
> > +					PEER_DEFAULT_STATS_UPDATE_PERIOD);
> 
> This gives a new checkpatch warning:
> 
> drivers/net/wireless/ath/ath10k/mac.c:4110: Alignment should match open parenthesis
> 
> I fixed that in the pending branch.
>
[shafi] thank you Kalle Valo !

regards,
shafi
diff mbox

Patch

diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
index 2dba57c..fd4b4df 100644
--- a/drivers/net/wireless/ath/ath10k/mac.c
+++ b/drivers/net/wireless/ath/ath10k/mac.c
@@ -4103,6 +4103,18 @@  static int ath10k_start(struct ieee80211_hw *hw)
 
 	ar->ani_enabled = true;
 
+	if (test_bit(WMI_SERVICE_PEER_STATS, ar->wmi.svc_map)) {
+		param = ar->wmi.pdev_param->peer_stats_update_period;
+		ret = ath10k_wmi_pdev_set_param(ar, param,
+					PEER_DEFAULT_STATS_UPDATE_PERIOD);
+		if (ret) {
+			ath10k_warn(ar,
+				    "failed to set peer stats period : %d\n",
+				    ret);
+			goto err_core_stop;
+		}
+	}
+
 	ar->num_started_vdevs = 0;
 	ath10k_regd_update(ar);