| Message ID | 1453581610-23179-13-git-send-email-hpoussin@reactos.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Sat, Jan 23, 2016 at 09:40:09PM +0100, Hervé Poussineau wrote:
> It doesn't seem to be used, and operating systems should accept a 'unknown command' answer.
Mac OS 9 does seem to make the call, but it seems happy getting an 'unknown
command' response; I can't find the original MOL tree (I guess it used to be
in BitKeeper at mol.bkbits.net?) to work out why it's there - I assume
that's where it's derived from - but it does seem unnecessary.
- Alyssa
On 25/01/16 08:35, Alyssa Milburn wrote: > On Sat, Jan 23, 2016 at 09:40:09PM +0100, Hervé Poussineau wrote: >> It doesn't seem to be used, and operating systems should accept a 'unknown command' answer. > > Mac OS 9 does seem to make the call, but it seems happy getting an 'unknown > command' response; I can't find the original MOL tree (I guess it used to be > in BitKeeper at mol.bkbits.net?) to work out why it's there - I assume > that's where it's derived from - but it does seem unnecessary. Yeah, a lot of the CUDA patches were based upon MOL, i.e. some things aren't explicitly documented in the source but as they appear to work it makes sense to copy the same behaviour in QEMU. The main source tree I used came from the SF project page here: http://sourceforge.net/projects/mac-on-linux/. ATB, Mark.
On Mon, Jan 25, 2016 at 08:48:05AM +0000, Mark Cave-Ayland wrote: > > Mac OS 9 does seem to make the call, but it seems happy getting an 'unknown > > command' response; I can't find the original MOL tree (I guess it used to be > > in BitKeeper at mol.bkbits.net?) to work out why it's there - I assume > > that's where it's derived from - but it does seem unnecessary. > > Yeah, a lot of the CUDA patches were based upon MOL, i.e. some things > aren't explicitly documented in the source but as they appear to work it > makes sense to copy the same behaviour in QEMU. > > The main source tree I used came from the SF project page here: > http://sourceforge.net/projects/mac-on-linux/. Only the "recent" changes are there (it seems the project moved there after a new maintainer took over), unfortunately. It doesn't matter; I was just curious if these changes were justifed somewhere, in case any of the strange "hacks" are actually necessary. - Alyssa
diff --git a/hw/misc/macio/cuda.c b/hw/misc/macio/cuda.c index 49a79fc..d1a7ae2 100644 --- a/hw/misc/macio/cuda.c +++ b/hw/misc/macio/cuda.c @@ -732,9 +732,6 @@ static void cuda_receive_packet(CUDAState *s, } switch(data[0]) { - case CUDA_GET_6805_ADDR: - cuda_send_packet_to_host(s, obuf, 3); - return; case CUDA_COMBINED_FORMAT_IIC: obuf[0] = ERROR_PACKET; obuf[1] = 0x5;
It doesn't seem to be used, and operating systems should accept a 'unknown command' answer. Signed-off-by: Hervé Poussineau <hpoussin@reactos.org> --- hw/misc/macio/cuda.c | 3 --- 1 file changed, 3 deletions(-)