diff mbox

iotests: Limit supported formats for 118

Message ID 1453732976-15655-1-git-send-email-mreitz@redhat.com (mailing list archive)
State New, archived
Headers show

Commit Message

Max Reitz Jan. 25, 2016, 2:42 p.m. UTC
Image formats used in test 118 need to support image creation.

Reported-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Max Reitz <mreitz@redhat.com>
---
 tests/qemu-iotests/118 | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Markus Armbruster Jan. 26, 2016, 7:09 a.m. UTC | #1
Max Reitz <mreitz@redhat.com> writes:

> Image formats used in test 118 need to support image creation.
>
> Reported-by: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
>  tests/qemu-iotests/118 | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tests/qemu-iotests/118 b/tests/qemu-iotests/118
> index 114d0e2..beb69d0 100755
> --- a/tests/qemu-iotests/118
> +++ b/tests/qemu-iotests/118
> @@ -717,4 +717,6 @@ if __name__ == '__main__':
>          # We need floppy and IDE CD-ROM
>          iotests.notrun('not suitable for this machine type: %s' %
>                         iotests.qemu_default_machine)
> -    iotests.main()
> +    # Need to support image creation
> +    iotests.main(supported_fmts=['vpc', 'parallels', 'qcow', 'vdi', 'qcow2',
> +                                 'vmdk', 'raw', 'vhdx', 'qed'])

Reviewed-by: Markus Armbruster <armbru@redhat.com>
Kevin Wolf Jan. 26, 2016, 9:26 a.m. UTC | #2
Am 26.01.2016 um 08:09 hat Markus Armbruster geschrieben:
> Max Reitz <mreitz@redhat.com> writes:
> 
> > Image formats used in test 118 need to support image creation.
> >
> > Reported-by: Markus Armbruster <armbru@redhat.com>
> > Signed-off-by: Max Reitz <mreitz@redhat.com>
> > ---
> >  tests/qemu-iotests/118 | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/tests/qemu-iotests/118 b/tests/qemu-iotests/118
> > index 114d0e2..beb69d0 100755
> > --- a/tests/qemu-iotests/118
> > +++ b/tests/qemu-iotests/118
> > @@ -717,4 +717,6 @@ if __name__ == '__main__':
> >          # We need floppy and IDE CD-ROM
> >          iotests.notrun('not suitable for this machine type: %s' %
> >                         iotests.qemu_default_machine)
> > -    iotests.main()
> > +    # Need to support image creation
> > +    iotests.main(supported_fmts=['vpc', 'parallels', 'qcow', 'vdi', 'qcow2',
> > +                                 'vmdk', 'raw', 'vhdx', 'qed'])
> 
> Reviewed-by: Markus Armbruster <armbru@redhat.com>

Thanks, applied to the block branch.

Kevin
diff mbox

Patch

diff --git a/tests/qemu-iotests/118 b/tests/qemu-iotests/118
index 114d0e2..beb69d0 100755
--- a/tests/qemu-iotests/118
+++ b/tests/qemu-iotests/118
@@ -717,4 +717,6 @@  if __name__ == '__main__':
         # We need floppy and IDE CD-ROM
         iotests.notrun('not suitable for this machine type: %s' %
                        iotests.qemu_default_machine)
-    iotests.main()
+    # Need to support image creation
+    iotests.main(supported_fmts=['vpc', 'parallels', 'qcow', 'vdi', 'qcow2',
+                                 'vmdk', 'raw', 'vhdx', 'qed'])