| Message ID | 1453830771-12036-1-git-send-email-arun.siluvery@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Jan 26, 2016 at 05:52:51PM +0000, Arun Siluvery wrote: > Revision id along with device id is useful in better identification of the HW > and its limitations so include this detail in error state. > > Signed-off-by: Arun Siluvery <arun.siluvery@linux.intel.com> > --- > drivers/gpu/drm/i915/i915_gpu_error.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c > index 7eeb244..f3ddc3b 100644 > --- a/drivers/gpu/drm/i915/i915_gpu_error.c > +++ b/drivers/gpu/drm/i915/i915_gpu_error.c > @@ -365,6 +365,7 @@ int i915_error_state_to_str(struct drm_i915_error_state_buf *m, > err_printf(m, "Reset count: %u\n", error->reset_count); > err_printf(m, "Suspend count: %u\n", error->suspend_count); > err_printf(m, "PCI ID: 0x%04x\n", dev->pdev->device); > + err_printf(m, "Revision: 0x%02x\n", dev->pdev->revision); "PCI revision" maybe? > err_printf(m, "IOMMU enabled?: %d\n", error->iommu); > > if (HAS_CSR(dev)) { > -- > 1.9.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
On 27/01/2016 11:33, Ville Syrjälä wrote: > On Tue, Jan 26, 2016 at 05:52:51PM +0000, Arun Siluvery wrote: >> Revision id along with device id is useful in better identification of the HW >> and its limitations so include this detail in error state. >> >> Signed-off-by: Arun Siluvery <arun.siluvery@linux.intel.com> >> --- >> drivers/gpu/drm/i915/i915_gpu_error.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c >> index 7eeb244..f3ddc3b 100644 >> --- a/drivers/gpu/drm/i915/i915_gpu_error.c >> +++ b/drivers/gpu/drm/i915/i915_gpu_error.c >> @@ -365,6 +365,7 @@ int i915_error_state_to_str(struct drm_i915_error_state_buf *m, >> err_printf(m, "Reset count: %u\n", error->reset_count); >> err_printf(m, "Suspend count: %u\n", error->suspend_count); >> err_printf(m, "PCI ID: 0x%04x\n", dev->pdev->device); >> + err_printf(m, "Revision: 0x%02x\n", dev->pdev->revision); > > "PCI revision" maybe? sure, makes it more clear. regards Arun > >> err_printf(m, "IOMMU enabled?: %d\n", error->iommu); >> >> if (HAS_CSR(dev)) { >> -- >> 1.9.1 >> >> _______________________________________________ >> Intel-gfx mailing list >> Intel-gfx@lists.freedesktop.org >> http://lists.freedesktop.org/mailman/listinfo/intel-gfx >
On Wed, Jan 27, 2016 at 11:44:07AM +0000, Arun Siluvery wrote: > On 27/01/2016 11:33, Ville Syrjälä wrote: > >On Tue, Jan 26, 2016 at 05:52:51PM +0000, Arun Siluvery wrote: > >>Revision id along with device id is useful in better identification of the HW > >>and its limitations so include this detail in error state. > >> > >>Signed-off-by: Arun Siluvery <arun.siluvery@linux.intel.com> > >>--- > >> drivers/gpu/drm/i915/i915_gpu_error.c | 1 + > >> 1 file changed, 1 insertion(+) > >> > >>diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c > >>index 7eeb244..f3ddc3b 100644 > >>--- a/drivers/gpu/drm/i915/i915_gpu_error.c > >>+++ b/drivers/gpu/drm/i915/i915_gpu_error.c > >>@@ -365,6 +365,7 @@ int i915_error_state_to_str(struct drm_i915_error_state_buf *m, > >> err_printf(m, "Reset count: %u\n", error->reset_count); > >> err_printf(m, "Suspend count: %u\n", error->suspend_count); > >> err_printf(m, "PCI ID: 0x%04x\n", dev->pdev->device); > >>+ err_printf(m, "Revision: 0x%02x\n", dev->pdev->revision); > > > >"PCI revision" maybe? > sure, makes it more clear. We also use the subvendor ids, so if we might as well dump the full PCI ID whilst we are making an adjustment here. -Chris
On 29/01/2016 10:27, Patchwork wrote: > == Summary == > > Series 2850v2 drm/i915: Capture revision id in error state > http://patchwork.freedesktop.org/api/1.0/series/2850/revisions/2/mbox/ > > Test kms_flip: > Subgroup basic-flip-vs-dpms: > pass -> DMESG-WARN (ilk-hp8440p) UNSTABLE [BAT ILK] sporadic fifo underruns in igt@kms_flip@basic-flip-vs-* on ilk-hp8440p known issue, https://bugs.freedesktop.org/show_bug.cgi?id=93787 > Test kms_force_connector_basic: > Subgroup prune-stale-modes: > pass -> SKIP (ilk-hp8440p) It is not showing up in patchwork results page. > Test kms_pipe_crc_basic: > Subgroup bad-nb-words-1: > pass -> DMESG-WARN (hsw-gt2) known issue, it is not on P1 list though, https://bugs.freedesktop.org/show_bug.cgi?id=93226 > Subgroup nonblocking-crc-pipe-a: > skip -> PASS (byt-nuc) It is not showing up in patchwork results page, checked detailed results page and it was skipped once before. > Subgroup nonblocking-crc-pipe-b: > pass -> DMESG-WARN (ilk-hp8440p) [BAT ILK] sporadic fifo underruns in igt@kms_flip@basic-flip-vs-* on ilk-hp8440p known issue, https://bugs.freedesktop.org/show_bug.cgi?id=93787 regards Arun > > bdw-nuci7 total:156 pass:147 dwarn:0 dfail:0 fail:0 skip:9 > bdw-ultra total:159 pass:147 dwarn:0 dfail:0 fail:0 skip:12 > bsw-nuc-2 total:159 pass:129 dwarn:0 dfail:0 fail:0 skip:30 > byt-nuc total:159 pass:136 dwarn:0 dfail:0 fail:0 skip:23 > hsw-brixbox total:159 pass:146 dwarn:0 dfail:0 fail:0 skip:13 > hsw-gt2 total:159 pass:148 dwarn:1 dfail:0 fail:0 skip:10 > ilk-hp8440p total:159 pass:108 dwarn:2 dfail:0 fail:0 skip:49 > ivb-t430s total:159 pass:145 dwarn:0 dfail:0 fail:0 skip:14 > skl-i5k-2 total:159 pass:144 dwarn:1 dfail:0 fail:0 skip:14 > snb-dellxps total:159 pass:137 dwarn:0 dfail:0 fail:0 skip:22 > snb-x220t total:159 pass:137 dwarn:0 dfail:0 fail:1 skip:21 > > Results at /archive/results/CI_IGT_test/Patchwork_1313/ > > 5de97b25e5f3c5a63ee243a9d3b22d30792f7d3e drm-intel-nightly: 2016y-01m-29d-07h-32m-09s UTC integration manifest > 76d742df11e81b8fa096b65c5f7864c6237afa6b drm/i915: Capture PCI revision and subsytem details in error state > >
On Fri, Jan 29, 2016 at 11:08:53AM +0000, Arun Siluvery wrote: > On 29/01/2016 10:27, Patchwork wrote: > >== Summary == > > > >Series 2850v2 drm/i915: Capture revision id in error state > >http://patchwork.freedesktop.org/api/1.0/series/2850/revisions/2/mbox/ > > > >Test kms_flip: > > Subgroup basic-flip-vs-dpms: > > pass -> DMESG-WARN (ilk-hp8440p) UNSTABLE > [BAT ILK] sporadic fifo underruns in igt@kms_flip@basic-flip-vs-* on > ilk-hp8440p > known issue, https://bugs.freedesktop.org/show_bug.cgi?id=93787 > > >Test kms_force_connector_basic: > > Subgroup prune-stale-modes: > > pass -> SKIP (ilk-hp8440p) > It is not showing up in patchwork results page. > > >Test kms_pipe_crc_basic: > > Subgroup bad-nb-words-1: > > pass -> DMESG-WARN (hsw-gt2) > known issue, it is not on P1 list though, > https://bugs.freedesktop.org/show_bug.cgi?id=93226 > > > > Subgroup nonblocking-crc-pipe-a: > > skip -> PASS (byt-nuc) > It is not showing up in patchwork results page, checked detailed results > page and it was skipped once before. Yeah, something is broken with the edid injection and seems racy, resulting in corruption and who knows what else. Not sure what's going on, but the overall issue is tracked as P1 in https://bugs.freedesktop.org/show_bug.cgi?id=93769 > > > Subgroup nonblocking-crc-pipe-b: > > pass -> DMESG-WARN (ilk-hp8440p) > [BAT ILK] sporadic fifo underruns in igt@kms_flip@basic-flip-vs-* on > ilk-hp8440p > known issue, https://bugs.freedesktop.org/show_bug.cgi?id=93787 > > regards > Arun > > > > >bdw-nuci7 total:156 pass:147 dwarn:0 dfail:0 fail:0 skip:9 > >bdw-ultra total:159 pass:147 dwarn:0 dfail:0 fail:0 skip:12 > >bsw-nuc-2 total:159 pass:129 dwarn:0 dfail:0 fail:0 skip:30 > >byt-nuc total:159 pass:136 dwarn:0 dfail:0 fail:0 skip:23 > >hsw-brixbox total:159 pass:146 dwarn:0 dfail:0 fail:0 skip:13 > >hsw-gt2 total:159 pass:148 dwarn:1 dfail:0 fail:0 skip:10 > >ilk-hp8440p total:159 pass:108 dwarn:2 dfail:0 fail:0 skip:49 > >ivb-t430s total:159 pass:145 dwarn:0 dfail:0 fail:0 skip:14 > >skl-i5k-2 total:159 pass:144 dwarn:1 dfail:0 fail:0 skip:14 > >snb-dellxps total:159 pass:137 dwarn:0 dfail:0 fail:0 skip:22 > >snb-x220t total:159 pass:137 dwarn:0 dfail:0 fail:1 skip:21 > > > >Results at /archive/results/CI_IGT_test/Patchwork_1313/ > > > >5de97b25e5f3c5a63ee243a9d3b22d30792f7d3e drm-intel-nightly: 2016y-01m-29d-07h-32m-09s UTC integration manifest > >76d742df11e81b8fa096b65c5f7864c6237afa6b drm/i915: Capture PCI revision and subsytem details in error state > > > > > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c index 7eeb244..f3ddc3b 100644 --- a/drivers/gpu/drm/i915/i915_gpu_error.c +++ b/drivers/gpu/drm/i915/i915_gpu_error.c @@ -365,6 +365,7 @@ int i915_error_state_to_str(struct drm_i915_error_state_buf *m, err_printf(m, "Reset count: %u\n", error->reset_count); err_printf(m, "Suspend count: %u\n", error->suspend_count); err_printf(m, "PCI ID: 0x%04x\n", dev->pdev->device); + err_printf(m, "Revision: 0x%02x\n", dev->pdev->revision); err_printf(m, "IOMMU enabled?: %d\n", error->iommu); if (HAS_CSR(dev)) {
Revision id along with device id is useful in better identification of the HW and its limitations so include this detail in error state. Signed-off-by: Arun Siluvery <arun.siluvery@linux.intel.com> --- drivers/gpu/drm/i915/i915_gpu_error.c | 1 + 1 file changed, 1 insertion(+)