diff mbox

[DEBUG] ARM: dts: sh73a0: Add minimal device node for Coresight-ETM

Message ID 1453994509-13318-1-git-send-email-geert+renesas@glider.be (mailing list archive)
State Not Applicable
Delegated to: Simon Horman
Headers show

Commit Message

Geert Uytterhoeven Jan. 28, 2016, 3:21 p.m. UTC
When using a JTAG debugger on an sh73a0-based system, the debugger
looses connection with the hardware during kernel boot-up, as unused
PM Domains are powered down by the genpd core.

To keep on debugging, add a minimal device node for the Coresight-ETM
hardware block, and hook it up to the D4 PM Domain, so the R-Mobile
System Controller driver will keep the domain powered.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Not intended for upstream merge, as the D4 PM Domain is not needed for
normal use.
---
 arch/arm/boot/dts/sh73a0.dtsi | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Sergei Shtylyov Jan. 28, 2016, 3:42 p.m. UTC | #1
Hello.

On 01/28/2016 06:21 PM, Geert Uytterhoeven wrote:

> When using a JTAG debugger on an sh73a0-based system, the debugger
> looses connection with the hardware during kernel boot-up, as unused

    s/looses/loses/.

> PM Domains are powered down by the genpd core.
>
> To keep on debugging, add a minimal device node for the Coresight-ETM
> hardware block, and hook it up to the D4 PM Domain, so the R-Mobile
> System Controller driver will keep the domain powered.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Not intended for upstream merge, as the D4 PM Domain is not needed for
> normal use.
> ---
>   arch/arm/boot/dts/sh73a0.dtsi | 5 +++++
>   1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sh73a0.dtsi b/arch/arm/boot/dts/sh73a0.dtsi
> index 866ee5de09454d14..a6e47611cc807547 100644
> --- a/arch/arm/boot/dts/sh73a0.dtsi
> +++ b/arch/arm/boot/dts/sh73a0.dtsi
> @@ -40,6 +40,11 @@
>   		};
>   	};
>
> +	ptm {

    What's 'ptm'?

> +		compatible = "arm,coresight-etm3x";
> +		power-domains = <&pd_d4>;
> +	};
> +
>   	timer@f0000600 {
>   		compatible = "arm,cortex-a9-twd-timer";
>   		reg = <0xf0000600 0x20>;

MBR, Sergei
Geert Uytterhoeven Jan. 28, 2016, 5:10 p.m. UTC | #2
On Thu, Jan 28, 2016 at 4:42 PM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> On 01/28/2016 06:21 PM, Geert Uytterhoeven wrote:
>
>> When using a JTAG debugger on an sh73a0-based system, the debugger
>> looses connection with the hardware during kernel boot-up, as unused
>
>    s/looses/loses/.

$ dict loose

[...]

From The Collaborative International Dictionary of English v.0.48 [gcide]:

  Loose \Loose\ (l[=oo]s), v. n. [imp. & p. p. {Loosed}
     (l[=oo]st); p. pr. & vb. n. {Loosing}.] [From {Loose}, a.]
     1. To untie or unbind; to free from any fastening; to remove
        the shackles or fastenings of; to set free; to relieve.
        [1913 Webster]

Yeah, there are two verbs, to loose and to lose...

>> --- a/arch/arm/boot/dts/sh73a0.dtsi
>> +++ b/arch/arm/boot/dts/sh73a0.dtsi
>> @@ -40,6 +40,11 @@
>>                 };
>>         };
>>
>> +       ptm {
>
>    What's 'ptm'?

Program Trace Macrocell
(first hit of http://lmgtfy.com/?q=arm+ptm ;-)

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Sergei Shtylyov Jan. 28, 2016, 5:26 p.m. UTC | #3
Hello.

On 01/28/2016 08:10 PM, Geert Uytterhoeven wrote:

>>> When using a JTAG debugger on an sh73a0-based system, the debugger
>>> looses connection with the hardware during kernel boot-up, as unused
>>
>>     s/looses/loses/.
>
> $ dict loose
>
> [...]
>
>  From The Collaborative International Dictionary of English v.0.48 [gcide]:
>
>    Loose \Loose\ (l[=oo]s), v. n. [imp. & p. p. {Loosed}
>       (l[=oo]st); p. pr. & vb. n. {Loosing}.] [From {Loose}, a.]
>       1. To untie or unbind; to free from any fastening; to remove
>          the shackles or fastenings of; to set free; to relieve.
>          [1913 Webster]
>
> Yeah, there are two verbs, to loose and to lose...

    I know, and I was sure you used the wrong one. It's a frequent typo.

>>> --- a/arch/arm/boot/dts/sh73a0.dtsi
>>> +++ b/arch/arm/boot/dts/sh73a0.dtsi
>>> @@ -40,6 +40,11 @@
>>>                  };
>>>          };
>>>
>>> +       ptm {

>>     What's 'ptm'?

> Program Trace Macrocell
> (first hit of http://lmgtfy.com/?q=arm+ptm ;-)

    Thank you for explaining.

> Gr{oetje,eeting}s,
>
>                          Geert

MBR, Sergei
diff mbox

Patch

diff --git a/arch/arm/boot/dts/sh73a0.dtsi b/arch/arm/boot/dts/sh73a0.dtsi
index 866ee5de09454d14..a6e47611cc807547 100644
--- a/arch/arm/boot/dts/sh73a0.dtsi
+++ b/arch/arm/boot/dts/sh73a0.dtsi
@@ -40,6 +40,11 @@ 
 		};
 	};
 
+	ptm {
+		compatible = "arm,coresight-etm3x";
+		power-domains = <&pd_d4>;
+	};
+
 	timer@f0000600 {
 		compatible = "arm,cortex-a9-twd-timer";
 		reg = <0xf0000600 0x20>;