| Message ID | 1304687833-4578-4-git-send-email-leslyam@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
* Lesly A M <leslyam@ti.com> [110506 06:14]:
> Modifying the macro name Main_Ref to all caps(MAIN_REF).
This may get counted as "crazy churn" patch.. Please provide
some reason for doing this in the patch description.
Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Tony, On Thu, May 12, 2011 at 4:12 PM, Tony Lindgren <tony@atomide.com> wrote: > * Lesly A M <leslyam@ti.com> [110506 06:14]: >> Modifying the macro name Main_Ref to all caps(MAIN_REF). > > This may get counted as "crazy churn" patch.. Please provide > some reason for doing this in the patch description. I will update the change logs. Explained in Chapter 12 Documentation/CodingStyle. As per coding-style the macro name should be capitalized. So modifying the macro name Main_Ref to all caps(MAIN_REF). Regards Lesly -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Lesly,
On Fri, May 06, 2011 at 06:47:09PM +0530, Lesly A M wrote:
> Modifying the macro name Main_Ref to all caps(MAIN_REF).
This one is already on my for-next branch. I'll update the Changelog
accordingly.
Cheers,
Samuel.
diff --git a/arch/arm/mach-omap2/board-rx51-peripherals.c b/arch/arm/mach-omap2/board-rx51-peripherals.c index bbcb677..01ee0a1 100644 --- a/arch/arm/mach-omap2/board-rx51-peripherals.c +++ b/arch/arm/mach-omap2/board-rx51-peripherals.c @@ -730,7 +730,7 @@ static struct twl4030_resconfig twl4030_rconfig[] __initdata = { { .resource = RES_RESET, .devgroup = -1, .type = 1, .type2 = -1, .remap_off = -1, .remap_sleep = -1 }, - { .resource = RES_Main_Ref, .devgroup = -1, + { .resource = RES_MAIN_REF, .devgroup = -1, .type = 1, .type2 = -1, .remap_off = -1, .remap_sleep = -1 }, { 0, 0}, diff --git a/drivers/mfd/twl4030-power.c b/drivers/mfd/twl4030-power.c index 12ab2a6..a764676 100644 --- a/drivers/mfd/twl4030-power.c +++ b/drivers/mfd/twl4030-power.c @@ -120,7 +120,7 @@ static u8 res_config_addrs[] = { [RES_HFCLKOUT] = 0x8b, [RES_32KCLKOUT] = 0x8e, [RES_RESET] = 0x91, - [RES_Main_Ref] = 0x94, + [RES_MAIN_REF] = 0x94, }; static int __init twl4030_write_script_byte(u8 address, u8 byte) diff --git a/include/linux/i2c/twl.h b/include/linux/i2c/twl.h index 0c0d1ae..4ebd7c3 100644 --- a/include/linux/i2c/twl.h +++ b/include/linux/i2c/twl.h @@ -501,7 +501,7 @@ static inline int twl6030_mmc_card_detect(struct device *dev, int slot) #define RES_32KCLKOUT 26 #define RES_RESET 27 /* Power Reference */ -#define RES_Main_Ref 28 +#define RES_MAIN_REF 28 #define TOTAL_RESOURCES 28 /*
Modifying the macro name Main_Ref to all caps(MAIN_REF). Suggested by Nishanth Menon <nm@ti.com> Signed-off-by: Lesly A M <leslyam@ti.com> Cc: Nishanth Menon <nm@ti.com> Cc: David Derrick <dderrick@ti.com> Cc: Samuel Ortiz <sameo@linux.intel.com> --- arch/arm/mach-omap2/board-rx51-peripherals.c | 2 +- drivers/mfd/twl4030-power.c | 2 +- include/linux/i2c/twl.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)