| Message ID | 1454066972-3609-2-git-send-email-lorenzo.pieralisi@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
Looks good to me Gab > -----Original Message----- > From: Lorenzo Pieralisi [mailto:lorenzo.pieralisi@arm.com] > Sent: 29 January 2016 11:30 > To: linux-pci@vger.kernel.org > Cc: Lorenzo Pieralisi; Pratyush Anand; Arnd Bergmann; Jingoo Han; Bjorn > Helgaas; Gabriele Paoloni; Wangzhou (B) > Subject: [PATCH 2/2] drivers: pci: host: designware: remove PCI_PROBE_ONLY > handling > > The PCIe designware host driver is not used in system configurations > requiring the PCI_PROBE_ONLY flag to be set to prevent resources > assignment, therefore the driver code handling the flag can be > removed from the kernel. > > Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> > Cc: Pratyush Anand <pratyush.anand@gmail.com> > Cc: Arnd Bergmann <arnd@arndb.de> > Cc: Jingoo Han <jingoohan1@gmail.com> > Cc: Bjorn Helgaas <bhelgaas@google.com> > Cc: Gabriele Paoloni <gabriele.paoloni@huawei.com> > Cc: Zhou Wang <wangzhou1@hisilicon.com> > --- > drivers/pci/host/pcie-designware.c | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie- > designware.c > index 2171682..a445083 100644 > --- a/drivers/pci/host/pcie-designware.c > +++ b/drivers/pci/host/pcie-designware.c > @@ -551,13 +551,11 @@ int dw_pcie_host_init(struct pcie_port *pp) > pci_fixup_irqs(pci_common_swizzle, of_irq_parse_and_map_pci); > #endif > > - if (!pci_has_flag(PCI_PROBE_ONLY)) { > - pci_bus_size_bridges(bus); > - pci_bus_assign_resources(bus); > + pci_bus_size_bridges(bus); > + pci_bus_assign_resources(bus); > > - list_for_each_entry(child, &bus->children, node) > - pcie_bus_configure_settings(child); > - } > + list_for_each_entry(child, &bus->children, node) > + pcie_bus_configure_settings(child); > > pci_bus_add_devices(bus); > return 0; > -- > 2.5.1
On Fri, Jan 29, 2016 at 4:59 PM, Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> wrote: > The PCIe designware host driver is not used in system configurations > requiring the PCI_PROBE_ONLY flag to be set to prevent resources > assignment, therefore the driver code handling the flag can be > removed from the kernel. > > Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> > Cc: Pratyush Anand <pratyush.anand@gmail.com> > Cc: Arnd Bergmann <arnd@arndb.de> > Cc: Jingoo Han <jingoohan1@gmail.com> > Cc: Bjorn Helgaas <bhelgaas@google.com> > Cc: Gabriele Paoloni <gabriele.paoloni@huawei.com> > Cc: Zhou Wang <wangzhou1@hisilicon.com> Acked-by: Pratyush Anand <pratyush.anand@gmail.com> -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Friday, January 29, 2016 8:30 PM, Lorenzo Pieralisi wrote: > > The PCIe designware host driver is not used in system configurations > requiring the PCI_PROBE_ONLY flag to be set to prevent resources > assignment, therefore the driver code handling the flag can be > removed from the kernel. > > Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> > Cc: Pratyush Anand <pratyush.anand@gmail.com> > Cc: Arnd Bergmann <arnd@arndb.de> > Cc: Jingoo Han <jingoohan1@gmail.com> Acked-by: Jingoo Han Jingoo Han <jingoohan1@gmail.com> Best regards, Jingoo Han > Cc: Bjorn Helgaas <bhelgaas@google.com> > Cc: Gabriele Paoloni <gabriele.paoloni@huawei.com> > Cc: Zhou Wang <wangzhou1@hisilicon.com> > --- > drivers/pci/host/pcie-designware.c | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c > index 2171682..a445083 100644 > --- a/drivers/pci/host/pcie-designware.c > +++ b/drivers/pci/host/pcie-designware.c > @@ -551,13 +551,11 @@ int dw_pcie_host_init(struct pcie_port *pp) > pci_fixup_irqs(pci_common_swizzle, of_irq_parse_and_map_pci); > #endif > > - if (!pci_has_flag(PCI_PROBE_ONLY)) { > - pci_bus_size_bridges(bus); > - pci_bus_assign_resources(bus); > + pci_bus_size_bridges(bus); > + pci_bus_assign_resources(bus); > > - list_for_each_entry(child, &bus->children, node) > - pcie_bus_configure_settings(child); > - } > + list_for_each_entry(child, &bus->children, node) > + pcie_bus_configure_settings(child); > > pci_bus_add_devices(bus); > return 0; > -- > 2.5.1 -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Jan 29, 2016 at 11:29:32AM +0000, Lorenzo Pieralisi wrote: > The PCIe designware host driver is not used in system configurations > requiring the PCI_PROBE_ONLY flag to be set to prevent resources > assignment, therefore the driver code handling the flag can be > removed from the kernel. > > Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> > Cc: Pratyush Anand <pratyush.anand@gmail.com> > Cc: Arnd Bergmann <arnd@arndb.de> > Cc: Jingoo Han <jingoohan1@gmail.com> > Cc: Bjorn Helgaas <bhelgaas@google.com> > Cc: Gabriele Paoloni <gabriele.paoloni@huawei.com> > Cc: Zhou Wang <wangzhou1@hisilicon.com> Applied to pci/host-designware for v4.6 with acks from Pratyush and Jingoo, thanks everybody! > --- > drivers/pci/host/pcie-designware.c | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c > index 2171682..a445083 100644 > --- a/drivers/pci/host/pcie-designware.c > +++ b/drivers/pci/host/pcie-designware.c > @@ -551,13 +551,11 @@ int dw_pcie_host_init(struct pcie_port *pp) > pci_fixup_irqs(pci_common_swizzle, of_irq_parse_and_map_pci); > #endif > > - if (!pci_has_flag(PCI_PROBE_ONLY)) { > - pci_bus_size_bridges(bus); > - pci_bus_assign_resources(bus); > + pci_bus_size_bridges(bus); > + pci_bus_assign_resources(bus); > > - list_for_each_entry(child, &bus->children, node) > - pcie_bus_configure_settings(child); > - } > + list_for_each_entry(child, &bus->children, node) > + pcie_bus_configure_settings(child); > > pci_bus_add_devices(bus); > return 0; > -- > 2.5.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-pci" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c index 2171682..a445083 100644 --- a/drivers/pci/host/pcie-designware.c +++ b/drivers/pci/host/pcie-designware.c @@ -551,13 +551,11 @@ int dw_pcie_host_init(struct pcie_port *pp) pci_fixup_irqs(pci_common_swizzle, of_irq_parse_and_map_pci); #endif - if (!pci_has_flag(PCI_PROBE_ONLY)) { - pci_bus_size_bridges(bus); - pci_bus_assign_resources(bus); + pci_bus_size_bridges(bus); + pci_bus_assign_resources(bus); - list_for_each_entry(child, &bus->children, node) - pcie_bus_configure_settings(child); - } + list_for_each_entry(child, &bus->children, node) + pcie_bus_configure_settings(child); pci_bus_add_devices(bus); return 0;
The PCIe designware host driver is not used in system configurations requiring the PCI_PROBE_ONLY flag to be set to prevent resources assignment, therefore the driver code handling the flag can be removed from the kernel. Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> Cc: Pratyush Anand <pratyush.anand@gmail.com> Cc: Arnd Bergmann <arnd@arndb.de> Cc: Jingoo Han <jingoohan1@gmail.com> Cc: Bjorn Helgaas <bhelgaas@google.com> Cc: Gabriele Paoloni <gabriele.paoloni@huawei.com> Cc: Zhou Wang <wangzhou1@hisilicon.com> --- drivers/pci/host/pcie-designware.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-)