| Message ID | 20160209011303.23099.40721.stgit@birch.djwong.org (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
On Mon, Feb 08, 2016 at 05:13:03PM -0800, Darrick J. Wong wrote: > Include the refcount and rmap structures in the golden output. > > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com> > --- > tests/xfs/122 | 3 +++ > tests/xfs/122.out | 4 ++++ > tests/xfs/group | 2 +- > 3 files changed, 8 insertions(+), 1 deletion(-) > > > diff --git a/tests/xfs/122 b/tests/xfs/122 > index e6697a2..758cb50 100755 > --- a/tests/xfs/122 > +++ b/tests/xfs/122 > @@ -90,6 +90,9 @@ xfs_da3_icnode_hdr > xfs_dir3_icfree_hdr > xfs_dir3_icleaf_hdr > xfs_name > +xfs_owner_info > +xfs_refcount_irec > +xfs_rmap_irec > xfs_alloctype_t > xfs_buf_cancel_t > xfs_bmbt_rec_32_t So this is going to cause failures on any userspace that doesn't know about these new types, right? Should these be conditional in some way? Cheers, Dave.
On Tue, Feb 09, 2016 at 06:43:30PM +1100, Dave Chinner wrote: > On Mon, Feb 08, 2016 at 05:13:03PM -0800, Darrick J. Wong wrote: > > Include the refcount and rmap structures in the golden output. > > > > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com> > > --- > > tests/xfs/122 | 3 +++ > > tests/xfs/122.out | 4 ++++ > > tests/xfs/group | 2 +- > > 3 files changed, 8 insertions(+), 1 deletion(-) > > > > > > diff --git a/tests/xfs/122 b/tests/xfs/122 > > index e6697a2..758cb50 100755 > > --- a/tests/xfs/122 > > +++ b/tests/xfs/122 > > @@ -90,6 +90,9 @@ xfs_da3_icnode_hdr > > xfs_dir3_icfree_hdr > > xfs_dir3_icleaf_hdr > > xfs_name > > +xfs_owner_info > > +xfs_refcount_irec > > +xfs_rmap_irec > > xfs_alloctype_t > > xfs_buf_cancel_t > > xfs_bmbt_rec_32_t > > So this is going to cause failures on any userspace that doesn't > know about these new types, right? > > Should these be conditional in some way? I wasn't sure how to handle this -- I could just keep the patch at the head of my stack (unreleased) until xfsprogs pulls in the appropriate libxfs pieces? So long as we're not dead certain of the final format of the rmapbt and refcountbt, there's probably not a lot of value in putting this in (yet). --D > > Cheers, > > Dave. > > -- > Dave Chinner > david@fromorbit.com > -- > To unsubscribe from this list: send the line "unsubscribe fstests" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Feb 08, 2016 at 11:55:06PM -0800, Darrick J. Wong wrote: > On Tue, Feb 09, 2016 at 06:43:30PM +1100, Dave Chinner wrote: > > On Mon, Feb 08, 2016 at 05:13:03PM -0800, Darrick J. Wong wrote: > > > Include the refcount and rmap structures in the golden output. > > > > > > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com> > > > --- > > > tests/xfs/122 | 3 +++ > > > tests/xfs/122.out | 4 ++++ > > > tests/xfs/group | 2 +- > > > 3 files changed, 8 insertions(+), 1 deletion(-) > > > > > > > > > diff --git a/tests/xfs/122 b/tests/xfs/122 > > > index e6697a2..758cb50 100755 > > > --- a/tests/xfs/122 > > > +++ b/tests/xfs/122 > > > @@ -90,6 +90,9 @@ xfs_da3_icnode_hdr > > > xfs_dir3_icfree_hdr > > > xfs_dir3_icleaf_hdr > > > xfs_name > > > +xfs_owner_info > > > +xfs_refcount_irec > > > +xfs_rmap_irec > > > xfs_alloctype_t > > > xfs_buf_cancel_t > > > xfs_bmbt_rec_32_t > > > > So this is going to cause failures on any userspace that doesn't > > know about these new types, right? > > > > Should these be conditional in some way? > > I wasn't sure how to handle this -- I could just keep the patch at the head of > my stack (unreleased) until xfsprogs pulls in the appropriate libxfs pieces? > So long as we're not dead certain of the final format of the rmapbt and > refcountbt, there's probably not a lot of value in putting this in (yet). Well, I'm more concerned about running on older/current distros that don't have support for them in userspace. My brain is mush right now, so I don't have any brilliant ideas (hence the question, rather than also presenting a posible solution). I'll have a think; maybe we can make use of the configurable .out file code we have now? Cheers, Dave.
diff --git a/tests/xfs/122 b/tests/xfs/122 index e6697a2..758cb50 100755 --- a/tests/xfs/122 +++ b/tests/xfs/122 @@ -90,6 +90,9 @@ xfs_da3_icnode_hdr xfs_dir3_icfree_hdr xfs_dir3_icleaf_hdr xfs_name +xfs_owner_info +xfs_refcount_irec +xfs_rmap_irec xfs_alloctype_t xfs_buf_cancel_t xfs_bmbt_rec_32_t diff --git a/tests/xfs/122.out b/tests/xfs/122.out index 8ba121e..c590166 100644 --- a/tests/xfs/122.out +++ b/tests/xfs/122.out @@ -75,6 +75,10 @@ sizeof(struct xfs_extent_data) = 24 sizeof(struct xfs_extent_data_info) = 32 sizeof(struct xfs_fs_eofblocks) = 128 sizeof(struct xfs_icreate_log) = 28 +sizeof(struct xfs_refcount_key) = 4 +sizeof(struct xfs_refcount_rec) = 12 +sizeof(struct xfs_rmap_key) = 20 +sizeof(struct xfs_rmap_rec) = 24 sizeof(xfs_agf_t) = 224 sizeof(xfs_agfl_t) = 36 sizeof(xfs_agi_t) = 336 diff --git a/tests/xfs/group b/tests/xfs/group index f0c1c2b..abf1d33 100644 --- a/tests/xfs/group +++ b/tests/xfs/group @@ -119,7 +119,7 @@ 119 log v2log auto freeze dangerous 120 fuzzers 121 log auto quick -122 other auto quick +122 other auto quick clone 123 fuzzers 124 fuzzers 125 fuzzers
Include the refcount and rmap structures in the golden output. Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com> --- tests/xfs/122 | 3 +++ tests/xfs/122.out | 4 ++++ tests/xfs/group | 2 +- 3 files changed, 8 insertions(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html