diff mbox

block: Initialize max_dev_sectors to 0

Message ID 1455148367-25208-1-git-send-email-keith.busch@intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Keith Busch Feb. 10, 2016, 11:52 p.m. UTC 
The new queue limit is not used by the majority of block drivers, and
should be initialized to 0 for the driver's requested settings to be used.

Signed-off-by: Keith Busch <keith.busch@intel.com>
Cc: Christoph Hellwig <hch@infradead.org>
Acked-by: Martin K. Petersen <martin.petersen@oracle.com>
---
 block/blk-settings.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Sagi Grimberg Feb. 11, 2016, 1:01 p.m. UTC | #1 
Looks good,

Reviewed-by: Sagi Grimberg <sagig@mellanox.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-block" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Christoph Hellwig Feb. 11, 2016, 3:20 p.m. UTC | #2 
On Wed, Feb 10, 2016 at 04:52:47PM -0700, Keith Busch wrote:
> The new queue limit is not used by the majority of block drivers, and
> should be initialized to 0 for the driver's requested settings to be used.
> 
> Signed-off-by: Keith Busch <keith.busch@intel.com>
> Cc: Christoph Hellwig <hch@infradead.org>
> Acked-by: Martin K. Petersen <martin.petersen@oracle.com>

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>
--
To unsubscribe from this list: send the line "unsubscribe linux-block" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jens Axboe Feb. 11, 2016, 3:21 p.m. UTC | #3 
On 02/10/2016 04:52 PM, Keith Busch wrote:
> The new queue limit is not used by the majority of block drivers, and
> should be initialized to 0 for the driver's requested settings to be used.

That's much better, thanks.
Christoph Hellwig March 1, 2016, 3:19 p.m. UTC | #4 
On Thu, Feb 11, 2016 at 08:21:24AM -0700, Jens Axboe wrote:
> On 02/10/2016 04:52 PM, Keith Busch wrote:
> >The new queue limit is not used by the majority of block drivers, and
> >should be initialized to 0 for the driver's requested settings to be used.
> 
> That's much better, thanks.

Btw, I think we also needs this for 4.4-stable, especially as it's
going to be a long term release.
--
To unsubscribe from this list: send the line "unsubscribe linux-block" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keith Busch March 2, 2016, 10:42 p.m. UTC | #5 
On Tue, Mar 01, 2016 at 07:19:51AM -0800, Christoph Hellwig wrote:
> Btw, I think we also needs this for 4.4-stable, especially as it's
> going to be a long term release.

Agreed, I even received bug reports this week for this issue from
folks using 4.4-stable at the NVMe plugfest. I posted this patch to the
stable list.
--
To unsubscribe from this list: send the line "unsubscribe linux-block" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/block/blk-settings.c b/block/blk-settings.c
index dd49735..c7bb666 100644
--- a/block/blk-settings.c
+++ b/block/blk-settings.c
@@ -91,8 +91,8 @@  void blk_set_default_limits(struct queue_limits *lim)
 	lim->seg_boundary_mask = BLK_SEG_BOUNDARY_MASK;
 	lim->virt_boundary_mask = 0;
 	lim->max_segment_size = BLK_MAX_SEGMENT_SIZE;
-	lim->max_sectors = lim->max_dev_sectors = lim->max_hw_sectors =
-		BLK_SAFE_MAX_SECTORS;
+	lim->max_sectors = lim->max_hw_sectors = BLK_SAFE_MAX_SECTORS;
+	lim->max_dev_sectors = 0;
 	lim->chunk_sectors = 0;
 	lim->max_write_same_sectors = 0;
 	lim->max_discard_sectors = 0;