| Message ID | 1452655854-1528-5-git-send-email-wens@csie.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Jan 13, 2016 at 4:30 AM, Chen-Yu Tsai <wens@csie.org> wrote: > When the driver was merged, the original author did not include a proper > copyright notice. This patch adds the notice, backdated to when the > driver was merged. > > Cc: Carlo Caione <carlo@caione.org> > Signed-off-by: Chen-Yu Tsai <wens@csie.org> > --- Acked-by: Carlo Caione <carlo@caione.org> Thanks!
On Wed, 13 Jan 2016, Chen-Yu Tsai wrote: > When the driver was merged, the original author did not include a proper > copyright notice. This patch adds the notice, backdated to when the > driver was merged. This is very wordy. "Supply a backdated copyright notice." > Cc: Carlo Caione <carlo@caione.org> > Signed-off-by: Chen-Yu Tsai <wens@csie.org> > --- > > New patch in v7. > > --- > drivers/mfd/axp20x.c | 2 ++ > 1 file changed, 2 insertions(+) Patch looks fine though: Acked-by: Lee Jones <lee.jones@linaro.org> > diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c > index 3e186f2dcac3..cec51e689d1d 100644 > --- a/drivers/mfd/axp20x.c > +++ b/drivers/mfd/axp20x.c > @@ -5,6 +5,8 @@ > * converters, LDOs, multiple 12-bit ADCs of voltage, current and temperature > * as well as configurable GPIOs. > * > + * Copyright (C) 2014 Carlo Caione > + * > * Author: Carlo Caione <carlo@caione.org> > * > * This program is free software; you can redistribute it and/or modify
Hi Lee, On Mon, Jan 25, 2016 at 02:39:57PM +0000, Lee Jones wrote: > On Wed, 13 Jan 2016, Chen-Yu Tsai wrote: > > > When the driver was merged, the original author did not include a proper > > copyright notice. This patch adds the notice, backdated to when the > > driver was merged. > > This is very wordy. > > "Supply a backdated copyright notice." > > > Cc: Carlo Caione <carlo@caione.org> > > Signed-off-by: Chen-Yu Tsai <wens@csie.org> > > --- > > > > New patch in v7. > > > > --- > > drivers/mfd/axp20x.c | 2 ++ > > 1 file changed, 2 insertions(+) > > Patch looks fine though: > > Acked-by: Lee Jones <lee.jones@linaro.org> How do you want to merge these patches ? AFAIK, it's mostly MFD patches that could go through your tree, so feel free to apply them, I'll apply the DT parts. Thanks! Maxime
On Mon, Jan 25, 2016 at 10:39 PM, Lee Jones <lee.jones@linaro.org> wrote: > On Wed, 13 Jan 2016, Chen-Yu Tsai wrote: > >> When the driver was merged, the original author did not include a proper >> copyright notice. This patch adds the notice, backdated to when the >> driver was merged. > > This is very wordy. > > "Supply a backdated copyright notice." Fine with me. Would you like me to send another version? ChenYu >> Cc: Carlo Caione <carlo@caione.org> >> Signed-off-by: Chen-Yu Tsai <wens@csie.org> >> --- >> >> New patch in v7. >> >> --- >> drivers/mfd/axp20x.c | 2 ++ >> 1 file changed, 2 insertions(+) > > Patch looks fine though: > > Acked-by: Lee Jones <lee.jones@linaro.org> > >> diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c >> index 3e186f2dcac3..cec51e689d1d 100644 >> --- a/drivers/mfd/axp20x.c >> +++ b/drivers/mfd/axp20x.c >> @@ -5,6 +5,8 @@ >> * converters, LDOs, multiple 12-bit ADCs of voltage, current and temperature >> * as well as configurable GPIOs. >> * >> + * Copyright (C) 2014 Carlo Caione >> + * >> * Author: Carlo Caione <carlo@caione.org> >> * >> * This program is free software; you can redistribute it and/or modify > > -- > Lee Jones > Linaro STMicroelectronics Landing Team Lead > Linaro.org ? Open source software for ARM SoCs > Follow Linaro: Facebook | Twitter | Blog
On Tue, 26 Jan 2016, Chen-Yu Tsai wrote: > On Mon, Jan 25, 2016 at 10:39 PM, Lee Jones <lee.jones@linaro.org> wrote: > > On Wed, 13 Jan 2016, Chen-Yu Tsai wrote: > > > >> When the driver was merged, the original author did not include a proper > >> copyright notice. This patch adds the notice, backdated to when the > >> driver was merged. > > > > This is very wordy. > > > > "Supply a backdated copyright notice." > > Fine with me. Would you like me to send another version? No, I will fix this for you. > >> Cc: Carlo Caione <carlo@caione.org> > >> Signed-off-by: Chen-Yu Tsai <wens@csie.org> > >> --- > >> > >> New patch in v7. > >> > >> --- > >> drivers/mfd/axp20x.c | 2 ++ > >> 1 file changed, 2 insertions(+) > > > > Patch looks fine though: > > > > Acked-by: Lee Jones <lee.jones@linaro.org> > > > >> diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c > >> index 3e186f2dcac3..cec51e689d1d 100644 > >> --- a/drivers/mfd/axp20x.c > >> +++ b/drivers/mfd/axp20x.c > >> @@ -5,6 +5,8 @@ > >> * converters, LDOs, multiple 12-bit ADCs of voltage, current and temperature > >> * as well as configurable GPIOs. > >> * > >> + * Copyright (C) 2014 Carlo Caione > >> + * > >> * Author: Carlo Caione <carlo@caione.org> > >> * > >> * This program is free software; you can redistribute it and/or modify > >
On Mon, 25 Jan 2016, Maxime Ripard wrote: > On Mon, Jan 25, 2016 at 02:39:57PM +0000, Lee Jones wrote: > > On Wed, 13 Jan 2016, Chen-Yu Tsai wrote: > > > > > When the driver was merged, the original author did not include a proper > > > copyright notice. This patch adds the notice, backdated to when the > > > driver was merged. > > > > This is very wordy. > > > > "Supply a backdated copyright notice." > > > > > Cc: Carlo Caione <carlo@caione.org> > > > Signed-off-by: Chen-Yu Tsai <wens@csie.org> > > > --- > > > > > > New patch in v7. > > > > > > --- > > > drivers/mfd/axp20x.c | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > Patch looks fine though: > > > > Acked-by: Lee Jones <lee.jones@linaro.org> > > How do you want to merge these patches ? > > AFAIK, it's mostly MFD patches that could go through your tree, so > feel free to apply them, I'll apply the DT parts. Apologies for the delay, I've been super busy. Yes, please take the ARM patches, I'll take the rest.
On Mon, 25 Jan 2016, Lee Jones wrote: > On Wed, 13 Jan 2016, Chen-Yu Tsai wrote: > > > When the driver was merged, the original author did not include a proper > > copyright notice. This patch adds the notice, backdated to when the > > driver was merged. > > This is very wordy. > > "Supply a backdated copyright notice." Can you re-submit this set with this fixed and the Acks you collected?
On Thu, Feb 11, 2016 at 11:24 PM, Lee Jones <lee.jones@linaro.org> wrote: > On Mon, 25 Jan 2016, Lee Jones wrote: > >> On Wed, 13 Jan 2016, Chen-Yu Tsai wrote: >> >> > When the driver was merged, the original author did not include a proper >> > copyright notice. This patch adds the notice, backdated to when the >> > driver was merged. >> >> This is very wordy. >> >> "Supply a backdated copyright notice." > > Can you re-submit this set with this fixed and the Acks you collected? Just did. Hopefully you'll see it in your inbox, and not your spam folder. Thanks ChenYu
diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c index 3e186f2dcac3..cec51e689d1d 100644 --- a/drivers/mfd/axp20x.c +++ b/drivers/mfd/axp20x.c @@ -5,6 +5,8 @@ * converters, LDOs, multiple 12-bit ADCs of voltage, current and temperature * as well as configurable GPIOs. * + * Copyright (C) 2014 Carlo Caione + * * Author: Carlo Caione <carlo@caione.org> * * This program is free software; you can redistribute it and/or modify
When the driver was merged, the original author did not include a proper copyright notice. This patch adds the notice, backdated to when the driver was merged. Cc: Carlo Caione <carlo@caione.org> Signed-off-by: Chen-Yu Tsai <wens@csie.org> --- New patch in v7. --- drivers/mfd/axp20x.c | 2 ++ 1 file changed, 2 insertions(+)