| Message ID | 1453760661-1444-2-git-send-email-richard@nod.at (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On 25/01/16 14:24, Richard Weinberger wrote: > Not every arch has io memory. > So, unbreak the build by fixing the dependencies. > > Signed-off-by: Richard Weinberger <richard@nod.at> > --- > drivers/power/reset/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/power/reset/Kconfig b/drivers/power/reset/Kconfig > index 1131cf7..0a6408a 100644 > --- a/drivers/power/reset/Kconfig > +++ b/drivers/power/reset/Kconfig > @@ -148,6 +148,7 @@ config POWER_RESET_KEYSTONE > config POWER_RESET_SYSCON > bool "Generic SYSCON regmap reset driver" > depends on OF > + depends on HAS_IOMEM > select MFD_SYSCON Should this dependency go into REGMAP_MMIO instead? MFD_SYSCON in itself does not issue I/O accesses per-se, but does use helpers from regmap, which in turn do it. > help > Reboot support for generic SYSCON mapped register reset. > @@ -155,6 +156,7 @@ config POWER_RESET_SYSCON > config POWER_RESET_SYSCON_POWEROFF > bool "Generic SYSCON regmap poweroff driver" > depends on OF > + depends on HAS_IOMEM > select MFD_SYSCON Likewise.
Am 27.01.2016 um 00:34 schrieb Florian Fainelli: > On 25/01/16 14:24, Richard Weinberger wrote: >> Not every arch has io memory. >> So, unbreak the build by fixing the dependencies. >> >> Signed-off-by: Richard Weinberger <richard@nod.at> >> --- >> drivers/power/reset/Kconfig | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/power/reset/Kconfig b/drivers/power/reset/Kconfig >> index 1131cf7..0a6408a 100644 >> --- a/drivers/power/reset/Kconfig >> +++ b/drivers/power/reset/Kconfig >> @@ -148,6 +148,7 @@ config POWER_RESET_KEYSTONE >> config POWER_RESET_SYSCON >> bool "Generic SYSCON regmap reset driver" >> depends on OF >> + depends on HAS_IOMEM >> select MFD_SYSCON > > Should this dependency go into REGMAP_MMIO instead? MFD_SYSCON in itself > does not issue I/O accesses per-se, but does use helpers from regmap, > which in turn do it. Hmmm, AFAICT this would not work as REGMAP_MMIO is not user visible and directly enabled via "select" instead of "depends on". Hence, dependencies are ignored. Thanks, //richard -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, On Mon, Jan 25, 2016 at 11:24:00PM +0100, Richard Weinberger wrote: > Not every arch has io memory. > So, unbreak the build by fixing the dependencies. Thanks, queued. -- Sebastian
diff --git a/drivers/power/reset/Kconfig b/drivers/power/reset/Kconfig index 1131cf7..0a6408a 100644 --- a/drivers/power/reset/Kconfig +++ b/drivers/power/reset/Kconfig @@ -148,6 +148,7 @@ config POWER_RESET_KEYSTONE config POWER_RESET_SYSCON bool "Generic SYSCON regmap reset driver" depends on OF + depends on HAS_IOMEM select MFD_SYSCON help Reboot support for generic SYSCON mapped register reset. @@ -155,6 +156,7 @@ config POWER_RESET_SYSCON config POWER_RESET_SYSCON_POWEROFF bool "Generic SYSCON regmap poweroff driver" depends on OF + depends on HAS_IOMEM select MFD_SYSCON help Poweroff support for generic SYSCON mapped register poweroff.
Not every arch has io memory. So, unbreak the build by fixing the dependencies. Signed-off-by: Richard Weinberger <richard@nod.at> --- drivers/power/reset/Kconfig | 2 ++ 1 file changed, 2 insertions(+)