| Message ID | 20160215204614.7977.2848.stgit@birch.djwong.org (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
On Mon, Feb 15, 2016 at 12:46:14PM -0800, Darrick J. Wong wrote: > "Invalid argument" is a better response to an impossibly high offset > dedupe request than "extents don't match", so change the test. What does btrfs return here? -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Feb 17, 2016 at 9:56 AM, Christoph Hellwig <hch@infradead.org> wrote: > On Mon, Feb 15, 2016 at 12:46:14PM -0800, Darrick J. Wong wrote: >> "Invalid argument" is a better response to an impossibly high offset >> dedupe request than "extents don't match", so change the test. > > What does btrfs return here? -EINVAL, so this makes the test pass on btrfs. > -- > To unsubscribe from this list: send the line "unsubscribe fstests" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Feb 17, 2016 at 10:04:23AM +0000, Filipe Manana wrote: > > What does btrfs return here? > > -EINVAL, so this makes the test pass on btrfs. Ok, looks fine to me then: Reviewed-by: Christoph Hellwig <hch@lst.de> -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/tests/generic/304.out b/tests/generic/304.out index 4af2a39..7b5ff0e 100644 --- a/tests/generic/304.out +++ b/tests/generic/304.out @@ -8,7 +8,7 @@ dedupe: Invalid argument Dedupe past maximum file size in dest file (should fail) dedupe: Invalid argument Dedupe high offset to low offset -dedupe: Extents did not match. +dedupe: Invalid argument Dedupe past source file EOF (should fail) dedupe: Invalid argument Dedupe max size at nonzero offset (should fail)
"Invalid argument" is a better response to an impossibly high offset dedupe request than "extents don't match", so change the test. Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com> --- tests/generic/304.out | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html