| Message ID | AANLkTinT9oPT9ob3W6pzuvbxr502gAC5N02TOLGr_pLC@mail.gmail.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
On 18/01/2011 15:42, Tomer Barletz wrote: > Attached a patch for a bug in the lookup_callback function, were in > case of a non-existent resource, the connected_resource_id is not > initialized and then used in the open_session_response call of the > session layer. > Hello Can you explain what kind of bug it fixes ? Thanks -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, May 17, 2011 at 8:46 AM, Brice DUBOST <braice@braice.net> wrote: > On 18/01/2011 15:42, Tomer Barletz wrote: >> Attached a patch for a bug in the lookup_callback function, were in >> case of a non-existent resource, the connected_resource_id is not >> initialized and then used in the open_session_response call of the >> session layer. >> > > Hello > > Can you explain what kind of bug it fixes ? > > Thanks > The standard states that in case the module can't provide the requested resource , it should reply with the same resource id - this is the only line that was added. Also, since the caller to this function might use the variable returned, this variable must be initialized. The attached patch solves both bugs. Tomer -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 05/18/2011 09:16 PM, Tomer Barletz wrote: > On Tue, May 17, 2011 at 8:46 AM, Brice DUBOST <braice@braice.net> wrote: >> On 18/01/2011 15:42, Tomer Barletz wrote: >>> Attached a patch for a bug in the lookup_callback function, were in >>> case of a non-existent resource, the connected_resource_id is not >>> initialized and then used in the open_session_response call of the >>> session layer. >>> >> >> Hello >> >> Can you explain what kind of bug it fixes ? >> >> Thanks >> > > The standard states that in case the module can't provide the > requested resource , it should reply with the same resource id - this > is the only line that was added. > Also, since the caller to this function might use the variable > returned, this variable must be initialized. > The attached patch solves both bugs. Can you please resend the patch inline with a proper signed-off-by line, in order to get it tracked by patchwork.kernel.org? Regards, Andreas -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
> -----Original Message----- > From: linux-media-owner@vger.kernel.org [mailto:linux-media- > owner@vger.kernel.org] On Behalf Of Andreas Oberritter > Sent: jeudi 19 mai 2011 14:58 > To: Tomer Barletz > Cc: Brice DUBOST; linux-media@vger.kernel.org > Subject: Re: [libdvben50221] [PATCH] Assign same resource_id in > open_session_response when "resource non-existent" > > On 05/18/2011 09:16 PM, Tomer Barletz wrote: > > On Tue, May 17, 2011 at 8:46 AM, Brice DUBOST <braice@braice.net> > wrote: > >> On 18/01/2011 15:42, Tomer Barletz wrote: > >>> Attached a patch for a bug in the lookup_callback function, were in > >>> case of a non-existent resource, the connected_resource_id is not > >>> initialized and then used in the open_session_response call of the > >>> session layer. > >>> > >> > >> Hello > >> > >> Can you explain what kind of bug it fixes ? > >> > >> Thanks > >> > > > > The standard states that in case the module can't provide the > > requested resource , it should reply with the same resource id - this > > is the only line that was added. > > Also, since the caller to this function might use the variable > > returned, this variable must be initialized. > > The attached patch solves both bugs. > > Can you please resend the patch inline with a proper signed-off-by line, > in order to get it tracked by patchwork.kernel.org? > Yes, of course, but I don't find information that can help me to provide the correct format. Is-there a documentation somewhere that explains how patches must be formatted to be correctly tracked? > Regards, > Andreas > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" > in the body of a message to majordomo@vger.kernel.org More majordomo > info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 19/05/11 23:01, Sébastien RAILLARD (COEXSI) wrote: > > Yes, of course, but I don't find information that can help me to provide the > correct format. > Is-there a documentation somewhere that explains how patches must be > formatted to be correctly tracked? This should help [http://www.linuxtv.org/wiki/index.php/Development:_How_to_submit_patches] -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff -r d3509d6e9499 lib/libdvben50221/en50221_stdcam_llci.c --- a/lib/libdvben50221/en50221_stdcam_llci.c Sat Aug 08 19:17:21 2009 +0200 +++ b/lib/libdvben50221/en50221_stdcam_llci.c Tue Jan 18 14:51:34 2011 +0200 @@ -351,6 +351,10 @@ } } + /* In case the reousrce does not exist, return the same id in the response. + See 7.2.6.2 */ + *connected_resource_id = requested_resource_id; + return -1; }