| Message ID | 1455673992-16469-4-git-send-email-jay.xu@rock-chips.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Feb 17, 2016 at 09:53:09AM +0800, jianqun.xu wrote: > --- > Documentation/devicetree/bindings/sound/rockchip-i2s.txt | 1 + > 1 file changed, 1 insertion(+) As with the other patch I'd expect to see a matching driver update if only for documentation purposes.
On Wed, Feb 17, 2016 at 09:53:09AM +0800, jianqun.xu wrote: > From: Xu Jianqun <jay.xu@rock-chips.com> > > Add devicetree bindings for i2s controller found on rk3399 > processors from rockchip. > > Signed-off-by: Xu Jianqun <jay.xu@rock-chips.com> > --- > Documentation/devicetree/bindings/sound/rockchip-i2s.txt | 1 + > 1 file changed, 1 insertion(+) Acked-by: Rob Herring <robh@kernel.org>
On Wed, Feb 17, 2016 at 11:03:06AM +0000, Mark Brown wrote: > On Wed, Feb 17, 2016 at 09:53:09AM +0800, jianqun.xu wrote: > > > --- > > Documentation/devicetree/bindings/sound/rockchip-i2s.txt | 1 + > > 1 file changed, 1 insertion(+) > > As with the other patch I'd expect to see a matching driver update if > only for documentation purposes. Why? They match on the prior chip's compatible until there is some difference the driver needs to handle. Rob
On Thu, Feb 18, 2016 at 08:37:02AM -0600, Rob Herring wrote: > On Wed, Feb 17, 2016 at 11:03:06AM +0000, Mark Brown wrote: > > As with the other patch I'd expect to see a matching driver update if > > only for documentation purposes. > Why? They match on the prior chip's compatible until there is some > difference the driver needs to handle. That then requires anyone using a compatible string to also know the full set of other compatible strings that can be used for this device and that they have to list the others too in the correct order which isn't something the binding document tells them. It also feels better to record in the code how we think we should support the device when we know it, seems more helpful.
diff --git a/Documentation/devicetree/bindings/sound/rockchip-i2s.txt b/Documentation/devicetree/bindings/sound/rockchip-i2s.txt index b7f3a93..6e86d8a 100644 --- a/Documentation/devicetree/bindings/sound/rockchip-i2s.txt +++ b/Documentation/devicetree/bindings/sound/rockchip-i2s.txt @@ -9,6 +9,7 @@ Required properties: - "rockchip,rk3066-i2s": for rk3066 - "rockchip,rk3188-i2s", "rockchip,rk3066-i2s": for rk3188 - "rockchip,rk3288-i2s", "rockchip,rk3066-i2s": for rk3288 + - "rockchip,rk3399-i2s", "rockchip,rk3066-i2s": for rk3399 - reg: physical base address of the controller and length of memory mapped region. - interrupts: should contain the I2S interrupt.