| Message ID | 1455819551-4666-3-git-send-email-javier@osg.samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 19.02.2016 03:19, Javier Martinez Canillas wrote: > The Exynos TMU DT binding says that the vtmu-supply is optional but the > driver uses devm_regulator_get() that creates a dummy regulator if it's > not defined in the DT. For example the following message is in the log: > > 10060000.tmu supply vtmu not found, using dummy regulator > > Use the optional version of regulator_get() that doesn't create a dummy > regulator and instead returns a -ENODEV errno code. Since it's expected > that a regulator may not be defined and the driver will inform about it: > > exynos-tmu 10060000.tmu: Regulator node (vtmu) not found > > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> > --- > > drivers/thermal/samsung/exynos_tmu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Best regards, Krzysztof
diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c index 6c6f59ba7423..f4f36bba7be9 100644 --- a/drivers/thermal/samsung/exynos_tmu.c +++ b/drivers/thermal/samsung/exynos_tmu.c @@ -1310,7 +1310,7 @@ static int exynos_tmu_probe(struct platform_device *pdev) * TODO: Add regulator as an SOC feature, so that regulator enable * is a compulsory call. */ - data->regulator = devm_regulator_get(&pdev->dev, "vtmu"); + data->regulator = devm_regulator_get_optional(&pdev->dev, "vtmu"); if (!IS_ERR(data->regulator)) { ret = regulator_enable(data->regulator); if (ret) {
The Exynos TMU DT binding says that the vtmu-supply is optional but the driver uses devm_regulator_get() that creates a dummy regulator if it's not defined in the DT. For example the following message is in the log: 10060000.tmu supply vtmu not found, using dummy regulator Use the optional version of regulator_get() that doesn't create a dummy regulator and instead returns a -ENODEV errno code. Since it's expected that a regulator may not be defined and the driver will inform about it: exynos-tmu 10060000.tmu: Regulator node (vtmu) not found Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> --- drivers/thermal/samsung/exynos_tmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)