| Message ID | 1455689899-31227-1-git-send-email-famz@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 02/17/2016 07:18 AM, Fam Zheng wrote: > Signed-off-by: Fam Zheng <famz@redhat.com> > --- > scripts/kvm/kvm_stat | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/kvm/kvm_stat b/scripts/kvm/kvm_stat > index 3cf1181..517fbec 100755 > --- a/scripts/kvm/kvm_stat > +++ b/scripts/kvm/kvm_stat > @@ -800,7 +800,7 @@ def check_access(options): > if options.tracepoints: > sys.exit(1) > > - sys.stderr.write("Falling back to debugfs statistics!\n" > + sys.stderr.write("Falling back to debugfs statistics!\n") > options.debugfs = True > sleep(5) > Thanks for fixing that. If you also want to fix the missing .format(PATH_DEBUGFS_TRACING) in the write a few lines above, go ahead. I should have been more careful when reading the pull mail from Paolo. The affected lines are not my code and definitely not my v2 which included the "exit if -t is passed explicitly" that Paolo added to my commit.
On Thu, 02/18 12:42, Janosch Frank wrote: > On 02/17/2016 07:18 AM, Fam Zheng wrote: > > Signed-off-by: Fam Zheng <famz@redhat.com> > > --- > > scripts/kvm/kvm_stat | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/scripts/kvm/kvm_stat b/scripts/kvm/kvm_stat > > index 3cf1181..517fbec 100755 > > --- a/scripts/kvm/kvm_stat > > +++ b/scripts/kvm/kvm_stat > > @@ -800,7 +800,7 @@ def check_access(options): > > if options.tracepoints: > > sys.exit(1) > > > > - sys.stderr.write("Falling back to debugfs statistics!\n" > > + sys.stderr.write("Falling back to debugfs statistics!\n") > > options.debugfs = True > > sleep(5) > > > Thanks for fixing that. > If you also want to fix the missing .format(PATH_DEBUGFS_TRACING) in the > write a few lines above, go ahead. > > I should have been more careful when reading the pull mail from Paolo. > The affected lines are not my code and definitely not my v2 which > included the "exit if -t is passed explicitly" that Paolo added to my > commit. > Yep, I can do it. Will send v2. Fam
diff --git a/scripts/kvm/kvm_stat b/scripts/kvm/kvm_stat index 3cf1181..517fbec 100755 --- a/scripts/kvm/kvm_stat +++ b/scripts/kvm/kvm_stat @@ -800,7 +800,7 @@ def check_access(options): if options.tracepoints: sys.exit(1) - sys.stderr.write("Falling back to debugfs statistics!\n" + sys.stderr.write("Falling back to debugfs statistics!\n") options.debugfs = True sleep(5)
Signed-off-by: Fam Zheng <famz@redhat.com> --- scripts/kvm/kvm_stat | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)