| Message ID | 1305035390-31439-1-git-send-email-simon.farnsworth@onelan.co.uk (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
Em 10-05-2011 10:49, Simon Farnsworth escreveu: > The initialisation of vb_type in serialized_open was preventing > REQBUFS from working reliably. Remove it, and move the spinlock into > stream_init for good measure - it's only used when we have a stream > that supports videobuf anyway. > > Signed-off-by: Simon Farnsworth <simon.farnsworth@onelan.co.uk> > --- > Mauro, > > This fixes a bug I introduced, and noticed while trying to work out > how videobuf works and interacts with the rest of the driver, in > preparation for working out how to port this code to videobuf2. > > Briefly, if you open a device node at the wrong time, you lose > videobuf support forever. > > Please consider this for 2.6.40, /me is assuming that Andy is ok with it. Ok, I'm adding this to my series, as it is part of the code you added. Thanks, Mauro. -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/media/video/cx18/cx18-fileops.c b/drivers/media/video/cx18/cx18-fileops.c index 6609222..07411f3 100644 --- a/drivers/media/video/cx18/cx18-fileops.c +++ b/drivers/media/video/cx18/cx18-fileops.c @@ -810,9 +810,6 @@ static int cx18_serialized_open(struct cx18_stream *s, struct file *filp) item->cx = cx; item->type = s->type; - spin_lock_init(&s->vbuf_q_lock); - s->vb_type = 0; - item->open_id = cx->open_id++; filp->private_data = &item->fh; diff --git a/drivers/media/video/cx18/cx18-streams.c b/drivers/media/video/cx18/cx18-streams.c index 24c9688..4282ff5 100644 --- a/drivers/media/video/cx18/cx18-streams.c +++ b/drivers/media/video/cx18/cx18-streams.c @@ -275,6 +275,8 @@ static void cx18_stream_init(struct cx18 *cx, int type) init_timer(&s->vb_timeout); spin_lock_init(&s->vb_lock); if (type == CX18_ENC_STREAM_TYPE_YUV) { + spin_lock_init(&s->vbuf_q_lock); + s->vb_type = V4L2_BUF_TYPE_VIDEO_CAPTURE; videobuf_queue_vmalloc_init(&s->vbuf_q, &cx18_videobuf_qops, &cx->pci_dev->dev, &s->vbuf_q_lock,
The initialisation of vb_type in serialized_open was preventing REQBUFS from working reliably. Remove it, and move the spinlock into stream_init for good measure - it's only used when we have a stream that supports videobuf anyway. Signed-off-by: Simon Farnsworth <simon.farnsworth@onelan.co.uk> --- Mauro, This fixes a bug I introduced, and noticed while trying to work out how videobuf works and interacts with the rest of the driver, in preparation for working out how to port this code to videobuf2. Briefly, if you open a device node at the wrong time, you lose videobuf support forever. Please consider this for 2.6.40, Simon drivers/media/video/cx18/cx18-fileops.c | 3 --- drivers/media/video/cx18/cx18-streams.c | 2 ++ 2 files changed, 2 insertions(+), 3 deletions(-)