diff mbox

[RFC] Make dvb_net.c optional

Message ID 201105191035.04185.hselasky@c2i.net (mailing list archive)
State Changes Requested
Headers show

Commit Message

Hans Petter Selasky May 19, 2011, 8:35 a.m. UTC
Hi,

In my setup I am building the DVB code without dvb_net.c, because there is no 
IP-stack currently in my "Linux kernel". Is this worth a separate 
configuration entry?

--HPS

Comments

Mauro Carvalho Chehab May 21, 2011, 10:58 a.m. UTC | #1
Em 19-05-2011 05:35, Hans Petter Selasky escreveu:
> Hi,
> 
> In my setup I am building the DVB code without dvb_net.c, because there is no 
> IP-stack currently in my "Linux kernel". Is this worth a separate 
> configuration entry?

I have no problems with that, but your patch is wrong ;) It is not adding the new
symbol at the Kconfig. IMHO, if we add such patch, the defaut for config DVB_NET
should be y, and such symbol needs to depend on having the network enabled.

Cheers,
Mauro

> 
> --HPS

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Hans Petter Selasky May 22, 2011, 9:17 a.m. UTC | #2
On Saturday 21 May 2011 12:58:33 Mauro Carvalho Chehab wrote:
> Em 19-05-2011 05:35, Hans Petter Selasky escreveu:
> > Hi,
> > 
> > In my setup I am building the DVB code without dvb_net.c, because there
> > is no IP-stack currently in my "Linux kernel". Is this worth a separate
> > configuration entry?
> 
> I have no problems with that, but your patch is wrong ;) It is not adding
> the new symbol at the Kconfig. IMHO, if we add such patch, the defaut for
> config DVB_NET should be y, and such symbol needs to depend on having the
> network enabled.

Yes, I know my patch is not complete. Then I will go ahead and make a complete 
patch and post it. Thank you!

--HPS
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

From e7fe34933638e882e1ed1eab1761ecd14ef9125e Mon Sep 17 00:00:00 2001
From: Hans Petter Selasky <hselasky@c2i.net>
Date: Thu, 19 May 2011 02:26:33 +0200
Subject: [PATCH] Make dvb_net configurable.

---
 ../media_tree/drivers/media/dvb/dvb-core/Makefile |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/../media_tree/drivers/media/dvb/dvb-core/Makefile b/../media_tree/drivers/media/dvb/dvb-core/Makefile
index 0b51828..8f22bcd 100644
--- a/../media_tree/drivers/media/dvb/dvb-core/Makefile
+++ b/../media_tree/drivers/media/dvb/dvb-core/Makefile
@@ -2,8 +2,10 @@ 
 # Makefile for the kernel DVB device drivers.
 #
 
+dvb-net-$(CONFIG_DVB_NET) := dvb_net.o
+
 dvb-core-objs := dvbdev.o dmxdev.o dvb_demux.o dvb_filter.o 	\
 		 dvb_ca_en50221.o dvb_frontend.o 		\
-		 dvb_net.o dvb_ringbuffer.o dvb_math.o
+		 $(dvb-net-y) dvb_ringbuffer.o dvb_math.o
 
 obj-$(CONFIG_DVB_CORE) += dvb-core.o
-- 
1.7.1.1