diff mbox

dtb: amd: Fix-up for ccn504 and kcs nodes

Message ID 1455236443-23949-1-git-send-email-Suravee.Suthikulpanit@amd.com (mailing list archive)
State New, archived
Headers show

Commit Message

Suravee Suthikulpanit Feb. 12, 2016, 12:20 a.m. UTC 
From: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>

This is a fix-up patch based on the review comment from
Arnd regarding:
    * fix ccn504 address in the node name
    * remove kcs interrupt-name

Signed-off-by: Brijesh Singh <brijesh.singh@amd.com>
Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
Cc: Arnd Bergmann <arnd@arndb.de>
---

Hi Olof,

Here are the changes from the V3 that I sent earlier. Sorry for confusion.
Would you please pull this into the next tree?

Thank you,
Suravee

 arch/arm64/boot/dts/amd/amd-seattle-soc.dtsi | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Olof Johansson Feb. 24, 2016, 10:01 p.m. UTC | #1 
On Fri, Feb 12, 2016 at 07:20:43AM +0700, Suravee Suthikulpanit wrote:
> From: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
> 
> This is a fix-up patch based on the review comment from
> Arnd regarding:
>     * fix ccn504 address in the node name
>     * remove kcs interrupt-name
> 
> Signed-off-by: Brijesh Singh <brijesh.singh@amd.com>
> Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
> Cc: Arnd Bergmann <arnd@arndb.de>
> ---
> 
> Hi Olof,
> 
> Here are the changes from the V3 that I sent earlier. Sorry for confusion.
> Would you please pull this into the next tree?
> 
> Thank you,
> Suravee

Applied.

I also noticed that the patch subjects were nonstandard the last time around.
In the future, please use:

arm64: dts: amd: ...

as prefix, instead of just dtb (which is the binary format). I fixed it up for
this patch, and the others, well, they're already applied. So let's try to
remember it for the future.


-Olof
Suravee Suthikulpanit Feb. 25, 2016, 5:23 a.m. UTC | #2 
Hi,

On 02/25/2016 05:01 AM, Olof Johansson wrote:
> On Fri, Feb 12, 2016 at 07:20:43AM +0700, Suravee Suthikulpanit wrote:
>> From: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
>>
>> This is a fix-up patch based on the review comment from
>> Arnd regarding:
>>      * fix ccn504 address in the node name
>>      * remove kcs interrupt-name
>>
>> Signed-off-by: Brijesh Singh <brijesh.singh@amd.com>
>> Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
>> Cc: Arnd Bergmann <arnd@arndb.de>
>> ---
>>
>> Hi Olof,
>>
>> Here are the changes from the V3 that I sent earlier. Sorry for confusion.
>> Would you please pull this into the next tree?
>>
>> Thank you,
>> Suravee
>
> Applied.
>
> I also noticed that the patch subjects were nonstandard the last time around.
> In the future, please use:
>
> arm64: dts: amd: ...
>
> as prefix, instead of just dtb (which is the binary format). I fixed it up for
> this patch, and the others, well, they're already applied. So let's try to
> remember it for the future.
>
>
> -Olof
>

Thanks, and sorry for the mis-use of the subject line.

Suravee
diff mbox

Patch

diff --git a/arch/arm64/boot/dts/amd/amd-seattle-soc.dtsi b/arch/arm64/boot/dts/amd/amd-seattle-soc.dtsi
index a7fc059..bd3adea 100644
--- a/arch/arm64/boot/dts/amd/amd-seattle-soc.dtsi
+++ b/arch/arm64/boot/dts/amd/amd-seattle-soc.dtsi
@@ -231,7 +231,7 @@ 
 		};
 
 		/* Perf CCN504 PMU */
-		ccn: ccn@0xe8000000 {
+		ccn: ccn@e8000000 {
 			compatible = "arm,ccn-504";
 			reg = <0x0 0xe8000000 0 0x1000000>;
 			interrupts = <0 380 4>;
@@ -243,7 +243,6 @@ 
 			device_type = "ipmi";
 			reg = <0x0 0xe0010000 0 0x8>;
 			interrupts = <0 389 4>;
-			interrupt-names = "ipmi_kcs";
 			reg-size = <1>;
 			reg-spacing = <4>;
 		};