| Message ID | 1305800662-21241-1-git-send-email-fyang@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, 2011-05-19 at 18:24 +0800, fyang@redhat.com wrote: > From: Feng Yang <fyang@redhat.com> > > Current working folder for > unattended_install_config = UnattendedInstallConfig(test, params) > unattended_install_config.setup() > must be kvm folder. This is not needed at all. What might be going on your setup is some incorrectly set or absent path that might be messing up with relative paths during your install. Please provide some more info so we can fix your problem properly. Meanwhile I'm marking this as 'rejected'. Thanks! > Signed-off-by: Feng Yang <fyang@redhat.com> > --- > client/tests/kvm/tests/unattended_install.py | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/client/tests/kvm/tests/unattended_install.py b/client/tests/kvm/tests/unattended_install.py > index 50a8c7a..eee1761 100644 > --- a/client/tests/kvm/tests/unattended_install.py > +++ b/client/tests/kvm/tests/unattended_install.py > @@ -506,8 +506,11 @@ def run_unattended_install(test, params, env): > @param params: Dictionary with the test parameters. > @param env: Dictionary with test environment. > """ > + cur_folder = os.getcwd() > + os.chdir(test.bindir) > unattended_install_config = UnattendedInstallConfig(test, params) > unattended_install_config.setup() > + os.chdir(cur_folder) > vm = env.get_vm(params["main_vm"]) > vm.create() > -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 05/21/2011 02:59 AM, Lucas Meneghel Rodrigues wrote: > On Thu, 2011-05-19 at 18:24 +0800, fyang@redhat.com wrote: >> From: Feng Yang<fyang@redhat.com> >> >> Current working folder for >> unattended_install_config = UnattendedInstallConfig(test, params) >> unattended_install_config.setup() >> must be kvm folder. > This is not needed at all. What might be going on your setup is some > incorrectly set or absent path that might be messing up with relative > paths during your install. > > Please provide some more info so we can fix your problem properly. > Meanwhile I'm marking this as 'rejected'. > > Thanks! Thanks for your comment. After merge upstream code to our local tree, I found that our local unattended_install could not work. Before, Current working folder for unattended.py is kvm folder, changed in process_command. Now Current working folder for unattended_install_config = UnattendedInstallConfig(test, params) unattended_install_config.setup() changed to case result folder. So our unattended_install always fails at could not find ks.iso. Then I send this patch. I will recheck our local code and configure. Thanks very much! Feng Yang >> Signed-off-by: Feng Yang<fyang@redhat.com> >> --- >> client/tests/kvm/tests/unattended_install.py | 3 +++ >> 1 files changed, 3 insertions(+), 0 deletions(-) >> >> diff --git a/client/tests/kvm/tests/unattended_install.py b/client/tests/kvm/tests/unattended_install.py >> index 50a8c7a..eee1761 100644 >> --- a/client/tests/kvm/tests/unattended_install.py >> +++ b/client/tests/kvm/tests/unattended_install.py >> @@ -506,8 +506,11 @@ def run_unattended_install(test, params, env): >> @param params: Dictionary with the test parameters. >> @param env: Dictionary with test environment. >> """ >> + cur_folder = os.getcwd() >> + os.chdir(test.bindir) >> unattended_install_config = UnattendedInstallConfig(test, params) >> unattended_install_config.setup() >> + os.chdir(cur_folder) >> vm = env.get_vm(params["main_vm"]) >> vm.create() >> > > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/client/tests/kvm/tests/unattended_install.py b/client/tests/kvm/tests/unattended_install.py index 50a8c7a..eee1761 100644 --- a/client/tests/kvm/tests/unattended_install.py +++ b/client/tests/kvm/tests/unattended_install.py @@ -506,8 +506,11 @@ def run_unattended_install(test, params, env): @param params: Dictionary with the test parameters. @param env: Dictionary with test environment. """ + cur_folder = os.getcwd() + os.chdir(test.bindir) unattended_install_config = UnattendedInstallConfig(test, params) unattended_install_config.setup() + os.chdir(cur_folder) vm = env.get_vm(params["main_vm"]) vm.create()