| Message ID | 1456766626-20807-1-git-send-email-sudipm.mukherjee@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | dbc77eed6553362e08c1874ff30df640c96eca92 |
| Headers | show |
On Mon, Feb 29, 2016 at 10:53:46PM +0530, Sudip Mukherjee wrote: > The variable cmd_id is only assigned some value and is never used. > > Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk> Your signoff doesn't correspond to your e-mail address. While I'm fairly sure that you are in fact the same person so it's OK this time please try to ensure that they match up so that it's clear that the signoffs are all in order.
On Tue, Mar 01, 2016 at 11:59:12AM +0900, Mark Brown wrote: > On Mon, Feb 29, 2016 at 10:53:46PM +0530, Sudip Mukherjee wrote: > > The variable cmd_id is only assigned some value and is never used. > > > > Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk> > > Your signoff doesn't correspond to your e-mail address. While I'm > fairly sure that you are in fact the same person so it's OK this time > please try to ensure that they match up so that it's clear that the > signoffs are all in order. But it has been like this way since I started contributing. git log --author=sudip will show you. From: address was always sudipm.mukherjee@gmail.com but Signed-off-by: was sudip@vectorindia.org and now Signed-off-by: has changed to sudip.mukherjee@codethink.co.uk and you already have many such patches from me. (well, with my vectorindia.org email) Can i not keep using my gmail as my From: ? The advantage of using gmail as my From: is that the discussion and all threads related to my patches will be in the same place even if my work email is changed. And AFAIK, the From: name and the Signed-off-by: name should match else the tools used by Greg and others to generate the stats will break. Please reconsider and let me use my gmail in my From: regards sudip
On Tue, 01 Mar 2016 06:49:27 +0100, Sudip Mukherjee wrote: > > On Tue, Mar 01, 2016 at 11:59:12AM +0900, Mark Brown wrote: > > On Mon, Feb 29, 2016 at 10:53:46PM +0530, Sudip Mukherjee wrote: > > > The variable cmd_id is only assigned some value and is never used. > > > > > > Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk> > > > > Your signoff doesn't correspond to your e-mail address. While I'm > > fairly sure that you are in fact the same person so it's OK this time > > please try to ensure that they match up so that it's clear that the > > signoffs are all in order. > > But it has been like this way since I started contributing. > git log --author=sudip will show you. > > From: address was always sudipm.mukherjee@gmail.com > but Signed-off-by: was sudip@vectorindia.org and now > Signed-off-by: has changed to sudip.mukherjee@codethink.co.uk > and you already have many such patches from me. (well, with my > vectorindia.org email) > > Can i not keep using my gmail as my From: ? > The advantage of using gmail as my From: is that the discussion and all > threads related to my patches will be in the same place even if my work > email is changed. > > And AFAIK, the From: name and the Signed-off-by: name should match else > the tools used by Greg and others to generate the stats will break. > > Please reconsider and let me use my gmail in my From: Using a different author address from the sign-off is unusual, but there are a few people preferring it, indeed, AFAIK. Takashi
On Tue, Mar 01, 2016 at 11:19:27AM +0530, Sudip Mukherjee wrote: > Can i not keep using my gmail as my From: ? > The advantage of using gmail as my From: is that the discussion and all > threads related to my patches will be in the same place even if my work > email is changed. That's fine (I'm doing something similar), just use that as your signoff address then. > And AFAIK, the From: name and the Signed-off-by: name should match else > the tools used by Greg and others to generate the stats will break. I don't understand - what I'm pointing out here is that they do not match?
On Wed, Mar 02, 2016 at 10:02:23AM +0900, Mark Brown wrote: > On Tue, Mar 01, 2016 at 11:19:27AM +0530, Sudip Mukherjee wrote: > > > Can i not keep using my gmail as my From: ? > > The advantage of using gmail as my From: is that the discussion and all > > threads related to my patches will be in the same place even if my work > > email is changed. > > That's fine (I'm doing something similar), just use that as your signoff > address then. > > > And AFAIK, the From: name and the Signed-off-by: name should match else > > the tools used by Greg and others to generate the stats will break. > > I don't understand - what I'm pointing out here is that they do not > match? Now I am confused. :( My From: is Sudip Mukherjee <sudipm.mukherjee@gmaill.com> and my Signed-off-by: is Sudip Mukherjee <sudip.mukherjee@codethink.co.uk> My From name and Signed-off name matches. But my emails donot match. regards sudip
On Wed, Mar 02, 2016 at 11:56:28AM +0530, Sudip Mukherjee wrote: > > > And AFAIK, the From: name and the Signed-off-by: name should match else > > > the tools used by Greg and others to generate the stats will break. > > I don't understand - what I'm pointing out here is that they do not > > match? > Now I am confused. :( > My From: is Sudip Mukherjee <sudipm.mukherjee@gmaill.com> > and my Signed-off-by: is Sudip Mukherjee <sudip.mukherjee@codethink.co.uk> > My From name and Signed-off name matches. But my emails donot match. The e-mail address is part of your signoff like the name.
On Wed, 2 Mar 2016 11:56:28 +0530 Sudip Mukherjee <sudipm.mukherjee@gmail.com> wrote: > On Wed, Mar 02, 2016 at 10:02:23AM +0900, Mark Brown wrote: > > On Tue, Mar 01, 2016 at 11:19:27AM +0530, Sudip Mukherjee wrote: > > > > > Can i not keep using my gmail as my From: ? > > > The advantage of using gmail as my From: is that the discussion and all > > > threads related to my patches will be in the same place even if my work > > > email is changed. > > > > That's fine (I'm doing something similar), just use that as your signoff > > address then. > > > > > And AFAIK, the From: name and the Signed-off-by: name should match else > > > the tools used by Greg and others to generate the stats will break. > > > > I don't understand - what I'm pointing out here is that they do not > > match? > > Now I am confused. :( > My From: is Sudip Mukherjee <sudipm.mukherjee@gmaill.com> > and my Signed-off-by: is Sudip Mukherjee <sudip.mukherjee@codethink.co.uk> > > My From name and Signed-off name matches. But my emails donot match. Which is fine - unless you are submitting patches to Mark 8). I also usually split my email address and GregKH doesn't seem to mind at all. The other option I suppose would be to put both addresses in the signed off by sequence, but that probably causes confusion Alan
On Wed, Mar 02, 2016 at 12:27:09PM +0000, One Thousand Gnomes wrote: > On Wed, 2 Mar 2016 11:56:28 +0530 > Sudip Mukherjee <sudipm.mukherjee@gmail.com> wrote: > > > On Wed, Mar 02, 2016 at 10:02:23AM +0900, Mark Brown wrote: > > > On Tue, Mar 01, 2016 at 11:19:27AM +0530, Sudip Mukherjee wrote: > > > > > > > Can i not keep using my gmail as my From: ? > > > > The advantage of using gmail as my From: is that the discussion and all > > > > threads related to my patches will be in the same place even if my work > > > > email is changed. > > > > > > That's fine (I'm doing something similar), just use that as your signoff > > > address then. > > > > > > > And AFAIK, the From: name and the Signed-off-by: name should match else > > > > the tools used by Greg and others to generate the stats will break. > > > > > > I don't understand - what I'm pointing out here is that they do not > > > match? > > > > Now I am confused. :( > > My From: is Sudip Mukherjee <sudipm.mukherjee@gmaill.com> > > and my Signed-off-by: is Sudip Mukherjee <sudip.mukherjee@codethink.co.uk> > > > > My From name and Signed-off name matches. But my emails donot match. > > Which is fine - unless you are submitting patches to Mark 8). I also > usually split my email address and GregKH doesn't seem to mind at all. Well, Mark has also accepted many patches from me which has same name but different email addresses. > > The other option I suppose would be to put both addresses in the signed > off by sequence, but that probably causes confusion yes, maybe. I believe I should be responsible for the patches which I have sent and any regression or problem because of any of my patch should come to me. If I just use my corporate email address in both my From: and Signed-off: then I will not be reachable after I change job. regards sudip
On Wed, Mar 02, 2016 at 12:27:09PM +0000, One Thousand Gnomes wrote: > Sudip Mukherjee <sudipm.mukherjee@gmail.com> wrote: > > My From: is Sudip Mukherjee <sudipm.mukherjee@gmaill.com> > > and my Signed-off-by: is Sudip Mukherjee <sudip.mukherjee@codethink.co.uk> > > My From name and Signed-off name matches. But my emails donot match. > Which is fine - unless you are submitting patches to Mark 8). I also > usually split my email address and GregKH doesn't seem to mind at all. I usually end up applying but I don't like having to think about it and normally only for people I recognise both addresses and all the names for - there's a lot of places that can fall over. I've noticed an increase in the number of people missing out signoffs recently for some reason so anything that looks like a non-author message is a red flag. > The other option I suppose would be to put both addresses in the signed > off by sequence, but that probably causes confusion The other option is to just not use the work address if you don't want to use it (that's what I do).
On Wed, Mar 02, 2016 at 06:37:50PM +0530, Sudip Mukherjee wrote: > On Wed, Mar 02, 2016 at 12:27:09PM +0000, One Thousand Gnomes wrote: > > The other option I suppose would be to put both addresses in the signed > > off by sequence, but that probably causes confusion > yes, maybe. I believe I should be responsible for the patches which I > have sent and any regression or problem because of any of my patch > should come to me. If I just use my corporate email address in both my > From: and Signed-off: then I will not be reachable after I change job. People will probably figure it out if you're still around, it's not like you'd be the only person to ever change address. Or just do one of the other things.
> > The other option I suppose would be to put both addresses in the signed > > off by sequence, but that probably causes confusion > > The other option is to just not use the work address if you don't want > to use it (that's what I do). That assumes your work email system can handle kernel traffic and doesn't inflict things like Microsoft Outlook or mash up the content or add bogus footers. There are plenty of people who really don't want to be using their work email for the kernel 8) Alan
On Wed, Mar 02, 2016 at 01:53:23PM +0000, One Thousand Gnomes wrote: > > The other option is to just not use the work address if you don't want > > to use it (that's what I do). > That assumes your work email system can handle kernel traffic and doesn't > inflict things like Microsoft Outlook or mash up the content or add bogus > footers. > There are plenty of people who really don't want to be using their work > email for the kernel 8) I think you read the exact opposite of what I wrote there!
On Wednesday 02 March 2016 06:50 PM, Mark Brown wrote: > On Wed, Mar 02, 2016 at 12:27:09PM +0000, One Thousand Gnomes wrote: >> Sudip Mukherjee <sudipm.mukherjee@gmail.com> wrote: > >>> My From: is Sudip Mukherjee <sudipm.mukherjee@gmaill.com> >>> and my Signed-off-by: is Sudip Mukherjee <sudip.mukherjee@codethink.co.uk> > >>> My From name and Signed-off name matches. But my emails donot match. > >> Which is fine - unless you are submitting patches to Mark 8). I also >> usually split my email address and GregKH doesn't seem to mind at all. > > I usually end up applying but I don't like having to think about it and > normally only for people I recognise both addresses and all the names > for - there's a lot of places that can fall over. I was suspecting that since this is a new email address so you objected whereas you have seen my vectorindia email many times so you got used to it. :) Let me use my new email address the way I was using my old address and you will see its same "me". > I've noticed an > increase in the number of people missing out signoffs recently for some > reason so anything that looks like a non-author message is a red flag. > >> The other option I suppose would be to put both addresses in the signed >> off by sequence, but that probably causes confusion > > The other option is to just not use the work address if you don't want > to use it (that's what I do). Since I use my work resources and office working hours to generate and submit patches so I think I should use my work address as signoff. regards sudip
diff --git a/sound/soc/intel/atom/sst/sst_ipc.c b/sound/soc/intel/atom/sst/sst_ipc.c index 3dc7358..8afa6fe 100644 --- a/sound/soc/intel/atom/sst/sst_ipc.c +++ b/sound/soc/intel/atom/sst/sst_ipc.c @@ -318,7 +318,6 @@ void sst_process_reply_mrfld(struct intel_sst_drv *sst_drv_ctx, union ipc_header_high msg_high; u32 msg_low; struct ipc_dsp_hdr *dsp_hdr; - unsigned int cmd_id; msg_high = msg->mrfld_header.p.header_high; msg_low = msg->mrfld_header.p.header_low_payload; @@ -357,7 +356,6 @@ void sst_process_reply_mrfld(struct intel_sst_drv *sst_drv_ctx, return; /* Copy command id so that we can use to put sst to reset */ dsp_hdr = (struct ipc_dsp_hdr *)data; - cmd_id = dsp_hdr->cmd_id; dev_dbg(sst_drv_ctx->dev, "cmd_id %d\n", dsp_hdr->cmd_id); if (sst_wake_up_block(sst_drv_ctx, msg_high.part.result, msg_high.part.drv_id,
The variable cmd_id is only assigned some value and is never used. Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk> --- sound/soc/intel/atom/sst/sst_ipc.c | 2 -- 1 file changed, 2 deletions(-)