diff mbox

clk: xgene: Add missing parenthesis when clearing divider value

Message ID 1456780543-13770-1-git-send-email-lho@apm.com (mailing list archive)
State New, archived
Headers show

Commit Message

Loc Ho Feb. 29, 2016, 9:15 p.m. UTC 
In the initial fix for non-zero divider shift value, the parenthesis
was missing after the negate operation. This patch adds the required
parenthesis. Otherwise, lower bits may be cleared unintentionally.

Signed-off-by: Loc Ho <lho@apm.com>
Acked-by: Toan Le <toanle@apm.com>
---
 drivers/clk/clk-xgene.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

Comments

Stephen Boyd March 3, 2016, 7:37 p.m. UTC | #1 
On 02/29, Loc Ho wrote:
> In the initial fix for non-zero divider shift value, the parenthesis
> was missing after the negate operation. This patch adds the required
> parenthesis. Otherwise, lower bits may be cleared unintentionally.
> 
> Signed-off-by: Loc Ho <lho@apm.com>
> Acked-by: Toan Le <toanle@apm.com>
> ---

Applied to clk-next + added a fixes tag.
diff mbox

Patch

diff --git a/drivers/clk/clk-xgene.c b/drivers/clk/clk-xgene.c
index bd7156b..d73450b 100644
--- a/drivers/clk/clk-xgene.c
+++ b/drivers/clk/clk-xgene.c
@@ -376,8 +376,8 @@  static int xgene_clk_set_rate(struct clk_hw *hw, unsigned long rate,
 		/* Set new divider */
 		data = xgene_clk_read(pclk->param.divider_reg +
 				pclk->param.reg_divider_offset);
-		data &= ~((1 << pclk->param.reg_divider_width) - 1)
-				<< pclk->param.reg_divider_shift;
+		data &= ~(((1 << pclk->param.reg_divider_width) - 1)
+				<< pclk->param.reg_divider_shift);
 		data |= divider;
 		xgene_clk_write(data, pclk->param.divider_reg +
 					pclk->param.reg_divider_offset);