diff mbox

[v3,4/8] Documentation: devicetree: Clean up gpio-keys example

Message ID 1457294038-14243-5-git-send-email-afaerber@suse.de (mailing list archive)
State New, archived
Headers show

Commit Message

Andreas Färber March 6, 2016, 7:53 p.m. UTC
Drop #address-cells and #size-cells, which are not required by the
gpio-keys binding documentation, as button sub-nodes are not devices.

Reported-by: Julien Chauveau <chauveau.julien@gmail.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
 v3: New (Julien)
 
 Documentation/devicetree/bindings/input/gpio-keys.txt | 2 --
 1 file changed, 2 deletions(-)

Comments

Heiko Stuebner March 7, 2016, 6:05 p.m. UTC | #1
Am Sonntag, 6. März 2016, 20:53:53 schrieb Andreas Färber:
> Drop #address-cells and #size-cells, which are not required by the
> gpio-keys binding documentation, as button sub-nodes are not devices.
> 
> Reported-by: Julien Chauveau <chauveau.julien@gmail.com>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> ---

changes to input-device bindings should go through the input tree, and thus 
include Dmitry Thorokhov and the linux-input lists.


Heiko

>  v3: New (Julien)
> 
>  Documentation/devicetree/bindings/input/gpio-keys.txt | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/input/gpio-keys.txt
> b/Documentation/devicetree/bindings/input/gpio-keys.txt index
> 21641236c095..1552a11f6786 100644
> --- a/Documentation/devicetree/bindings/input/gpio-keys.txt
> +++ b/Documentation/devicetree/bindings/input/gpio-keys.txt
> @@ -34,8 +34,6 @@ Example nodes:
> 
>  	gpio_keys {
>  			compatible = "gpio-keys";
> -			#address-cells = <1>;
> -			#size-cells = <0>;
>  			autorepeat;
>  			button@21 {
>  				label = "GPIO Key UP";
Andreas Färber March 7, 2016, 6:27 p.m. UTC | #2
Am 07.03.2016 um 19:05 schrieb Heiko Stübner:
> Am Sonntag, 6. März 2016, 20:53:53 schrieb Andreas Färber:
>> Drop #address-cells and #size-cells, which are not required by the
>> gpio-keys binding documentation, as button sub-nodes are not devices.
>>
>> Reported-by: Julien Chauveau <chauveau.julien@gmail.com>
>> Signed-off-by: Andreas Färber <afaerber@suse.de>
>> ---
> 
> changes to input-device bindings should go through the input tree, and thus 
> include Dmitry Thorokhov and the linux-input lists.

Thanks for noticing, MAINTAINERS update proposed and resent this patch
using it.

Andreas
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/input/gpio-keys.txt b/Documentation/devicetree/bindings/input/gpio-keys.txt
index 21641236c095..1552a11f6786 100644
--- a/Documentation/devicetree/bindings/input/gpio-keys.txt
+++ b/Documentation/devicetree/bindings/input/gpio-keys.txt
@@ -34,8 +34,6 @@  Example nodes:
 
 	gpio_keys {
 			compatible = "gpio-keys";
-			#address-cells = <1>;
-			#size-cells = <0>;
 			autorepeat;
 			button@21 {
 				label = "GPIO Key UP";