diff mbox

tty: amba-pl011: Use 32-bit accesses for SBSA UART

Message ID 1457415800-8799-1-git-send-email-cov@codeaurora.org (mailing list archive)
State Not Applicable, archived
Delegated to: Andy Gross
Headers show

Commit Message

Christopher Covington March 8, 2016, 5:43 a.m. UTC 
From: Christopher Covington <christopher.covington@linaro.org>

Version 2 of the Server Base System Architecture (SBSA) describes the
Generic UART registers as 32 bits wide. At least one implementation, found
of the Qualcomm Technologies QDF2432, only supports 32 bit accesses. While
other implementations may also support smaller sized accesses, simply use
32 bit accesses all the time for the SBSA UART for simple, broad,
compatibility.

Signed-off-by: Christopher Covington <cov@codeaurora.org>
---
 drivers/tty/serial/amba-pl011.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Mark Langsdorf March 8, 2016, 2:51 p.m. UTC | #1 
On 03/07/2016 11:43 PM, Christopher Covington wrote:
> From: Christopher Covington <christopher.covington@linaro.org>
>
> Version 2 of the Server Base System Architecture (SBSA) describes the
> Generic UART registers as 32 bits wide. At least one implementation, found
> of the Qualcomm Technologies QDF2432, only supports 32 bit accesses. While
> other implementations may also support smaller sized accesses, simply use
> 32 bit accesses all the time for the SBSA UART for simple, broad,
> compatibility.
>
> Signed-off-by: Christopher Covington <cov@codeaurora.org>
> ---

I can boot the v4.5-rc7 on my QDF2432 platform with this patch,
and could not otherwise.

Tested-by: Mark Langsdorf <mlangsdo@redhat.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/tty/serial/amba-pl011.c b/drivers/tty/serial/amba-pl011.c
index c0da0cc..ffb5eb8 100644
--- a/drivers/tty/serial/amba-pl011.c
+++ b/drivers/tty/serial/amba-pl011.c
@@ -121,6 +121,7 @@  static struct vendor_data vendor_arm = {
 
 static struct vendor_data vendor_sbsa = {
 	.reg_offset		= pl011_std_offsets,
+	.access_32b		= true,
 	.oversampling		= false,
 	.dma_threshold		= false,
 	.cts_event_workaround	= false,