diff mbox

[2/2] KVM-test: kvm_vm.py: Add quotation marks for appended arguments

Message ID 20110525022449.3264.49173.stgit@t (mailing list archive)
State New, archived
Headers show

Commit Message

Amos Kong May 25, 2011, 2:24 a.m. UTC
Appended kernel cmdline should be involved by quotation marks.
-append 'root=/dev/vda ro ..'

Reported-by: Cong Wang <amwang@redhat.com>
Signed-off-by: Amos Kong <akong@redhat.com>
---
 client/virt/kvm_vm.py |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Amerigo Wang May 25, 2011, 3:04 a.m. UTC | #1
Amos, thanks for fixing it!
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Lucas Meneghel Rodrigues May 25, 2011, 8:07 p.m. UTC | #2
On Tue, May 24, 2011 at 11:24 PM, Amos Kong <akong@redhat.com> wrote:
> Appended kernel cmdline should be involved by quotation marks.
> -append 'root=/dev/vda ro ..'

Applied, thanks!

> Reported-by: Cong Wang <amwang@redhat.com>
> Signed-off-by: Amos Kong <akong@redhat.com>
> ---
>  client/virt/kvm_vm.py |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/client/virt/kvm_vm.py b/client/virt/kvm_vm.py
> index c9bb273..343488f 100644
> --- a/client/virt/kvm_vm.py
> +++ b/client/virt/kvm_vm.py
> @@ -332,7 +332,7 @@ class VM(virt_vm.BaseVM):
>             return " -initrd '%s'" % filename
>
>         def add_kernel_cmdline(help, cmdline):
> -            return " -append %s" % cmdline
> +            return " -append '%s'" % cmdline
>
>         def add_testdev(help, filename):
>             return (" -chardev file,id=testlog,path=%s"
>
> _______________________________________________
> Autotest mailing list
> Autotest@test.kernel.org
> http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
>
diff mbox

Patch

diff --git a/client/virt/kvm_vm.py b/client/virt/kvm_vm.py
index c9bb273..343488f 100644
--- a/client/virt/kvm_vm.py
+++ b/client/virt/kvm_vm.py
@@ -332,7 +332,7 @@  class VM(virt_vm.BaseVM):
             return " -initrd '%s'" % filename
 
         def add_kernel_cmdline(help, cmdline):
-            return " -append %s" % cmdline
+            return " -append '%s'" % cmdline
 
         def add_testdev(help, filename):
             return (" -chardev file,id=testlog,path=%s"