| Message ID | 37c0717b00fdbde343089324fdf642fbcab69f29.1457585839.git.shuahkh@osg.samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Shuah,
[auto build test ERROR on sailus-media/master]
[cannot apply to v4.5-rc7 next-20160309]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]
url: https://github.com/0day-ci/linux/commits/Shuah-Khan/media-add-change_source-handler-support/20160310-131140
base: git://linuxtv.org/media_tree.git master
config: x86_64-rhel (attached as .config)
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
drivers/media/usb/au0828/au0828-video.c: In function 'vidioc_s_input':
>> drivers/media/usb/au0828/au0828-video.c:1474:2: error: implicit declaration of function 'v4l_change_media_source' [-Werror=implicit-function-declaration]
return v4l_change_media_source(vfd);
^
cc1: some warnings being treated as errors
vim +/v4l_change_media_source +1474 drivers/media/usb/au0828/au0828-video.c
1468 au0828_s_input(dev, index);
1469
1470 /*
1471 * Input has been changed. Change to media source
1472 * associated with the for the newly set input.
1473 */
> 1474 return v4l_change_media_source(vfd);
1475 }
1476
1477 static int vidioc_enumaudio(struct file *file, void *priv, struct v4l2_audio *a)
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
diff --git a/drivers/media/usb/au0828/au0828-video.c b/drivers/media/usb/au0828/au0828-video.c index aeaf27e..020c9d5 100644 --- a/drivers/media/usb/au0828/au0828-video.c +++ b/drivers/media/usb/au0828/au0828-video.c @@ -1545,12 +1545,10 @@ static int vidioc_s_input(struct file *file, void *priv, unsigned int index) au0828_s_input(dev, index); /* - * Input has been changed. Disable the media source - * associated with the old input and enable source - * for the newly set input + * Input has been changed. Change to media source + * associated with the for the newly set input. */ - v4l_disable_media_source(vfd); - return v4l_enable_media_source(vfd); + return v4l_change_media_source(vfd); } static int vidioc_enumaudio(struct file *file, void *priv, struct v4l2_audio *a)
Change vidioc_s_input() to call v4l_change_media_source() to disable current source and enable new source when user switches input. Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com> --- drivers/media/usb/au0828/au0828-video.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-)