| Message ID | 20110524194701.6a4c1bd4@epia.jer-c2.orkz.net (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On Tuesday, May 24, 2011 13:47:01 Jeroen Roovers wrote: > Do not set CROSS_COMPILE but let CONFIG_CROSS_COMPILE handle it all. > The problem this fixes manifests itself when you try to build a 64-bit > kernel on a distro which does not provide hppa$(WIDTH)-linux-gnu- but > perhaps hppa$(WIDTH)-unknown-linux-gnu- instead, like Gentoo Linux. > > --- a/arch/parisc/Makefile > +++ b/arch/parisc/Makefile > @@ -31,16 +31,10 @@ > UTS_MACHINE := parisc64 > CHECKFLAGS += -D__LP64__=1 -m64 > WIDTH := 64 > -CROSS_COMPILE := hppa64-linux-gnu- > else # 32-bit > WIDTH := > endif > > -# attempt to help out folks who are cross-compiling > -ifeq ($(NATIVE),1) > -CROSS_COMPILE := hppa$(WIDTH)-linux- > -endif i wonder if there isnt some middle ground. like only setting CROSS_COMPILE like so: ifeq ($(CROSS_COMPILE),) CROSS_COMPILE := hppa$(WIDTH)-linux- endif i think that should still work if people set CONFIG_CROSS_COMPILE, but if they havent, get the existing (semi-sane) defaults. -mike
also, since this is a parisc-specific patch, i'd suggest a summary that reflects that. perhaps something like: parisc: do not always override CROSS_COMPILE -mike
--- a/arch/parisc/Makefile +++ b/arch/parisc/Makefile @@ -31,16 +31,10 @@ UTS_MACHINE := parisc64 CHECKFLAGS += -D__LP64__=1 -m64 WIDTH := 64 -CROSS_COMPILE := hppa64-linux-gnu- else # 32-bit WIDTH := endif -# attempt to help out folks who are cross-compiling -ifeq ($(NATIVE),1) -CROSS_COMPILE := hppa$(WIDTH)-linux- -endif - OBJCOPY_FLAGS =-O binary -R .note -R .comment -S cflags-y := -pipe
Do not set CROSS_COMPILE but let CONFIG_CROSS_COMPILE handle it all. The problem this fixes manifests itself when you try to build a 64-bit kernel on a distro which does not provide hppa$(WIDTH)-linux-gnu- but perhaps hppa$(WIDTH)-unknown-linux-gnu- instead, like Gentoo Linux. Signed-off-by: Jeroen Roovers <jer@gentoo.org> --- -- To unsubscribe from this list: send the line "unsubscribe linux-parisc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html