diff mbox

Input: egalax_ts - remove unused definitions

Message ID 1457129278-9165-1-git-send-email-festevam@gmail.com (mailing list archive)
State Rejected
Headers show

Commit Message

Fabio Estevam March 4, 2016, 10:07 p.m. UTC
From: Fabio Estevam <fabio.estevam@nxp.com>

REPORT_MODE_MOUSE and REPORT_MODE_VENDOR are never used in the driver,
so let's just remove them.

Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
 drivers/input/touchscreen/egalax_ts.c | 12 ------------
 1 file changed, 12 deletions(-)

Comments

Dmitry Torokhov March 11, 2016, 6:08 p.m. UTC | #1
Hi Fabio,

On Fri, Mar 04, 2016 at 07:07:58PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
> 
> REPORT_MODE_MOUSE and REPORT_MODE_VENDOR are never used in the driver,
> so let's just remove them.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
>  drivers/input/touchscreen/egalax_ts.c | 12 ------------
>  1 file changed, 12 deletions(-)
> 
> diff --git a/drivers/input/touchscreen/egalax_ts.c b/drivers/input/touchscreen/egalax_ts.c
> index 1afc08b..a260476 100644
> --- a/drivers/input/touchscreen/egalax_ts.c
> +++ b/drivers/input/touchscreen/egalax_ts.c
> @@ -29,18 +29,6 @@
>  #include <linux/input/mt.h>
>  #include <linux/of_gpio.h>
>  
> -/*
> - * Mouse Mode: some panel may configure the controller to mouse mode,
> - * which can only report one point at a given time.
> - * This driver will ignore events in this mode.
> - */
> -#define REPORT_MODE_MOUSE		0x1
> -/*
> - * Vendor Mode: this mode is used to transfer some vendor specific
> - * messages.
> - * This driver will ignore events in this mode.
> - */
> -#define REPORT_MODE_VENDOR		0x3

Keeping this does not add to runtime size and is not excessive, I do not
see harm in not keeping it.

>  /* Multiple Touch Mode */
>  #define REPORT_MODE_MTTOUCH		0x4
>  
> -- 
> 1.9.1
> 

Thanks.
diff mbox

Patch

diff --git a/drivers/input/touchscreen/egalax_ts.c b/drivers/input/touchscreen/egalax_ts.c
index 1afc08b..a260476 100644
--- a/drivers/input/touchscreen/egalax_ts.c
+++ b/drivers/input/touchscreen/egalax_ts.c
@@ -29,18 +29,6 @@ 
 #include <linux/input/mt.h>
 #include <linux/of_gpio.h>
 
-/*
- * Mouse Mode: some panel may configure the controller to mouse mode,
- * which can only report one point at a given time.
- * This driver will ignore events in this mode.
- */
-#define REPORT_MODE_MOUSE		0x1
-/*
- * Vendor Mode: this mode is used to transfer some vendor specific
- * messages.
- * This driver will ignore events in this mode.
- */
-#define REPORT_MODE_VENDOR		0x3
 /* Multiple Touch Mode */
 #define REPORT_MODE_MTTOUCH		0x4